Specify str type when using pytest CaptureFixture

Author: connesy

tests/test_venv_clear.py

@@ -6,7 +6,7 @@
 
 
 @pytest.mark.order(after="test_venv_install.py::test_venv_install")
-def test_venv_clear(tmp_path: Path, capfd: pytest.CaptureFixture):
+def test_venv_clear(tmp_path: Path, capfd: pytest.CaptureFixture[str]):
     """Checks that we can clear installed packages in an environment after installing them"""
     run_command(commands=["venv install --skip-lock", "venv clear"], activated=True, cwd=tmp_path)
 

tests/test_venv_deactivate.py

@@ -11,7 +11,7 @@ def test_venv_deactivate(tmp_path: Path):
     run_command("venv deactivate", activated=True, cwd=tmp_path)
 
 
-def test_venv_deactivate_noop(tmp_path: Path, capfd: pytest.CaptureFixture):
+def test_venv_deactivate_noop(tmp_path: Path, capfd: pytest.CaptureFixture[str]):
     """Checks that trying to deactivate an environment that is not activated does nothing"""
     run_command("venv deactivate", cwd=tmp_path)
 

tests/test_venv_help.py

@@ -6,7 +6,7 @@
 
 
 @pytest.mark.parametrize("arg", ["", "-h", "--help"])
-def test_venv_help(arg: str, tmp_path: Path, capfd: pytest.CaptureFixture):
+def test_venv_help(arg: str, tmp_path: Path, capfd: pytest.CaptureFixture[str]):
     """Checks that we can get the help menu for the main 'venv' command"""
     run_command(f"venv {arg}", cwd=tmp_path)
 

tests/test_venv_install.py

@@ -37,7 +37,7 @@ def test_venv_install_requirements(
     requirements_stem: RequirementsStem,
     use_file_name: bool,
     tmp_path: Path,
-    capfd: pytest.CaptureFixture,
+    capfd: pytest.CaptureFixture[str],
 ):
     write_files(files=files, dir=tmp_path)
 
@@ -56,7 +56,7 @@ def test_venv_install_requirements(
     )
 
     # Check pip install log output
-    output: str = capfd.readouterr().out
+    output = capfd.readouterr().out
     assert f"Installing requirements from {requirements_stem.value}.txt" in output
 
     installed_line = [line for line in output.splitlines() if line.startswith("Successfully installed")][0]

tests/test_venv_internals.py

@@ -57,7 +57,7 @@ def test_venv_check_install_requirements_file(filename: str, expected: bool):
             run_command(command)
 
 
-def test_venv_check_install_requirements_file_quiet(capfd: pytest.CaptureFixture):
+def test_venv_check_install_requirements_file_quiet(capfd: pytest.CaptureFixture[str]):
     """Check that 'venv::_check_install_requirements_file' can raise silently if called with -q"""
     # Call command with bad argument, not silenced
     with pytest.raises(subprocess.CalledProcessError):
@@ -109,7 +109,7 @@ def test_venv_check_lock_requirements_file(filename: str, expected_success: bool
             run_command(command)
 
 
-def test_venv_check_lock_requirements_file_quiet(capfd: pytest.CaptureFixture):
+def test_venv_check_lock_requirements_file_quiet(capfd: pytest.CaptureFixture[str]):
     """Check that 'venv::_check_lock_requirements_file' can raise silently if called with -q"""
     # Call command with bad argument, not silenced
     with pytest.raises(subprocess.CalledProcessError):
@@ -136,7 +136,7 @@ def test_venv_check_lock_requirements_file_quiet(capfd: pytest.CaptureFixture):
         ("requirements/requirements.lock", "requirements/requirements.lock"),
     ],
 )
-def test_venv_get_lock_from_requirements(filename: str, expected: str, capfd: pytest.CaptureFixture):
+def test_venv_get_lock_from_requirements(filename: str, expected: str, capfd: pytest.CaptureFixture[str]):
     """Check that 'venv::_get_lock_from_requirements' works as expected"""
     run_command(f'venv::_get_lock_from_requirements "{filename}"')
     result = capfd.readouterr().out.strip()
@@ -155,7 +155,7 @@ def test_venv_get_lock_from_requirements(filename: str, expected: str, capfd: py
         ("requirements/requirements.txt", "requirements/requirements.txt"),
     ],
 )
-def test_venv_get_requirements_from_lock(filename: str, expected: str, capfd: pytest.CaptureFixture):
+def test_venv_get_requirements_from_lock(filename: str, expected: str, capfd: pytest.CaptureFixture[str]):
     """Check that 'venv::_get_requirements_from_lock' works as expected"""
     run_command(f'venv::_get_requirements_from_lock "{filename}"')
     result = capfd.readouterr().out.strip()

tests/test_venv_lock.py

@@ -65,7 +65,7 @@ def test_venv_lock_raises(lock_arg: str, tmp_path: Path):
         "test_venv_fill_credentials.py::test_venv_fill_credentials",
     ]
 )
-def test_venv_lock_echo(tmp_path: Path, capfd: pytest.CaptureFixture):
+def test_venv_lock_echo(tmp_path: Path, capfd: pytest.CaptureFixture[str]):
     """Checks that 'venv lock' echoes a message when executed"""
     run_command("venv lock", activated=True, cwd=tmp_path)
 

tests/test_venv_raise.py

@@ -7,7 +7,7 @@
 
 @pytest.mark.order("first")
 @pytest.mark.parametrize("message", ["", '"This is an error"'])
-def test_venv_raise(message: str, capfd: pytest.CaptureFixture):
+def test_venv_raise(message: str, capfd: pytest.CaptureFixture[str]):
     with pytest.raises(subprocess.CalledProcessError):
         run_command(f"venv::raise {message}")
 

tests/test_venv_version.py

@@ -8,7 +8,7 @@
 
 
 @pytest.mark.parametrize("arg", ["-V", "--version"])
-def test_venv_version(arg: str, capfd: pytest.CaptureFixture):
+def test_venv_version(arg: str, capfd: pytest.CaptureFixture[str]):
     """Checks that we can show the version number, and that the version number
     complies with the required pattern"""
     run_command(f"venv {arg}")