Well, maybe not standard, but 10,464,158 downloads last month vs 984 make
'some' difference. (npm info)

As you see - virustotal.js has been
#4 refactored to use
request.
You don't have to merge it, you are the boss.

On Tue, Jan 26, 2016 at 6:28 PM Ștefan Rusu notifications@github.com
wrote:

If by "much better" you mean that it's bit more easier to install than
http-request, then yeah. However, this isn't something that occurred to me
as I never used Windows as development or target platform. Never will.

Otherwise, you're not making any friends by claiming that my work is
inferior without actually checking all the facts / providing any proof.
Blank statements don't qualify as constructive criticism. Also, in relation
to #4 #4, what makes
request being "the standard" module? There's only one standard module,
http.js (and by extension https.js).

It's unfortunate that nobody bothered to write a native JavaScript library
for libmagic databases, which makes mmmagic the only (sane) option when it
comes to proper MIME type detection which makes mmmagic painful for some
users, but http-request isn't providing crippled functionality for that
reason.

I guess virustotal.js may be refactored to use request. The MIME detection
is not used by virustotal.js while the transparent gzip / deflate
compression doesn't bring a lot of improvements for this particular use
case, therefore missing this feature from the HTTP library isn't a deal
breaker.

—
Reply to this email directly or view it on GitHub
#3 (comment)
.

Why not using the much better request module? #3

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions