Skip to content

Commit 9da1b5a

Browse files
committed
[FLINK-36332] pass flink-versions as object
1 parent 39b9964 commit 9da1b5a

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,7 @@ jobs:
8080
uses: ./.github/workflows/e2e.yaml
8181
with:
8282
java-version: ${{ matrix.java-version }}
83-
flink-version: "v1_20"
84-
flink-image: "flink:1.20"
83+
flink-version: "{tag: \"v1_20", image: "flink:1.20\"}"
8584
http-client: ${{ matrix.http-client }}
8685
test: test_application_operations.sh
8786

.github/workflows/e2e.yaml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,6 @@ on:
99
flink-version:
1010
required: true
1111
type: string
12-
flink-image:
13-
required: true
14-
type: string
1512
http-client:
1613
required: false
1714
type: string
@@ -30,6 +27,7 @@ on:
3027

3128
jobs:
3229
e2e_test:
30+
name: ${{ inputs.test }}
3331
runs-on: ubuntu-latest
3432
steps:
3533
- uses: actions/checkout@v4
@@ -64,8 +62,11 @@ jobs:
6462
kubectl get pods -n ${{ inputs.namespace }}
6563
- name: Run Flink e2e tests
6664
run: |
67-
sed -i "s/image: flink:.*/image: ${{ inputs.flink-image }}/" e2e-tests/data/*.yaml
68-
sed -i "s/flinkVersion: .*/flinkVersion: ${{ inputs.flink-version }}/" e2e-tests/data/*.yaml
65+
echo versions:${{ fromJSON(inputs.flink-version) }}
66+
echo image:${{ fromJSON(inputs.flink-version).image }}
67+
echo tag:${{ fromJSON(inputs.flink-version).tag }}
68+
sed -i "s/image: flink:.*/image: ${{ fromJSON(inputs.flink-version).image }}/" e2e-tests/data/*.yaml
69+
sed -i "s/flinkVersion: .*/flinkVersion: ${{ fromJSON(inputs.flink-version).tag }}/" e2e-tests/data/*.yaml
6970
sed -i "s/mode: .*/mode: ${{ inputs.mode }}/" e2e-tests/data/*.yaml
7071
git diff HEAD
7172
echo "Running e2e-tests/$test"

0 commit comments

Comments
 (0)