File tree Expand file tree Collapse file tree 1 file changed +3
-4
lines changed
kroxylicious-integration-tests/src/test/java/io/kroxylicious/proxy Expand file tree Collapse file tree 1 file changed +3
-4
lines changed Original file line number Diff line number Diff line change 2929
3030/**
3131 * For the kafka RPCs that Kroxylicious can intercept, Kroxylicious should only offer API versions
32- * that it can encode/decode using it's version of the kafka-clients lib. It should also only offer API versions
32+ * that it can encode/decode using its version of the kafka-clients lib. It should also only offer API versions
3333 * that the Cluster can understand. So we use a Filter to intercept the ApiVersions response from the
3434 * Cluster and intersect those versions with the versions supported by the proxy. We offer the highest
3535 * minimum version for each api key supported by the Cluster and proxy. We offer the lowest maximum version
3636 * for each api key supported by the Cluster and proxy.
37- * Any versions for ApiKeys unknown to the proxy are forwarded to the client untouched. (ie the broker supports
38- * a new ApiKey that this version of Kroxylicious is unaware of)
39- * TODO check if this is still sensible behaviour, potentially a RequestFilter would attempt to decode these and fail.
37+ * Any versions for ApiKeys unknown to the proxy are removed from the response. (ie the broker supports
38+ * a new ApiKey that this version of Kroxylicious is unaware of).
4039 */
4140@ ExtendWith (NettyLeakDetectorExtension .class )
4241public class ApiVersionsIT {
You can’t perform that action at this time.
0 commit comments