Skip to content

Commit 44be092

Browse files
authored
Merge pull request kroxylicious#1651 from robobario/fix-comment
Fix incorrect integration test comment
2 parents c477aaa + c6b384d commit 44be092

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

kroxylicious-integration-tests/src/test/java/io/kroxylicious/proxy/ApiVersionsIT.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,13 @@
2929

3030
/**
3131
* For the kafka RPCs that Kroxylicious can intercept, Kroxylicious should only offer API versions
32-
* that it can encode/decode using it's version of the kafka-clients lib. It should also only offer API versions
32+
* that it can encode/decode using its version of the kafka-clients lib. It should also only offer API versions
3333
* that the Cluster can understand. So we use a Filter to intercept the ApiVersions response from the
3434
* Cluster and intersect those versions with the versions supported by the proxy. We offer the highest
3535
* minimum version for each api key supported by the Cluster and proxy. We offer the lowest maximum version
3636
* for each api key supported by the Cluster and proxy.
37-
* Any versions for ApiKeys unknown to the proxy are forwarded to the client untouched. (ie the broker supports
38-
* a new ApiKey that this version of Kroxylicious is unaware of)
39-
* TODO check if this is still sensible behaviour, potentially a RequestFilter would attempt to decode these and fail.
37+
* Any versions for ApiKeys unknown to the proxy are removed from the response. (ie the broker supports
38+
* a new ApiKey that this version of Kroxylicious is unaware of).
4039
*/
4140
@ExtendWith(NettyLeakDetectorExtension.class)
4241
public class ApiVersionsIT {

0 commit comments

Comments
 (0)