Merge pull request kroxylicious#1876 from robobario/run-minikube-tests

Run operator minikube tests

Author: robobario

.github/workflows/maven.yaml

@@ -44,6 +44,12 @@ jobs:
         with:
           java-version: 21
           distribution: 'temurin'
+      - name: Setup Minikube
+        uses: manusa/actions-setup-minikube@v2.13.1
+        with:
+          minikube version: 'v1.35.0'
+          kubernetes version: 'v1.32.0'
+          github token: ${{ secrets.GITHUB_TOKEN }}
       - name: 'Test for unpublished reference release (japicmp)'
         run: |
           REFERENCE_RELEASE=$(mvn --quiet -pl kroxylicious-api help:evaluate -Dexpression=ApiCompatability.ReferenceVersion -DforceStdout)

kroxylicious-operator/pom.xml

@@ -194,6 +194,21 @@
     </dependencies>
     <build>
         <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-failsafe-plugin</artifactId>
+                <configuration>
+                    <runOrder>random</runOrder>
+                </configuration>
+                <executions>
+                    <execution>
+                        <goals>
+                            <goal>integration-test</goal>
+                            <goal>verify</goal>
+                        </goals>
+                    </execution>
+                </executions>
+            </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-assembly-plugin</artifactId>

kroxylicious-operator/src/test/java/io/kroxylicious/kubernetes/operator/OperatorMainIT.java

@@ -7,8 +7,10 @@
 package io.kroxylicious.kubernetes.operator;
 
 import org.assertj.core.api.Assumptions;
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
+@Disabled
 class OperatorMainIT {
     // This is an IT because it depends on having a running Kube cluster
 

kroxylicious-operator/src/test/java/io/kroxylicious/kubernetes/operator/ProxyReconcilerIT.java

@@ -10,6 +10,7 @@
 import java.util.List;
 import java.util.Map;
 import java.util.Set;
+import java.util.concurrent.TimeUnit;
 import java.util.stream.Collectors;
 
 import org.assertj.core.api.AbstractStringAssert;
@@ -22,6 +23,7 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import io.fabric8.kubernetes.api.model.Pod;
 import io.fabric8.kubernetes.api.model.Secret;
 import io.fabric8.kubernetes.api.model.Service;
 import io.fabric8.kubernetes.api.model.Volume;
@@ -58,6 +60,19 @@ class ProxyReconcilerIT {
     static void checkKubeAvailable() {
         client = OperatorTestUtils.kubeClientIfAvailable();
         Assumptions.assumeThat(client).describedAs("Test requires a viable kube client").isNotNull();
+        preloadOperatorImage();
+    }
+
+    // the initial operator image pull can take a long time and interfere with the tests
+    private static void preloadOperatorImage() {
+        String operandImage = ProxyDeployment.getOperandImage();
+        Pod pod = client.run().withName("preload-operator-image")
+                .withNewRunConfig()
+                .withImage(operandImage)
+                .withRestartPolicy("Never")
+                .withCommand("ls").done();
+        client.resource(pod).waitUntilCondition(it -> it.getStatus().getPhase().equals("Succeeded"), 2, TimeUnit.MINUTES);
+        client.resource(pod).delete();
     }
 
     @RegisterExtension
@@ -95,11 +110,24 @@ CreatedResources doCreate() {
 
         assertProxyConfigContents(proxy, Set.of(CLUSTER_FOO_BOOTSTRAP, CLUSTER_BAR_BOOTSTRAP), Set.of());
         assertDeploymentMountsConfigSecret(proxy);
+        assertDeploymentBecomesReady(proxy);
         assertServiceTargetsProxyInstances(proxy, clusters);
-
         return new CreatedResources(proxy, clusters);
     }
 
+    private void assertDeploymentBecomesReady(KafkaProxy proxy) {
+        // wait longer for initial operator image download
+        await().alias("Deployment as expected").untilAsserted(() -> {
+            var deployment = extension.get(Deployment.class, ProxyDeployment.deploymentName(proxy));
+            assertThat(deployment).isNotNull()
+                    .extracting(Deployment::getStatus)
+                    .describedAs("All deployment replicas should become ready")
+                    .satisfies(status -> {
+                        assertThat(status.getReplicas()).isEqualTo(status.getReadyReplicas());
+                    });
+        });
+    }
+
     private void assertServiceTargetsProxyInstances(KafkaProxy proxy, Set<VirtualKafkaCluster> clusters) {
         await().alias("cluster Services as expected").untilAsserted(() -> {
             for (var cluster : clusters) {
@@ -171,6 +199,7 @@ void testUpdateVirtualCluster() {
         VirtualKafkaCluster cluster = createdResources.cluster(CLUSTER_FOO).edit().editSpec().editTargetCluster().editBootstrapping().withBootstrapAddress(NEW_BOOTSTRAP)
                 .endBootstrapping().endTargetCluster().endSpec().build();
         extension.replace(cluster);
+        assertDeploymentBecomesReady(proxy);
         await().untilAsserted(() -> {
             var secret = extension.get(Secret.class, ProxyConfigSecret.secretName(proxy));
             assertThat(secret)
@@ -204,6 +233,7 @@ void testAddVirtualCluster() {
                     .extracting(map -> map.get(ProxyConfigSecret.CONFIG_YAML_KEY), InstanceOfAssertFactories.STRING)
                     .contains(CLUSTER_BAZ_BOOTSTRAP);
         });
+        assertDeploymentBecomesReady(proxy);
 
         await().untilAsserted(() -> {
             assertClusterServiceExists(proxy, CLUSTER_FOO);
@@ -229,6 +259,7 @@ void testDeleteVirtualCluster() {
                     .doesNotContain(CLUSTER_FOO_BOOTSTRAP)
                     .contains(CLUSTER_BAR_BOOTSTRAP);
         });
+        assertDeploymentBecomesReady(proxy);
 
         await().untilAsserted(() -> {
             var service = extension.get(Service.class, CLUSTER_FOO);
@@ -259,6 +290,8 @@ void moveVirtualKafkaClusterToAnotherKafkaProxy() {
         // when
         extension.replace(virtualKafkaCluster(CLUSTER_BAR, CLUSTER_BAR_BOOTSTRAP, proxyB));
         // then
+        assertDeploymentBecomesReady(proxyA);
+        assertDeploymentBecomesReady(proxyB);
         Set<String> doesNotContain = Set.of(CLUSTER_BAR_BOOTSTRAP);
         assertProxyConfigContents(proxyA, Set.of(CLUSTER_FOO_BOOTSTRAP), doesNotContain);
         assertProxyConfigContents(proxyB, Set.of(CLUSTER_BAZ_BOOTSTRAP, CLUSTER_BAR_BOOTSTRAP), Set.of());