Commit f09297d
authored
Disable nondeterministic IT (kroxylicious#3048)
Our dream was that we could guarantee that chained work is executed on
the filter dispatch executor. However in the empty case we complete
extremely quickly so there is a possibility that work chained on to
filterContext.topicNames(xyz) will execute in the calling thread, not
the filter dispatch thread.
We need to decide if we take things further, like implementing our own
CompletionStage with a different execution guarantee than
CompletableFuture. Or we could rely on javadoc to let developers know that
if they call topicNames from an uncontrolled thread, they will need to
switch back to the filterDispatchExecutor to mutate filter members
safely using a then*Async method of the CompletionStage.
Signed-off-by: Robert Young <[email protected]>1 parent 5cf5851 commit f09297d
File tree
1 file changed
+2
-0
lines changed- kroxylicious-integration-tests/src/test/java/io/kroxylicious/proxy
1 file changed
+2
-0
lines changedLines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| 40 | + | |
40 | 41 | | |
41 | 42 | | |
42 | 43 | | |
| |||
130 | 131 | | |
131 | 132 | | |
132 | 133 | | |
| 134 | + | |
133 | 135 | | |
134 | 136 | | |
135 | 137 | | |
| |||
0 commit comments