PSSA replace aliases

Author: SamErde

Active Directory/AD Groups/Copy-GroupMembership.ps1

@@ -1,3 +1,5 @@
 # This is ancient. I need to rewrite this, wherever it came from!
 Import-Module ActiveDirectory
-Get-AdGroupMember "SourceGroupA-sAMAccountName" | %{Add-ADGroupMember -Identity "DestinationGroupB-sAMAccountName" -Members $_}
+Get-ADGroupMember 'SourceGroupA-sAMAccountName' | ForEach-Object {
+    Add-ADGroupMember -Identity 'DestinationGroupB-sAMAccountName' -Members $_
+}

Active Directory/AD Users/Find 'Do Not Require Kerberos Preauthentication' .ps1

@@ -1,9 +1,9 @@
-$Users = Get-ADUser -Filter * -Properties DoesNotRequirePreauth | Where-Object {$_.DoesNotRequirePreauth -eq $True}
-$Users | Select-Object Name,SamAccountName,UserPrincipalName,DoesNotRequirePreauth | FT
+$Users = Get-ADUser -Filter * -Properties DoesNotRequirePreauth | Where-Object { $_.DoesNotRequirePreauth -eq $True }
+$Users | Select-Object Name, SamAccountName, UserPrincipalName, DoesNotRequirePreauth | Format-Table
 $Users.Count
 
 #Prevent accidental running before ready
 break
 
 # Turn off "DoesNotRequirePreauth" for all users.
-Get-ADUser -Filter * | Set-ADAccountControl -DoesNotRequirePreauth $False
+Get-ADUser -Filter * | Set-ADAccountControl -DoesNotRequirePreAuth $False

Active Directory/Domain Services/Checking and Setting AD Schema Attributes.ps1

@@ -1,21 +1,23 @@
 Import-Module ActiveDirectory
-Set-ADUser 'Bilbo Baggins' -Add @{drink="coffee"}
+Set-ADUser 'Bilbo Baggins' -Add @{drink = 'coffee' }
 Get-ADUser 'Bilbo Baggins' -Properties drink | Select-Object *
 
 $Users = Get-ADUser -Filter 'Enabled -eq $true' -Properties drink
-$Drinks = $Users | Group drink
+$Drinks = $Users | Group-Object drink
 $Drinks
 
 $SchemaPath = (Get-ADRootDSE).schemaNamingContext
 $DrinkSchema = Get-ADObject -Filter 'Name -like "drink"' -SearchBase $SchemaPath -Properties *
+[void]$DrinkSchema
 $UserSchema = Get-ADObject -Filter 'Name -like "user"' -SearchBase $SchemaPath -Properties *
 $PersonSchema = Get-ADObject -Filter 'Name -like "person"' -SearchBase $SchemaPath -Properties *
+[void]$PersonSchema
 $Attributes = @()
 $Attributes += $UserSchema.maycontain
 $Attributes += $userSchema.systemMayContain
 $Attributes += $UserSchema.auxiliaryClass
 $Attributes += $UserSchema.systemAuxiliaryClass
-$Attributes = $Attributes | Sort
+$Attributes = $Attributes | Sort-Object
 
 $Attributes
 $UserSchema.AddedProperties
@@ -24,19 +26,19 @@ $UserSchema.AddedProperties
 Import-Module ActiveDirectory
 
 # Get the schema object for the drink attribute
-$schemaObject = Get-ADObject -Filter {name -eq 'drink'} -SearchBase (Get-ADRootDSE).schemaNamingContext -Properties isDefunct
+$schemaObject = Get-ADObject -Filter { name -eq 'drink' } -SearchBase (Get-ADRootDSE).schemaNamingContext -Properties isDefunct
 
 # Check if the drink attribute is enabled in the schema
 if ($schemaObject.isDefunct) {
-    Write-Output "The drink attribute is not enabled."
+    Write-Output 'The drink attribute is not enabled.'
 } else {
-    Write-Output "The drink attribute is enabled."
+    Write-Output 'The drink attribute is enabled.'
 }
 
 # Check if the drink attribute is added to the user class
-$userClass = Get-ADObject -Filter {name -eq 'user'} -SearchBase (Get-ADRootDSE).schemaNamingContext -Properties mayContain
+$userClass = Get-ADObject -Filter { name -eq 'user' } -SearchBase (Get-ADRootDSE).schemaNamingContext -Properties mayContain
 if ($userClass.mayContain -contains 'drink') {
-    Write-Output "The drink attribute is added to the user class."
+    Write-Output 'The drink attribute is added to the user class.'
 } else {
-    Write-Output "The drink attribute is not added to the user class."
+    Write-Output 'The drink attribute is not added to the user class.'
 }

Active Directory/Get-LAPSPasswords.ps1

@@ -1,3 +1,3 @@
-Get-adcomputer -SearchBase "OU=Member Servers,DC=DOMAINNAME,DC=org" `
-    -Properties Name,ms-Mcs-AdmPwd,ms-Mcs-AdmPwdExpirationTime -Filter {Name -notlike "*xen*"} | `
-    Select Name,ms-Mcs-AdmPwd,ms-Mcs-AdmPwdExpirationTime | Sort Name | Out-GridView
+Get-ADComputer -SearchBase 'OU=Member Servers,DC=DOMAINNAME,DC=org' `
+    -Properties Name, ms-Mcs-AdmPwd, ms-Mcs-AdmPwdExpirationTime -Filter { Name -notlike '*xen*' } | `
+        Select-Object Name, ms-Mcs-AdmPwd, ms-Mcs-AdmPwdExpirationTime | Sort-Object Name | Out-GridView