Refactor caching of a song's replayGain

This attribute actually belongs in the song object, which is basically a partial join of the client/player object and the track object. (You were right, @mherger  ;-)

Signed-off-by: Sam Y <syahres@gmail.com>

Author: SamInPgh

Slim/Control/Queries.pm

@@ -3962,7 +3962,7 @@ sub statusQuery {
 			$request->addResult('can_seek', 1);
 		}
 
-		my $trackGain = $client->replayGain();
+		my $trackGain = $song->replayGain();
 		if (defined $trackGain) {
 			$request->addResult('replay_gain', $trackGain);
 		}

Slim/Player/Client.pm

@@ -132,7 +132,7 @@ use constant KNOB_NOACCELERATION => 0x02;
 								modeStack modeParameterStack playlist chunks
 								shufflelist shuffleInhibit syncSelections searchTerm
 								updatePending httpState
-								disconnected replayGain
+								disconnected
 							));
 	__PACKAGE__->mk_accessor('hash', qw(
 								curSelection lastID3Selection
@@ -305,8 +305,6 @@ sub new {
 		_pluginData             => {},
 		updatePending           => 0,
 		disconnected            => 0,
-		replayGain              => undef,
-
 	);
 
 	$clientHash{$id} = $client;

Slim/Player/Song.pm

@@ -72,7 +72,7 @@ my @_playlistCloneAttributes = qw(
 
 			samplerate samplesize channels totalbytes offset blockalign isLive
 
-			retryData
+			retryData replayGain
 		),
 	);
 }
@@ -127,6 +127,7 @@ sub new {
 		handler         => $handler,
 		_track          => $track,
 		streamUrl       => $url,	# May get updated later, either here or in handler
+		replayGain      => undef,
 	);
 
 	$self->seekdata($seekdata) if $seekdata;

Slim/Player/StreamingController.pm

@@ -1316,7 +1316,7 @@ sub _Stream {				# play -> Buffering, Streaming
 
 		$startedPlayers += $player->play( \%params );
 
-		$player->replayGain($replayGain);  # store this for status queries
+		$song->replayGain($replayGain);  # store this for status queries
 
 		$reportsTrackStart ||= $player->reportsTrackStart();
 	}