Prevent "Error: Couldn't load module: (jpg)" messages

SamInPgh · SamInPgh · commit a654a9a48613 · 2025-12-03T20:35:32.000-05:00
Check for a valid $formatClass before calling loadTagFormatForType() to avoid logging the following error msg when displaying cover art from the Now Playing view.

Slim::Formats::loadTagFormatForType (121) Error: Couldn't load module:  (jpg) : [syntax error at (eval 5460) line 1, at EOF

Signed-off-by: Sam Y &lt;syahres@gmail.com&gt;
diff --git a/Slim/Web/Graphics.pm b/Slim/Web/Graphics.pm
@@ -453,7 +453,7 @@ sub artworkRequest {
 			my $formatClass = Slim::Formats->classForFormat($ct);
 			my $body;
 
-			if (Slim::Formats->loadTagFormatForType($ct) && $formatClass->can('getCoverArt')) {
+			if ($formatClass && $formatClass->can('getCoverArt') && Slim::Formats->loadTagFormatForType($ct)) {
 				$body = $formatClass->getCoverArt($fullpath);
 			}
 

Original file line number	Diff line number	Diff line change
`@@ -453,7 +453,7 @@ sub artworkRequest {`
`453`	`453`	`my $formatClass = Slim::Formats->classForFormat($ct);`
`454`	`454`	`my $body;`
`455`	`455`
`456`		`- if (Slim::Formats->loadTagFormatForType($ct) && $formatClass->can('getCoverArt')) {`
	`456`	`+ if ($formatClass && $formatClass->can('getCoverArt') && Slim::Formats->loadTagFormatForType($ct)) {`
`457`	`457`	`$body = $formatClass->getCoverArt($fullpath);`
`458`	`458`	`}`
`459`	`459`