Mark PartialReductionRecipe as not having side effects

SamTebbs33 · SamTebbs33 · commit 57a95ed3f8b4 · 2025-04-22T13:07:47.000+01:00
diff --git a/llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp b/llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp
@@ -159,6 +159,7 @@ bool VPRecipeBase::mayHaveSideEffects() const {
   case VPWidenIntrinsicSC:
     return cast<VPWidenIntrinsicRecipe>(this)->mayHaveSideEffects();
   case VPBlendSC:
+  case VPPartialReductionSC:
   case VPReductionEVLSC:
   case VPReductionSC:
   case VPScalarIVStepsSC:
diff --git a/llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp b/llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp
@@ -2461,7 +2461,6 @@ tryToCreateAbstractPartialReductionRecipe(VPPartialReductionRecipe *PRed) {
                                                        Ext0->getResultType());
   AbstractR->insertBefore(PRed);
   PRed->replaceAllUsesWith(AbstractR);
-  PRed->eraseFromParent();
 }
 
 void VPlanTransforms::convertToAbstractRecipes(VPlan &Plan, VPCostContext &Ctx,

Original file line number	Diff line number	Diff line change
`@@ -2461,7 +2461,6 @@ tryToCreateAbstractPartialReductionRecipe(VPPartialReductionRecipe *PRed) {`
`2461`	`2461`	`Ext0->getResultType());`
`2462`	`2462`	`AbstractR->insertBefore(PRed);`
`2463`	`2463`	`PRed->replaceAllUsesWith(AbstractR);`
`2464`		`- PRed->eraseFromParent();`
`2465`	`2464`	`}`
`2466`	`2465`
`2467`	`2466`	`void VPlanTransforms::convertToAbstractRecipes(VPlan &Plan, VPCostContext &Ctx,`