KIT-4555 introduce ruff (#14)

* KIT-4555 introduce ruff

* Update devcontainer.json

* KIT-4555 format all

* Remove flake exclude

---------

Co-authored-by: aott <ottalexanderdev@gmail.com>

Author: oschulzSam

.devcontainer/Dockerfile

@@ -3,5 +3,5 @@ FROM mcr.microsoft.com/devcontainers/python:3.12-bookworm
 
 # Uninstall pre-installed formatting and linting tools
 # They would conflict with our pinned versions
-RUN pipx uninstall flake8
+RUN pipx uninstall ruff
 RUN pipx uninstall mypy

.devcontainer/devcontainer.json

@@ -9,26 +9,16 @@
 			"settings": {
 				"python.pythonPath": "/usr/local/bin/python",
 				"python.defaultInterpreterPath": "/usr/local/bin/python",
-				"python.languageServer": "Pylance",
-				"flake8.path": [
-					"/usr/local/py-utils/bin/bandit",
-					"/usr/local/py-utils/bin/pydocstyle"
-				],
-				"flake8.importStrategy": "fromEnvironment"
+				"python.languageServer": "Pylance"
 			},
 			"extensions": [
 				"AykutSarac.jsoncrack-vscode",
+				"charliermarsh.ruff",
 				"eamodio.gitlens",
 				"geeebe.duplicate",
 				"Gruntfuggly.todo-tree",
-				"kaih2o.python-resource-monitor",
 				"matangover.mypy",
-				"ms-python.black-formatter",
-				"ms-python.flake8",
-				"ms-python.isort",
-				"ms-python.pylint",
 				"ms-python.python",
-				"ms-python.vscode-pylance",
 				"ms-toolsai.jupyter",
 				"njpwerner.autodocstring",
 				"njqdev.vscode-python-typehint",
@@ -38,7 +28,8 @@
 				"streetsidesoftware.code-spell-checker",
 				"tamasfe.even-better-toml",
 				"visualstudioexptteam.vscodeintellicode",
-				"yzhang.markdown-all-in-one"
+				"yzhang.markdown-all-in-one",
+				"kaih2o.python-resource-monitor"
 			]
 		}
 	},
@@ -48,4 +39,4 @@
 	"mounts": [
 		"source=${localEnv:USERPROFILE}/_devcontainer/cache,target=/home/vscode/.cache,type=bind"
 	]
-}
+}

.flake8

@@ -23,15 +23,16 @@ jobs:
           python-version: "3.12"
       - name: Add linting matchers
         run: |
-          echo "::add-matcher::.github/flake8-error-problem-matcher.json"
-          echo "::add-matcher::.github/flake8-warning-problem-matcher.json"
           echo "::add-matcher::.github/mypy-error-problem-matcher.json"
-      - name: Lint
-        uses: py-actions/flake8@v2
       - name: Install dependencies
         run: |
           python -m pip install --upgrade pip
           pip install -r requirements-dev.txt
+      - name: Create ruff failures dir
+        run: mkdir -p ./ruff_failures
+      - name: Lint with ruff
+        run: |
+          ruff check --output-format github . || echo "sag_py_auth" >> ./ruff_failures/ruff_failures.txt
       - name: Lint typing
         # Must run with installed dependencies
         run: |

.github/flake8-error-problem-matcher.json

@@ -13,6 +13,7 @@
 .idea/sqlDataSources.xml
 .idea/dynamic.xml
 .idea/dictionaries
+.idea/ruff.xml
 
 ## File-based project format
 *.ipr

.github/flake8-warning-problem-matcher.json

@@ -6,6 +6,7 @@ exclude =  (?x)(
     venv/
     | build/
     | dist/
+    | /site-packages/
   )
 follow_imports = silent
 # Suppresses error messages about imports that cannot be resolved.