Skip to content

Commit ae5a893

Browse files
authored
[one-cmds] Tidy python3.8 support (#15610)
This will tidy one-prepare-venv with Ubuntu18.04 python3.8 support. ONE-DCO-1.0-Signed-off-by: SaeHie Park <saehie.park@gmail.com>
1 parent 9963098 commit ae5a893

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

compiler/one-cmds/one-prepare-venv

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@
1414
# See the License for the specific language governing permissions and
1515
# limitations under the License.
1616

17-
# NOTE check if we can use python3.8 for Ubuntu 18.04.
18-
# use +e as python3.8 may not exist in the system and 'command' will return error.
17+
# NOTE check if we can use python3.10 for Ubuntu 20.04.
18+
# use +e as python3.10 may not exist in the system and 'command' will return error.
1919
set +e
2020

21-
PYTHON_CANDIDATES=("python3.12" "python3.10" "python3.8" "python3")
21+
PYTHON_CANDIDATES=("python3.12" "python3.10" "python3")
2222
for py in "${PYTHON_CANDIDATES[@]}"; do
2323
PYTHON3_EXEC=$(command -v "$py")
2424
if [[ -n "${PYTHON3_EXEC}" ]]; then
@@ -70,9 +70,7 @@ VER_NUMPY=1.24.3
7070

7171
PYTHON_VER=$(${PYTHON3_EXEC} -c "import sys; print(f'{sys.version_info.major}.{sys.version_info.minor}')" )
7272
echo "Setting package version for python $PYTHON_VER"
73-
if [[ "$PYTHON_VER" == "3.8" ]]; then
74-
: # use as is
75-
elif [[ "$PYTHON_VER" == "3.10" ]]; then
73+
if [[ "$PYTHON_VER" == "3.10" ]]; then
7674
: # TODO change vesions
7775
elif [[ "$PYTHON_VER" == "3.12" ]]; then
7876
: # TODO change vesions

0 commit comments

Comments
 (0)