Skip to content

Commit ef73992

Browse files
committed
[dalgona] Use python3.10 and above
This will re-enable and revise to use python3.10 and above. ONE-DCO-1.0-Signed-off-by: SaeHie Park <saehie.park@gmail.com>
1 parent 50a53b9 commit ef73992

File tree

1 file changed

+8
-13
lines changed

1 file changed

+8
-13
lines changed

compiler/dalgona/CMakeLists.txt

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,23 @@
1-
# Temporary disable test, reenable after python upgrade is finished
2-
return()
3-
4-
# NOTE find_package will try to use at least python3.8 as follows depending on platform version
5-
# Ubuntu18.04; explictly installed python3.8 (default is python3.6)
6-
# Ubuntu20.04; default python3.8
1+
# NOTE find_package will try to use at least python3.10 as follows depending on platform version
2+
# Ubuntu20.04; explictly installed python3.10 (default is python3.8)
73
# Ubuntu22.04; default python3.10
84
# Ubuntu24.04; default python3.12
95
# refer https://github.com/Samsung/ONE/issues/9962
6+
# refer https://github.com/Samsung/ONE/issues/15226
107
# NOTE Require same python version of common-artifacts
11-
# find python 3.8 or above
12-
find_package(Python 3.8 EXACT COMPONENTS Interpreter Development QUIET)
8+
# find python 3.10 or above
9+
find_package(Python 3.10 EXACT COMPONENTS Interpreter Development QUIET)
1310
if(NOT Python_FOUND)
14-
find_package(Python 3.8 COMPONENTS Interpreter Development QUIET)
11+
find_package(Python 3.10 COMPONENTS Interpreter Development QUIET)
1512
endif()
1613

1714
if(NOT Python_Development_FOUND)
1815
message(STATUS "Build dalgona: FAILED (Python3 development package is missing)")
1916
return()
2017
endif()
2118

22-
# NOTE assume only use 3.8.x or 3.10.x or 3.12.x
23-
if((Python_VERSION VERSION_GREATER_EQUAL 3.8) AND (Python_VERSION VERSION_LESS 3.9))
24-
set(PYTHON_VERSION_MINOR 8)
25-
elseif((Python_VERSION VERSION_GREATER_EQUAL 3.10) AND (Python_VERSION VERSION_LESS 3.11))
19+
# NOTE assume only use 3.10.x or 3.12.x
20+
if((Python_VERSION VERSION_GREATER_EQUAL 3.10) AND (Python_VERSION VERSION_LESS 3.11))
2621
set(PYTHON_VERSION_MINOR 10)
2722
elseif((Python_VERSION VERSION_GREATER_EQUAL 3.12) AND (Python_VERSION VERSION_LESS 3.13))
2823
set(PYTHON_VERSION_MINOR 12)

0 commit comments

Comments
 (0)