Stop bluetooth scanning on back, make constant for log tags, change screenshots

Author: r-bhalotia

Mobile/LeScanner/Lescanner/Constants.cs

@@ -0,0 +1,13 @@
+namespace Lescanner
+{
+    /// <summary>
+    /// Common constants used throughout the Lescanner application.
+    /// </summary>
+    public static class Constants
+    {
+        /// <summary>
+        /// Log tag used for all logging in the Lescanner application.
+        /// </summary>
+        public const string LOG_TAG = "Lescanner";
+    }
+}

Mobile/LeScanner/Lescanner/DeviceListPage.cs

@@ -34,18 +34,55 @@ public DeviceListPage(TizenBLEService bleService, Navigator navigator)
             _bleService = bleService;
             _navigator = navigator;
             _uiContext = SynchronizationContext.Current; // Capture main UI thread context
+
             AppBar = new AppBar { Title = "Device List" };
-            InitializeComponent();
 
+            if (AppBar.Title != null)
+            {
+                AppBar.Title = AppBar.Title.PadLeft(20);
+            }
+
             // Subscribe to BLE service events
             _bleService.DeviceDiscovered += OnDeviceDiscovered;
             _bleService.GattConnectionStateChanged += OnGattConnectionStateChanged; // For connection feedback
             _bleService.DeviceNameRetrieved += OnDeviceNameRetrieved; // Subscribe to name retrieval event
 
+            InitializeComponent();
+            
+            // Add back button to AppBar
+            AddBackButtonToAppBar();
+
             // Start scanning process when the page is created.
             StartScanningProcess();
         }
 
+        /// <summary>
+        /// Adds a back button to the AppBar.
+        /// </summary>
+        private void AddBackButtonToAppBar()
+        {
+            if (AppBar != null)
+            {
+                // Create a back button
+                var backButton = new Button()
+                {
+                    Text = "Back",
+                    WidthSpecification = 80,
+                    HeightSpecification = 40
+                };
+                
+                // Set button background color
+                backButton.BackgroundColor = new Color(0.2f, 0.6f, 1.0f, 1.0f); 
+                backButton.TextColor = Color.White;
+                
+                // Add click handler
+                backButton.Clicked += OnBackButtonClicked;
+                
+                // Add button to the AppBar
+                AppBar.NavigationContent = backButton;
+            }
+        }
+
         /// <summary>
         /// Initializes the UI components for the page.
         /// </summary>
@@ -131,10 +168,10 @@ private void OnDeviceDiscovered(object sender, AdapterLeScanResultChangedEventAr
                         }
                         catch (Exception ex)
                         {
-                            Tizen.Log.Warn("LescannerDeviceListPage", $"Error calling GetDeviceName(0) for {e.DeviceData.RemoteAddress}: {ex.Message}. Will use address.");
+                            Tizen.Log.Warn(Constants.LOG_TAG, $"Error calling GetDeviceName(0) for {e.DeviceData.RemoteAddress}: {ex.Message}. Will use address.");
                         }
                         AddDeviceToList(e.DeviceData.RemoteAddress, initialName); 
-                        Tizen.Log.Info("LescannerDeviceListPage", $"Device discovered: {e.DeviceData.RemoteAddress}. Initial name from scan: {initialName ?? "N/A"}");
+                        Tizen.Log.Info(Constants.LOG_TAG, $"Device discovered: {e.DeviceData.RemoteAddress}. Initial name from scan: {initialName ?? "N/A"}");
                     }
                 }, null);
             }
@@ -181,7 +218,7 @@ private void OnDeviceNameRetrieved(object sender, DeviceNameEventArgs e)
                             if (!string.IsNullOrEmpty(e.DeviceName))
                             {
                                 deviceLabel.Text = $"{e.DeviceName} ({e.DeviceAddress})";
-                                Tizen.Log.Info("LescannerDeviceListPage", $"Updated UI for {e.DeviceAddress} with name: {e.DeviceName}");
+                                Tizen.Log.Info(Constants.LOG_TAG, $"Updated UI for {e.DeviceAddress} with name: {e.DeviceName}");
 
                                 // Safely update status label to show device name was updated
                                 try
@@ -190,46 +227,46 @@ private void OnDeviceNameRetrieved(object sender, DeviceNameEventArgs e)
                                 }
                                 catch (Exception statusEx)
                                 {
-                                    Tizen.Log.Warn("LescannerDeviceListPage", $"Could not update status label: {statusEx.Message}");
+                                    Tizen.Log.Warn(Constants.LOG_TAG, $"Could not update status label: {statusEx.Message}");
                                 }
                             }
                             else
                             {
                                 // Name might be null if not found or failed to read, keep address only.
-                                Tizen.Log.Info("LescannerDeviceListPage", $"Failed to retrieve name for {e.DeviceAddress}. UI remains as address.");
+                                Tizen.Log.Info(Constants.LOG_TAG, $"Failed to retrieve name for {e.DeviceAddress}. UI remains as address.");
                             }
 
                             // Navigate to UUID page only when we have a valid device name (not null)
                             if (!string.IsNullOrEmpty(e.DeviceName) && !_navigatedDevices.Contains(e.DeviceAddress))
                             {
                                 _navigatedDevices.Add(e.DeviceAddress);
                                 string displayName = deviceLabel.Text;
-                                Tizen.Log.Info("LescannerDeviceListPage", $"Device name '{e.DeviceName}' retrieved for {e.DeviceAddress}. Navigating to UUID page with display name: {displayName}");
+                                Tizen.Log.Info(Constants.LOG_TAG, $"Device name '{e.DeviceName}' retrieved for {e.DeviceAddress}. Navigating to UUID page with display name: {displayName}");
                                 _navigator.Push(new UuidListPage(_bleService, _navigator, e.DeviceAddress, displayName));
                             }
                             else if (string.IsNullOrEmpty(e.DeviceName))
                             {
-                                Tizen.Log.Info("LescannerDeviceListPage", $"Device name is null or empty for {e.DeviceAddress}. Waiting for name retrieval before navigation.");
+                                Tizen.Log.Info(Constants.LOG_TAG, $"Device name is null or empty for {e.DeviceAddress}. Waiting for name retrieval before navigation.");
                             }
                             else
                             {
-                                Tizen.Log.Info("LescannerDeviceListPage", $"Already navigated for {e.DeviceAddress}. Skipping duplicate navigation.");
+                                Tizen.Log.Info(Constants.LOG_TAG, $"Already navigated for {e.DeviceAddress}. Skipping duplicate navigation.");
                             }
                         }
                         else
                         {
-                            Tizen.Log.Warn("LescannerDeviceListPage", $"Received name for {e.DeviceAddress} but it's not in the discovered list (maybe navigated away?).");
+                            Tizen.Log.Warn(Constants.LOG_TAG, $"Received name for {e.DeviceAddress} but it's not in the discovered list (maybe navigated away?).");
                         }
                     }
                     catch (Exception ex)
                     {
-                        Tizen.Log.Error("LescannerDeviceListPage", $"Exception in OnDeviceNameRetrieved UI thread for {e.DeviceAddress}: {ex.Message}");
+                        Tizen.Log.Error(Constants.LOG_TAG, $"Exception in OnDeviceNameRetrieved UI thread for {e.DeviceAddress}: {ex.Message}");
                     }
                 }, null);
             }
             catch (Exception ex)
             {
-                Tizen.Log.Error("LescannerDeviceListPage", $"Exception in OnDeviceNameRetrieved for {e.DeviceAddress}: {ex.Message}");
+                Tizen.Log.Error(Constants.LOG_TAG, $"Exception in OnDeviceNameRetrieved for {e.DeviceAddress}: {ex.Message}");
             }
         }
 
@@ -241,7 +278,7 @@ private async void OnDeviceTapped(string deviceAddress)
         {
             try
             {
-                Tizen.Log.Info("LescannerDeviceListPage", $"Device tapped: {deviceAddress}. Initiating GATT connection.");
+                Tizen.Log.Info(Constants.LOG_TAG, $"Device tapped: {deviceAddress}. Initiating GATT connection.");
                 _statusLabel.Text = $"Connecting to {deviceAddress}...";
 
                 // Stop scanning before attempting connection
@@ -258,13 +295,13 @@ private async void OnDeviceTapped(string deviceAddress)
 
                 if (!connectionResult)
                 {
-                    Tizen.Log.Error("LescannerDeviceListPage", $"Failed to initiate connection to {deviceAddress}");
+                    Tizen.Log.Error(Constants.LOG_TAG, $"Failed to initiate connection to {deviceAddress}");
                     _statusLabel.Text = $"Failed to connect, retrying...";
                 }
             }
             catch (Exception ex)
             {
-                Tizen.Log.Error("LescannerDeviceListPage", $"Exception in OnDeviceTapped for {deviceAddress}: {ex.Message}");
+                Tizen.Log.Error(Constants.LOG_TAG, $"Exception in OnDeviceTapped for {deviceAddress}: {ex.Message}");
                 _statusLabel.Text = $"Connection error: {ex.Message}";
             }
         }
@@ -292,14 +329,36 @@ private void OnGattConnectionStateChanged(object sender, GattConnectionStateChan
                     }
                     catch (Exception ex)
                     {
-                        Tizen.Log.Error("LescannerDeviceListPage", $"Exception in OnGattConnectionStateChanged UI thread: {ex.Message}");
+                        Tizen.Log.Error(Constants.LOG_TAG, $"Exception in OnGattConnectionStateChanged UI thread: {ex.Message}");
                     }
                 }, null);
             }
             catch (Exception ex)
             {
-                Tizen.Log.Error("LescannerDeviceListPage", $"Exception in OnGattConnectionStateChanged: {ex.Message}");
+                Tizen.Log.Error(Constants.LOG_TAG, $"Exception in OnGattConnectionStateChanged: {ex.Message}");
             }
         }
+
+        /// <summary>
+        /// Event handler for the custom back button click.
+        /// Stops the scanning process and navigates back to the previous page.
+        /// </summary>
+        /// <param name="sender">The event source.</param>
+        /// <param name="e">The event arguments.</param>
+        private async void OnBackButtonClicked(object sender, ClickedEventArgs e)
+        {
+            Tizen.Log.Info("LescannerDeviceListPage", "Back button clicked. Stopping scan and navigating back.");
+            
+            // Stop the scanning process immediately
+            if (_isScanActive)
+            {
+                _statusLabel.Text = "Stopping scan...";
+                await StopScanningProcessAsync();
+            }
+
+            // Navigate back to the previous page
+            _navigator.Pop();
+        }
+
     }
 }

Mobile/LeScanner/Lescanner/HomePage.cs

@@ -56,7 +56,7 @@ private void InitializeComponent()
         /// <param name="e">The event arguments.</param>
         private void OnScanButtonClicked(object sender, ClickedEventArgs e)
         {
-            Tizen.Log.Info("LescannerHomePage", "BLE Scan button clicked.");
+            Tizen.Log.Info(Constants.LOG_TAG, "BLE Scan button clicked.");
             if (_bleService.IsBluetoothEnabled())
             {
                 _statusLabel.Text = "Tap 'BLE Scan' to start.";
@@ -67,7 +67,7 @@ private void OnScanButtonClicked(object sender, ClickedEventArgs e)
             {
                 _statusLabel.Text = "Please turn on Bluetooth.";
                 // Optionally, show a more persistent message or a Toast.
-                Tizen.Log.Warn("LescannerHomePage", "Bluetooth is not enabled.");
+                Tizen.Log.Warn(Constants.LOG_TAG, "Bluetooth is not enabled.");
             }
         }
     }