pm: Add NULL validation and code cleanup

- pm_dvfs: Add NULL check for dvfs_ops before dereferencing
- pm_idle: Add NULL check for sleep_ops before dereferencing
- pm_idle: Fix meaningless comparison (wakeup_src < PM_WAKEUP_UNKNOWN)
- pm_metrics: Replace pm_alloc/free with kmm_calloc/kmm_free
- pm.h: Remove pm_alloc macro (replaced with direct kmm_callo
- Remove pm_check_domain function, use direct NULL checks instead

Signed-off-by: Eunwoo Nam <eunwoo.nam@samsung.com>

Author: ewoodev

os/pm/pm.h

@@ -67,16 +67,6 @@
 
 #ifdef CONFIG_PM
 
-/****************************************************************************
- * Pre-processor Definitions
- ****************************************************************************/
-
-#ifdef CONFIG_MM_KERNEL_HEAP
-#define pm_alloc(num, size) kmm_calloc(num, size)
-#else
-#define pm_alloc(num, size) calloc(num, size)
-#endif
-
 /* Function-like macros *****************************************************/
 /****************************************************************************
  * Name: pm_lock
@@ -171,23 +161,6 @@ EXTERN struct pm_global_s g_pmglobals;
 /************************************************************************************
  * Public Function Prototypes
  ************************************************************************************/
-/****************************************************************************
- * Name: pm_check_domain
- *
- * Description:
- *   This function is called inside PM internal APIs to check whether the
- *   domain pointer is valid.
- * 
- * Input Parameters:
- *   domain - Pointer to the domain structure
- *
- * Returned Value:
- *   0 (OK) - If domain is valid
- *  -1 (ERROR) - If domain is not valid
- *
- ****************************************************************************/
-int pm_check_domain(FAR struct pm_domain_s *domain);
-
 /****************************************************************************
  * Name: pm_checkstate
  *

os/pm/pm_domain_register.c

@@ -73,34 +73,6 @@ FAR struct pm_domain_s *pm_domain_find(FAR const char *domain_name)
 	return NULL;
 }
 
-/****************************************************************************
- * Name: pm_check_domain
- *
- * Description:
- *   This function is called inside PM internal APIs to check whether the
- *   domain pointer is valid.
- * 
- * Input Parameters:
- *   domain - Pointer to the domain structure
- *
- * Returned Value:
- *   0 (OK) - If domain is valid
- *  -1 (ERROR) - If domain is not valid
- *
- ****************************************************************************/
-int pm_check_domain(FAR struct pm_domain_s *domain)
-{
-	if (domain == NULL) {
-		set_errno(EINVAL);
-		pmdbg("Invalid Domain Pointer: NULL\n");
-		return ERROR;
-	}
-	/* Additional checks can be added here if necessary, e.g., if the domain
-	 * is still in the list. For now, a non-NULL pointer is considered valid.
-	 */
-	return OK;
-}
-
 /****************************************************************************
  * Name: pm_domain_register
  *

os/pm/pm_dvfs.c

@@ -103,7 +103,9 @@ void pm_dvfs(int div_lvl)
 	 * 3 -> 300Mhz
 	 */
 	/* Placed in os/arch/arm/src/amebasmart/amebasmart_pmc.c, can be invoked directly */
-	g_pmglobals.dvfs_ops->adjust_dvfs(div_lvl);
+	if (g_pmglobals.dvfs_ops && g_pmglobals.dvfs_ops->adjust_dvfs) {
+		g_pmglobals.dvfs_ops->adjust_dvfs(div_lvl);
+	}
 	return;
 }
 

os/pm/pm_idle.c

@@ -233,8 +233,8 @@ static void enable_and_compensate_systick(void)
 	struct pm_sleep_ops *sleep_ops = g_pmglobals.sleep_ops;
 	clock_t missing_tick;
 
-	if (!sleep_ops->get_missingtick) {
-		return;
+	if (!sleep_ops || !sleep_ops->get_missingtick) {
+		goto enable_timer;
 	}
 
 	missing_tick = sleep_ops->get_missingtick();
@@ -257,8 +257,9 @@ static void enable_and_compensate_systick(void)
 		 */
 		wd_timer_nohz(missing_tick);
 	}
-#endif
 
+enable_timer:
+#endif
 	(void)up_timer_enable();
 }
 
@@ -317,7 +318,7 @@ static int set_pm_wakeup_timer(int delay)
 	return OK;
 }
 #else
-#define get_next_wakeup_time()       (ERROR)
+#define get_next_wakeup_time()       (0)
 #define set_pm_wakeup_timer(delay)  (OK)
 #endif
 
@@ -340,9 +341,9 @@ static void update_wakeup_reason(void)
 	pm_wakeup_reason_code_t wakeup_src;
 	struct pm_sleep_ops *sleep_ops = g_pmglobals.sleep_ops;
 
-	if (sleep_ops->get_wakeupreason) {
+	if (sleep_ops && sleep_ops->get_wakeupreason) {
 		wakeup_src = sleep_ops->get_wakeupreason();
-		if (wakeup_src < PM_WAKEUP_UNKNOWN || wakeup_src >= PM_WAKEUP_SRC_COUNT) {
+		if (wakeup_src >= PM_WAKEUP_SRC_COUNT) {
 			wakeup_src = PM_WAKEUP_UNKNOWN;
 		}
 

os/pm/pm_metrics.c

@@ -18,6 +18,7 @@
 
 #include <tinyara/config.h>
 #include <tinyara/pm/pm.h>
+#include <tinyara/kmalloc.h>
 #include <time.h>
 #include <queue.h>
 #include <debug.h>
@@ -298,7 +299,7 @@ int pm_metrics(int milliseconds)
 	pm_lock();
 
 	/* Allocate memory for initializing PM Metrics measurements */
-	g_pm_metrics = (pm_metric_t *)pm_alloc(1, sizeof(pm_metric_t));
+	g_pm_metrics = (pm_metric_t *)kmm_calloc(1, sizeof(pm_metric_t));
 	if (g_pm_metrics == NULL) {
 		set_errno(ENOMEM);
 		pmdbg("Unable to initialize pm_metrics, error = %d\n", get_errno());
@@ -344,7 +345,7 @@ int pm_metrics(int milliseconds)
 	/* Show PM Metrics Results */
 	pm_print_metrics((double)(end_time - start_time), n_domains);
 	/* Free allocated memory */
-	free(g_pm_metrics); /* Use pm_free for consistency */
+	kmm_free(g_pm_metrics);
 	g_pm_metrics = NULL;
 
 	/* Unlock PM Metrics for other threads */

os/pm/pm_resume.c

@@ -105,11 +105,6 @@ int pm_resume(FAR struct pm_domain_s *domain)
 
 	flags = enter_critical_section();
 
-	ret = pm_check_domain(domain);
-	if (ret != OK) {
-		goto errout;
-	}
-
 	if (domain->suspend_count <= 0) {
 		ret = ERROR;
 		set_errno(ERANGE);

os/pm/pm_suspend.c

@@ -102,17 +102,13 @@ int pm_suspend(FAR struct pm_domain_s *domain)
 	irqstate_t flags;
 	int ret = OK;
 
-	flags = enter_critical_section();
-
-	/* pm_check_domain is implicitly handled by checking for NULL domain pointer
-	 * and ensuring the domain structure is valid.
-	 * If more checks are needed, pm_check_domain(domain) can be called here.
-	 */
-	ret = pm_check_domain(domain);
-	if (ret != OK) {
-		goto errout;
+	if (domain == NULL) {
+		set_errno(EINVAL);
+		return ERROR;
 	}
 
+	flags = enter_critical_section();
+
 	if (domain->suspend_count >= UINT16_MAX) {
 		ret = ERROR;
 		set_errno(ERANGE);

os/pm/pm_suspendcount.c

@@ -89,8 +89,8 @@
 
 int pm_suspendcount(FAR struct pm_domain_s *domain)
 {
-	/* Check if domain pointer is valid */
-	if (pm_check_domain(domain) != OK) {
+	if (domain == NULL) {
+		set_errno(EINVAL);
 		return ERROR;
 	}
 	return domain->suspend_count;

os/pm/pm_timedsuspend.c

@@ -126,7 +126,7 @@ int pm_timedsuspend(struct pm_domain_s *domain, unsigned int milliseconds)
 	int ret = ERROR;
 	int delay = MSEC2TICK(milliseconds);
 
-	if (pm_check_domain(domain)) {
+	if (domain == NULL) {
 		set_errno(EINVAL);
 		return ret;
 	}