fix ignored error and typo

SamuelTissot · SamuelTissot · commit 8ab2f22ba1ac · 2026-01-19T12:27:14.000-05:00
diff --git a/manager/gcp/client.go b/manager/gcp/client.go
@@ -89,7 +89,7 @@ func fetchSecret(ctx context.Context, accessor SecretVersionAccessor, key string
 	}
 	resp, err := accessor.AccessSecretVersion(ctx, req)
 	if err != nil {
-		return "", fmt.Errorf("failed to access secrest: %s, %w", key, err)
+		return "", fmt.Errorf("failed to access secrets: %s, %w", key, err)
 	}
 
 	return string(resp.GetPayload().GetData()), nil
@@ -132,6 +132,9 @@ func fetchFilteredSecrets(
 		key := secretLatestVersionPath(s.GetName())
 
 		secret, err := fetchSecret(ctx, c, key)
+		if err != nil {
+			return nil, err
+		}
 
 		cachedSecrets[key] = secret
 	}

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ func fetchSecret(ctx context.Context, accessor SecretVersionAccessor, key string`
`89`	`89`	`}`
`90`	`90`	`resp, err := accessor.AccessSecretVersion(ctx, req)`
`91`	`91`	`if err != nil {`
`92`		`- return "", fmt.Errorf("failed to access secrest: %s, %w", key, err)`
	`92`	`+ return "", fmt.Errorf("failed to access secrets: %s, %w", key, err)`
`93`	`93`	`}`
`94`	`94`
`95`	`95`	`return string(resp.GetPayload().GetData()), nil`
`@@ -132,6 +132,9 @@ func fetchFilteredSecrets(`
`132`	`132`	`key := secretLatestVersionPath(s.GetName())`
`133`	`133`
`134`	`134`	`secret, err := fetchSecret(ctx, c, key)`
	`135`	`+ if err != nil {`
	`136`	`+ return nil, err`
	`137`	`+ }`
`135`	`138`
`136`	`139`	`cachedSecrets[key] = secret`
`137`	`140`	`}`