Netty & OkHttp : Added Allow header on 405

405 response: include Allow: POST
http: added Allow header for 405

Author: Sangamesh1997

netty/src/main/java/io/grpc/netty/NettyServerHandler.java

@@ -882,12 +882,8 @@ private void respondWithHttpError(
   }
 
   private void respondWithHttpError(
-      ChannelHandlerContext ctx,
-      int streamId,
-      int code,
-      Status.Code statusCode,
-      String msg,
-      Http2Headers allowHeaders) {
+          ChannelHandlerContext ctx, int streamId, int code, Status.Code statusCode, String msg,
+          Http2Headers allowHeaders) {
     Metadata metadata = new Metadata();
     metadata.put(InternalStatus.CODE_KEY, statusCode.toStatus());
     metadata.put(InternalStatus.MESSAGE_KEY, msg);

netty/src/test/java/io/grpc/netty/NettyServerHandlerTest.java

@@ -539,13 +539,12 @@ public void headersWithInvalidMethodShouldFail() throws Exception {
         .path(new AsciiString("/foo/bar"));
     ByteBuf headersFrame = headersFrame(STREAM_ID, headers);
     channelRead(headersFrame);
-    Http2Headers responseHeaders =
-        new DefaultHttp2Headers()
-            .set(InternalStatus.CODE_KEY.name(), String.valueOf(Code.INTERNAL.value()))
-            .set(InternalStatus.MESSAGE_KEY.name(), "Method 'FAKE' is not supported")
-            .status("" + 405)
-            .set(HttpHeaderNames.ALLOW, "POST")
-            .set(CONTENT_TYPE_HEADER, "text/plain; charset=utf-8");
+    Http2Headers responseHeaders = new DefaultHttp2Headers()
+        .set(InternalStatus.CODE_KEY.name(), String.valueOf(Code.INTERNAL.value()))
+        .set(InternalStatus.MESSAGE_KEY.name(), "Method 'FAKE' is not supported")
+        .status("" + 405)
+        .set(HttpHeaderNames.ALLOW, "POST")
+        .set(CONTENT_TYPE_HEADER, "text/plain; charset=utf-8");
 
     verifyWrite()
         .writeHeaders(

okhttp/src/test/java/io/grpc/okhttp/OkHttpServerTransportTest.java

@@ -976,13 +976,12 @@ public void httpErrorsAdhereToFlowControl() throws Exception {
     clientFrameWriter.flush();
 
     String errorDescription = "HTTP Method is not supported: GET";
-    List<Header> responseHeaders =
-        Arrays.asList(
-            new Header(":status", "405"),
-            new Header("content-type", "text/plain; charset=utf-8"),
-            new Header("grpc-status", "" + Status.Code.INTERNAL.value()),
-            new Header("grpc-message", errorDescription),
-            new Header("allow", "POST"));
+    List<Header> responseHeaders = Arrays.asList(
+        new Header(":status", "405"),
+        new Header("content-type", "text/plain; charset=utf-8"),
+        new Header("grpc-status", "" + Status.Code.INTERNAL.value()),
+        new Header("grpc-message", errorDescription),
+        new Header("allow", "POST"));
     assertThat(clientFrameReader.nextFrame(clientFramesRead)).isTrue();
     verify(clientFramesRead)
         .headers(false, false, 1, -1, responseHeaders, HeadersMode.HTTP_20_HEADERS);
@@ -1411,10 +1410,10 @@ private void verifyHttpError(
       int streamId, int httpCode, Status.Code grpcCode, String errorDescription,
       List<Header> extraHeaders) throws Exception {
     List<Header> responseHeaders = Lists.newArrayList(
-          new Header(":status", "" + httpCode),
-          new Header("content-type", "text/plain; charset=utf-8"),
-          new Header("grpc-status", "" + grpcCode.value()),
-          new Header("grpc-message", errorDescription));
+        new Header(":status", "" + httpCode),
+        new Header("content-type", "text/plain; charset=utf-8"),
+        new Header("grpc-status", "" + grpcCode.value()),
+        new Header("grpc-message", errorDescription));
     responseHeaders.addAll(extraHeaders);
     assertThat(clientFrameReader.nextFrame(clientFramesRead)).isTrue();
     verify(clientFramesRead)