feat #OBS-I640 : limits on filter

Author: JeraldJF

api-service/src/configs/Config.ts

@@ -144,5 +144,8 @@ export const config = {
   },
   "alerts_rules": {
     "config_path": process.env.alerts_config_path
-  }
+  },
+  "dataset_filter_config": {
+    "filter_limit": process.env.filter_limit ? parseInt(process.env.filter_limit) : 10 // Maximum number of filters allowed in a dataset
+  } 
 }

api-service/src/controllers/DatasetList/DatasetList.ts

@@ -7,14 +7,14 @@ import DatasetCreate from "./DatasetListValidationSchema.json";
 import { ResponseHandler } from "../../helpers/ResponseHandler";
 import { attachDraftConnectors, attachLiveConnectors, datasetService } from "../../services/DatasetService";
 import { obsrvError } from "../../types/ObsrvError";
-import { Dataset } from "../../models/Dataset";
-import { Datasource } from "../../models/Datasource";
+import { config } from "../../configs/Config";
 
 export const apiId = "api.datasets.list"
 export const errorCode = "DATASET_LIST_FAILURE"
 const liveDatasetStatus = ["Live", "Retired", "Purged"]
 const draftDatasetStatus = ["Draft", "ReadyToPublish"]
 const defaultFields = ["dataset_id", "name", "type", "status", "tags", "version", "api_version", "dataset_config", "created_date", "updated_date"]
+const MAX_STATUS_ARRAY_SIZE = config.dataset_filter_config.filter_limit || 10;
 
 const datasetList = async (req: Request, res: Response) => {
 
@@ -37,6 +37,9 @@ const listDatasets = async (request: Record<string, any>): Promise<Record<string
     const datasetStatus = _.get(filters, "status");
     const connectorFilter = _.get(filters, "connectors");
     const status = _.isArray(datasetStatus) ? datasetStatus : _.compact([datasetStatus])
+    if (status.length > MAX_STATUS_ARRAY_SIZE) {
+        throw obsrvError("", "DATASET_LIST_INPUT_INVALID", "Status filter array length exceeds the allowed limit", "BAD_REQUEST", 400);
+    }
     const draftFilters = _.omit(_.set(_.cloneDeep(filters), "status", _.isEmpty(status) ? draftDatasetStatus : _.intersection(status, draftDatasetStatus)), "connectors");
     const liveFilters = _.omit(_.set(_.cloneDeep(filters), "status", _.isEmpty(status) ? liveDatasetStatus : _.intersection(status, liveDatasetStatus)), "connectors");
     let liveDatasetList = await datasetService.getLiveDatasets(liveFilters, defaultFields)