Prevent getDeclaredField calls by iterating over all fields

This saves on throwing exceptions everytime a field was not found, for the cost of copying the fields arrays on each invocation. This is still magnitudes faster though.

Author: Postremus

hibernate-core/src/main/java/org/hibernate/internal/util/ReflectHelper.java

@@ -423,16 +423,14 @@ private static Field locateField(Class clazz, String propertyName) {
 			return null;
 		}
 
-		try {
-			Field field = clazz.getDeclaredField( propertyName );
-			if ( !isStaticField( field ) ) {
-				return field;
-			}
+		Field field = findField(propertyName, clazz.getDeclaredFields());
+		if (field == null) {
 			return locateField( clazz.getSuperclass(), propertyName );
 		}
-		catch ( NoSuchFieldException nsfe ) {
-			return locateField( clazz.getSuperclass(), propertyName );
+		if ( !isStaticField( field ) ) {
+			return field;
 		}
+		return locateField( clazz.getSuperclass(), propertyName );
 	}
 
 	public static boolean isStaticField(Field field) {
@@ -546,6 +544,15 @@ private static Method findMethod(String name, Method[] methods) {
 		return null;
 	}
 
+	private static Field findField(String name, Field[] methods) {
+		for (Field field : methods) {
+			if (field.getName().equals(name)) {
+				return field;
+			}
+		}
+		return null;
+	}
+
 	private static void verifyNoIsVariantExists(
 			Class containerClass,
 			String propertyName,