fixes #5 : getIconName called only if no icon is specified + add class IconUtils (logic separation)

Author: mickaelgudin

main/default/classes/IconUtils.cls

@@ -0,0 +1,30 @@
+public class IconUtils {
+    
+    public static String getIconName(String sObjectName){
+        String u;
+        List<Schema.DescribeTabSetResult> tabSetDesc = Schema.describeTabs();
+        List<Schema.DescribeTabResult> tabDesc = new List<Schema.DescribeTabResult>();
+        List<Schema.DescribeIconResult> iconDesc = new List<Schema.DescribeIconResult>();
+
+        for(Schema.DescribeTabSetResult tsr : tabSetDesc) { tabDesc.addAll(tsr.getTabs()); }
+
+        for(Schema.DescribeTabResult tr : tabDesc) {
+            if( sObjectName == tr.getSobjectName() ) {
+                if( tr.isCustom() == true ) {
+                    iconDesc.addAll(tr.getIcons());
+                } else {
+                    u = 'standard:' + sObjectName.toLowerCase();
+                }
+            }
+        }
+        for (Schema.DescribeIconResult ir : iconDesc) {
+            if (ir.getContentType() == 'image/svg+xml'){
+                u = 'custom:' + ir.getUrl().substringBetween('custom/','.svg').substringBefore('_');
+                break;
+            }
+        }
+        
+        return u;
+    }
+
+}

main/default/classes/IconUtils.cls-meta.xml

@@ -0,0 +1,5 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<ApexClass xmlns="http://soap.sforce.com/2006/04/metadata">
+    <apiVersion>48.0</apiVersion>
+    <status>Active</status>
+</ApexClass>

main/default/classes/RelatedList.cls

@@ -14,8 +14,13 @@ public with sharing class RelatedList {
 
 
   @AuraEnabled
-  public static ListResults getRecords(String soql, String SObjectName) {
-    return new ListResults(Database.query(soql), getIconName(SObjectName));
+  public static ListResults getRecords(String soql, String SObjectName, String iconName) {
+      //autoretrieve of the icon name based on sobject name if no icon is specified
+      if(String.isBlank(iconName) ) {
+          iconName = IconUtils.getIconName(SObjectName);
+      }  
+      
+      return new ListResults(Database.query(soql), iconName);
   }
 
   @AuraEnabled(cacheable=true)
@@ -30,30 +35,4 @@ public with sharing class RelatedList {
     return 0;
   }
 
-  public static String getIconName(String sObjectName){
-        String u;
-        List<Schema.DescribeTabSetResult> tabSetDesc = Schema.describeTabs();
-        List<Schema.DescribeTabResult> tabDesc = new List<Schema.DescribeTabResult>();
-        List<Schema.DescribeIconResult> iconDesc = new List<Schema.DescribeIconResult>();
-
-        for(Schema.DescribeTabSetResult tsr : tabSetDesc) { tabDesc.addAll(tsr.getTabs()); }
-
-        for(Schema.DescribeTabResult tr : tabDesc) {
-            if( sObjectName == tr.getSobjectName() ) {
-                if( tr.isCustom() == true ) {
-                    iconDesc.addAll(tr.getIcons());
-                } else {
-                    u = 'standard:' + sObjectName.toLowerCase();
-                }
-            }
-        }
-        for (Schema.DescribeIconResult ir : iconDesc) {
-            if (ir.getContentType() == 'image/svg+xml'){
-                u = 'custom:' + ir.getUrl().substringBetween('custom/','.svg').substringBefore('_');
-                break;
-            }
-        }
-        
-        return u;
-    }
 }

main/default/classes/RelatedList_Test.cls

@@ -6,7 +6,7 @@ public with sharing class RelatedList_Test {
         User testUser = [Select id from user where id = :UserInfo.getUserId()];
         RelatedList.ListResults results = null;
         System.runAs(testUser){
-            results = RelatedList.getRecords('Select id from contact limit 10', 'Contact');
+            results = RelatedList.getRecords('Select id from contact limit 10', 'Contact', '');
         }
 
         //checking if the SObject icon name is well retrieved

main/default/lwc/lwcRelatedList/lwcRelatedList.js

@@ -53,7 +53,7 @@ export default class LightningDatatable extends NavigationMixin(
   }
 
   fetchRecords() {
-    getRecords({ soql: this.soql, SObjectName: this.objectName })
+    getRecords({ soql: this.soql, SObjectName: this.objectName, iconName: this.iconName })
       .then((data) => {
         if (data) {
           if( !this.iconName)  {