Fixes + Ansible REX

Author: lhellebr

tests/foreman/destructive/test_remoteexecution.py

@@ -206,6 +206,11 @@ def ca_contenthost(rhel_contenthost):
     return (rhel_contenthost, f'{ca_path}.pub')
 
 
+@pytest.fixture
+def host_ca_file_on_satellite(ca_contenthost):
+    return f'/var/lib/foreman-proxy/ssh/{ca_contenthost[1].split("/")[-1]}'
+
+
 def register_host(satellite, host):
     org = satellite.cli.Org.create({'name': gen_string('alpha')})
     # repo = settings.repos['SATCLIENT_REPO'][f'RHEL{host.os_version.major}']
@@ -252,6 +257,12 @@ def log_compare(satellite, host):
     ).status
 
 
+def copy_host_CA(host, satellite, host_path, satellite_path):
+    host_ca_file_local = f'/tmp/{gen_string("alpha")}'
+    host.get(host_path, host_ca_file_local)
+    satellite.put(host_ca_file_local, satellite_path)
+
+
 @pytest.mark.no_containers
 @pytest.mark.rhel_ver_match([settings.content_host.default_rhel_version])
 def test_positive_ssh_ca_sat_only(ca_sat, rhel_contenthost):
@@ -260,55 +271,78 @@ def test_positive_ssh_ca_sat_only(ca_sat, rhel_contenthost):
     sat_ca_file = ca_sat[1]
     log_save(sat, host)
     command = InstallerCommand(
-        foreman_proxy_plugin_remote_execution_script_ssh_user_ca_public_key_file=sat_ca_file,
+        foreman_proxy_plugin_remote_execution_script_ssh_user_ca_public_keys_file=sat_ca_file,
     )
     assert sat.install(command).status == 0
     register_host(sat, host)
     result = test_execution(sat, host)
     # assert the run actually happened and it was authenticated using cert
-    result = sat.execute('grep rex_passed /root/test')
     assert result.status == 0
     logger.debug(result)
     assert log_compare(sat, host) == 0
+    check = host.execute('grep rex_passed /root/test')
+    assert check.status == 0
 
 
 @pytest.mark.no_containers
 @pytest.mark.rhel_ver_match([settings.content_host.default_rhel_version])
-def test_positive_ssh_ca_host_only(target_sat, ca_contenthost):
+def test_positive_ssh_ca_host_only(target_sat, ca_contenthost, host_ca_file_on_satellite):
     sat = target_sat
     host = ca_contenthost[0]
     host_ca_file = ca_contenthost[1]
-    host_ca_cert = host.execute(f'cat {host_ca_file}').stdout.strip()
+    copy_host_CA(host, sat, host_ca_file, host_ca_file_on_satellite)
+    log_save(sat, host)
     command = InstallerCommand(
-        foreman_proxy_plugin_remote_execution_script_ssh_host_ca_public_key=f'"{host_ca_cert}"',
+        foreman_proxy_plugin_remote_execution_script_ssh_host_ca_public_keys_file=host_ca_file_on_satellite,
     )
     assert sat.install(command).status == 0
     register_host(sat, host)
     result = test_execution(sat, host)
     # assert the run actually happened and it was NOT authenticated using cert
-    result = sat.execute('grep rex_passed /root/test')
-    assert result.status == 0
+    assert result['success'] == '1'
     logger.debug(result)
     assert log_compare(sat, host) != 0
+    check = host.execute('grep rex_passed /root/test')
+    assert check.status == 0
 
 
 @pytest.mark.no_containers
 @pytest.mark.rhel_ver_match([settings.content_host.default_rhel_version])
-def test_positive_ssh_ca_sat_and_host(ca_sat, ca_contenthost):
+def test_positive_ssh_ca_sat_and_host(ca_sat, ca_contenthost, host_ca_file_on_satellite):
     sat = ca_sat[0]
     sat_ca_file = ca_sat[1]
     host = ca_contenthost[0]
     host_ca_file = ca_contenthost[1]
-    host_ca_cert = host.execute(f'cat {host_ca_file}').stdout.strip()
+    copy_host_CA(host, sat, host_ca_file, host_ca_file_on_satellite)
+    log_save(sat, host)
     command = InstallerCommand(
         foreman_proxy_plugin_remote_execution_script_ssh_user_ca_public_key_file=sat_ca_file,
-        foreman_proxy_plugin_remote_execution_script_ssh_host_ca_public_key=f'"{host_ca_cert}"',
+        foreman_proxy_plugin_remote_execution_script_ssh_host_ca_public_keys_file=host_ca_file_on_satellite,
     )
     assert sat.install(command).status == 0
     register_host(sat, host)
+    # SSH REX
     result = test_execution(sat, host)
     # assert the run actually happened and it was authenticated using cert
-    result = sat.execute('grep rex_passed /root/test')
-    assert result.status == 0
+    assert result['success'] == '1'
+    logger.debug(result)
+    assert log_compare(sat, host) == 0
+    check = host.execute('grep rex_passed /root/test')
+    assert check.status == 0
+    # ANSIBLE REX
+    log_save(sat, host)
+    command = "echo rex2_passed $(date) > /root/test"
+    invocation_command = sat.cli_factory.job_invocation(
+        {
+            'job-template': 'Run Command - Ansible Default',
+            'inputs': f'command={command}',
+            'search-query': f'name ~ {host.hostname}',
+        }
+    )
+    result = sat.cli.JobInvocation.info({'id': invocation_command['id']})
+    # assert the run actually happened and it was authenticated using cert
+    assert result['success'] == '1'
     logger.debug(result)
     assert log_compare(sat, host) == 0
+    check = host.execute('grep rex2_passed /root/test')
+    assert check.status == 0