|
20 | 20 | <PaketBootstrapperStyle Condition="Exists('$(PaketToolsPath)paket.bootstrapper.proj')">proj</PaketBootstrapperStyle> |
21 | 21 | <PaketExeImage>assembly</PaketExeImage> |
22 | 22 | <PaketExeImage Condition=" '$(PaketBootstrapperStyle)' == 'proj' ">native</PaketExeImage> |
23 | | - <MonoPath Condition="'$(MonoPath)' == '' And Exists('/Library/Frameworks/Mono.framework/Commands/mono')">/Library/Frameworks/Mono.framework/Commands/mono</MonoPath> |
| 23 | + <MonoPath Condition="'$(MonoPath)' == '' AND Exists('/Library/Frameworks/Mono.framework/Commands/mono')">/Library/Frameworks/Mono.framework/Commands/mono</MonoPath> |
24 | 24 | <MonoPath Condition="'$(MonoPath)' == ''">mono</MonoPath> |
25 | 25 |
|
26 | 26 | <!-- PaketBootStrapper --> |
27 | 27 | <PaketBootStrapperExePath Condition=" '$(PaketBootStrapperExePath)' == '' AND Exists('$(PaketRootPath)paket.bootstrapper.exe')">$(PaketRootPath)paket.bootstrapper.exe</PaketBootStrapperExePath> |
28 | 28 | <PaketBootStrapperExePath Condition=" '$(PaketBootStrapperExePath)' == '' ">$(PaketToolsPath)paket.bootstrapper.exe</PaketBootStrapperExePath> |
29 | 29 | <PaketBootStrapperExeDir Condition=" Exists('$(PaketBootStrapperExePath)') " >$([System.IO.Path]::GetDirectoryName("$(PaketBootStrapperExePath)"))\</PaketBootStrapperExeDir> |
30 | | - |
31 | | - <PaketBootStrapperCommand Condition=" '$(OS)' == 'Windows_NT'">"$(PaketBootStrapperExePath)"</PaketBootStrapperCommand> |
| 30 | + |
| 31 | + <PaketBootStrapperCommand Condition=" '$(OS)' == 'Windows_NT' ">"$(PaketBootStrapperExePath)"</PaketBootStrapperCommand> |
32 | 32 | <PaketBootStrapperCommand Condition=" '$(OS)' != 'Windows_NT' ">$(MonoPath) --runtime=v4.0.30319 "$(PaketBootStrapperExePath)"</PaketBootStrapperCommand> |
33 | 33 |
|
34 | | - <!-- Disable automagic references for F# dotnet sdk --> |
| 34 | + <!-- Disable automagic references for F# DotNet SDK --> |
35 | 35 | <!-- This will not do anything for other project types --> |
36 | 36 | <!-- see https://github.com/fsharp/fslang-design/blob/master/tooling/FST-1002-fsharp-in-dotnet-sdk.md --> |
37 | 37 | <DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference> |
|
40 | 40 | <!-- Disable Paket restore under NCrunch build --> |
41 | 41 | <PaketRestoreDisabled Condition="'$(NCrunch)' == '1'">True</PaketRestoreDisabled> |
42 | 42 |
|
| 43 | + <!-- Disable test for CLI tool completely - overrideable via properties in projects or via environment variables --> |
| 44 | + <PaketDisableCliTest Condition=" '$(PaketDisableCliTest)' == '' ">False</PaketDisableCliTest> |
| 45 | + |
43 | 46 | <PaketIntermediateOutputPath Condition=" '$(PaketIntermediateOutputPath)' == '' ">$(BaseIntermediateOutputPath.TrimEnd('\').TrimEnd('\/'))</PaketIntermediateOutputPath> |
44 | 47 | </PropertyGroup> |
45 | 48 |
|
46 | | - <!-- Check if paket is available as local dotnet cli tool --> |
| 49 | + <!-- Resolve how paket should be called --> |
| 50 | + <!-- Current priority is: local (1: repo root, 2: .paket folder) => 3: as CLI tool => as bootstrapper (4: proj Bootstrapper style, 5: BootstrapperExeDir) => 6: global path variable --> |
47 | 51 | <Target Name="SetPaketCommand" > |
48 | | - |
49 | | - <!-- Call 'dotnet paket' and see if it returns without an error. Mute all the output. --> |
50 | | - <Exec Command="dotnet paket --version" IgnoreExitCode="true" StandardOutputImportance="low" StandardErrorImportance="low" > |
51 | | - <Output TaskParameter="ExitCode" PropertyName="LocalPaketToolExitCode" /> |
52 | | - </Exec> |
| 52 | + <!-- Test if paket is available in the standard locations. If so, that takes priority. Case 1/2 - non-windows specific --> |
| 53 | + <PropertyGroup Condition=" '$(OS)' != 'Windows_NT' "> |
| 54 | + <!-- no windows, try native paket as default, root => tool --> |
| 55 | + <PaketExePath Condition=" '$(PaketExePath)' == '' AND Exists('$(PaketRootPath)paket') ">$(PaketRootPath)paket</PaketExePath> |
| 56 | + <PaketExePath Condition=" '$(PaketExePath)' == '' AND Exists('$(PaketToolsPath)paket') ">$(PaketToolsPath)paket</PaketExePath> |
| 57 | + </PropertyGroup> |
53 | 58 |
|
54 | | - <!-- If local paket tool is found, use that --> |
55 | | - <PropertyGroup Condition=" '$(LocalPaketToolExitCode)' == '0' "> |
56 | | - <InternalPaketCommand>dotnet paket</InternalPaketCommand> |
| 59 | + <!-- Test if paket is available in the standard locations. If so, that takes priority. Case 2/2 - same across platforms --> |
| 60 | + <PropertyGroup> |
| 61 | + <!-- root => tool --> |
| 62 | + <PaketExePath Condition=" '$(PaketExePath)' == '' AND Exists('$(PaketRootPath)paket.exe') ">$(PaketRootPath)paket.exe</PaketExePath> |
| 63 | + <PaketExePath Condition=" '$(PaketExePath)' == '' AND Exists('$(PaketToolsPath)paket.exe') ">$(PaketToolsPath)paket.exe</PaketExePath> |
57 | 64 | </PropertyGroup> |
58 | 65 |
|
59 | | - <!-- If not, then we go through our normal steps of setting the Paket command. --> |
60 | | - <PropertyGroup Condition=" '$(LocalPaketToolExitCode)' != '0' "> |
61 | | - <!-- windows, root => tool => proj style => bootstrapper => global --> |
62 | | - <PaketExePath Condition=" '$(PaketExePath)' == '' AND '$(OS)' == 'Windows_NT' AND Exists('$(PaketRootPath)paket.exe') ">$(PaketRootPath)paket.exe</PaketExePath> |
63 | | - <PaketExePath Condition=" '$(PaketExePath)' == '' AND '$(OS)' == 'Windows_NT' AND Exists('$(PaketToolsPath)paket.exe') ">$(PaketToolsPath)paket.exe</PaketExePath> |
64 | | - <PaketExePath Condition=" '$(PaketExePath)' == '' AND '$(OS)' == 'Windows_NT' AND '$(PaketBootstrapperStyle)' == 'proj' ">$(PaketToolsPath)paket.exe</PaketExePath> |
65 | | - <PaketExePath Condition=" '$(PaketExePath)' == '' AND '$(OS)' == 'Windows_NT' AND Exists('$(PaketBootStrapperExeDir)') ">$(_PaketBootStrapperExeDir)paket.exe</PaketExePath> |
66 | | - <PaketExePath Condition=" '$(PaketExePath)' == '' AND '$(OS)' == 'Windows_NT' ">paket.exe</PaketExePath> |
| 66 | + <!-- If paket hasn't be found in standard locations, test for CLI tool usage. --> |
| 67 | + <!-- First test: Is CLI configured to be used in "dotnet-tools.json"? - can result in a false negative; only a positive outcome is reliable. --> |
| 68 | + <PropertyGroup Condition=" '$(PaketExePath)' == '' "> |
| 69 | + <_DotnetToolsJson Condition="Exists('$(PaketRootPath)/.config/dotnet-tools.json')">$([System.IO.File]::ReadAllText("$(PaketRootPath)/.config/dotnet-tools.json"))</_DotnetToolsJson> |
| 70 | + <_ConfigContainsPaket Condition=" '$(_DotnetToolsJson)' != ''">$(_DotnetToolsJson.Contains('"paket"'))</_ConfigContainsPaket> |
| 71 | + <_ConfigContainsPaket Condition=" '$(_ConfigContainsPaket)' == ''">false</_ConfigContainsPaket> |
| 72 | + </PropertyGroup> |
67 | 73 |
|
68 | | - <!-- no windows, try native paket as default, root => tool => proj style => mono paket => bootstrpper => global --> |
69 | | - <PaketExePath Condition=" '$(PaketExePath)' == '' AND '$(OS)' != 'Windows_NT' AND Exists('$(PaketRootPath)paket') ">$(PaketRootPath)paket</PaketExePath> |
70 | | - <PaketExePath Condition=" '$(PaketExePath)' == '' AND '$(OS)' != 'Windows_NT' AND Exists('$(PaketToolsPath)paket') ">$(PaketToolsPath)paket</PaketExePath> |
71 | | - <PaketExePath Condition=" '$(PaketExePath)' == '' AND '$(OS)' != 'Windows_NT' AND '$(PaketBootstrapperStyle)' == 'proj' ">$(PaketToolsPath)paket</PaketExePath> |
| 74 | + <!-- Second test: Call 'dotnet paket' and see if it returns without an error. Mute all the output. Only run if previous test failed and the test has not been disabled. --> |
| 75 | + <!-- WARNING: This method can lead to processes hanging forever, and should be used as little as possible. See https://github.com/fsprojects/Paket/issues/3705 for details. --> |
| 76 | + <Exec Condition=" '$(PaketExePath)' == '' AND !$(PaketDisableCliTest) AND !$(_ConfigContainsPaket)" Command="dotnet paket --version" IgnoreExitCode="true" StandardOutputImportance="low" StandardErrorImportance="low" > |
| 77 | + <Output TaskParameter="ExitCode" PropertyName="LocalPaketToolExitCode" /> |
| 78 | + </Exec> |
72 | 79 |
|
73 | | - <!-- no windows, try mono paket --> |
74 | | - <PaketExePath Condition=" '$(PaketExePath)' == '' AND '$(OS)' != 'Windows_NT' AND Exists('$(PaketRootPath)paket.exe') ">$(PaketRootPath)paket.exe</PaketExePath> |
75 | | - <PaketExePath Condition=" '$(PaketExePath)' == '' AND '$(OS)' != 'Windows_NT' AND Exists('$(PaketToolsPath)paket.exe') ">$(PaketToolsPath)paket.exe</PaketExePath> |
| 80 | + <!-- If paket is installed as CLI use that. Again, only if paket haven't already been found in standard locations. --> |
| 81 | + <PropertyGroup Condition=" '$(PaketExePath)' == '' AND ($(_ConfigContainsPaket) OR '$(LocalPaketToolExitCode)' == '0') "> |
| 82 | + <_PaketCommand>dotnet paket</_PaketCommand> |
| 83 | + </PropertyGroup> |
76 | 84 |
|
77 | | - <!-- no windows, try bootstrapper --> |
78 | | - <PaketExePath Condition=" '$(PaketExePath)' == '' AND '$(OS)' != 'Windows_NT' AND Exists('$(PaketBootStrapperExeDir)') ">$(PaketBootStrapperExeDir)paket.exe</PaketExePath> |
| 85 | + <!-- If neither local files nor CLI tool can be found, final attempt is searching for boostrapper config before falling back to global path variable. --> |
| 86 | + <PropertyGroup Condition=" '$(PaketExePath)' == '' AND '$(_PaketCommand)' == '' "> |
| 87 | + <!-- Test for bootstrapper setup --> |
| 88 | + <PaketExePath Condition=" '$(PaketExePath)' == '' AND '$(PaketBootstrapperStyle)' == 'proj' ">$(PaketToolsPath)paket</PaketExePath> |
| 89 | + <PaketExePath Condition=" '$(PaketExePath)' == '' AND Exists('$(PaketBootStrapperExeDir)') ">$(PaketBootStrapperExeDir)paket</PaketExePath> |
79 | 90 |
|
80 | | - <!-- no windows, try global native paket --> |
81 | | - <PaketExePath Condition=" '$(PaketExePath)' == '' AND '$(OS)' != 'Windows_NT' ">paket</PaketExePath> |
| 91 | + <!-- If all else fails, use global path approach. --> |
| 92 | + <PaketExePath Condition=" '$(PaketExePath)' == ''">paket</PaketExePath> |
| 93 | + </PropertyGroup> |
82 | 94 |
|
| 95 | + <!-- If not using CLI, setup correct execution command. --> |
| 96 | + <PropertyGroup Condition=" '$(_PaketCommand)' == '' "> |
83 | 97 | <_PaketExeExtension>$([System.IO.Path]::GetExtension("$(PaketExePath)"))</_PaketExeExtension> |
84 | | - <InternalPaketCommand Condition=" '$(InternalPaketCommand)' == '' AND '$(_PaketExeExtension)' == '.dll' ">dotnet "$(PaketExePath)"</InternalPaketCommand> |
85 | | - <InternalPaketCommand Condition=" '$(InternalPaketCommand)' == '' AND '$(OS)' != 'Windows_NT' AND '$(_PaketExeExtension)' == '.exe' ">$(MonoPath) --runtime=v4.0.30319 "$(PaketExePath)"</InternalPaketCommand> |
86 | | - <InternalPaketCommand Condition=" '$(InternalPaketCommand)' == '' ">"$(PaketExePath)"</InternalPaketCommand> |
87 | | - |
| 98 | + <_PaketCommand Condition=" '$(_PaketCommand)' == '' AND '$(_PaketExeExtension)' == '.dll' ">dotnet "$(PaketExePath)"</_PaketCommand> |
| 99 | + <_PaketCommand Condition=" '$(_PaketCommand)' == '' AND '$(OS)' != 'Windows_NT' AND '$(_PaketExeExtension)' == '.exe' ">$(MonoPath) --runtime=v4.0.30319 "$(PaketExePath)"</_PaketCommand> |
| 100 | + <_PaketCommand Condition=" '$(_PaketCommand)' == '' ">"$(PaketExePath)"</_PaketCommand> |
88 | 101 | </PropertyGroup> |
89 | 102 |
|
90 | 103 | <!-- The way to get a property to be available outside the target is to use this task. --> |
91 | | - <CreateProperty Value="$(InternalPaketCommand)"> |
| 104 | + <CreateProperty Value="$(_PaketCommand)"> |
92 | 105 | <Output TaskParameter="Value" PropertyName="PaketCommand"/> |
93 | 106 | </CreateProperty> |
94 | 107 |
|
|
123 | 136 | <!-- Parse our simple 'paket.restore.cached' json ...--> |
124 | 137 | <PaketRestoreCachedSplitObject Include="$([System.Text.RegularExpressions.Regex]::Split(`$(PaketRestoreCachedContents)`, `{|}|,`))"></PaketRestoreCachedSplitObject> |
125 | 138 | <!-- Keep Key, Value ItemGroup--> |
126 | | - <PaketRestoreCachedKeyValue Include="@(PaketRestoreCachedSplitObject)" |
| 139 | + <PaketRestoreCachedKeyValue Include="@(PaketRestoreCachedSplitObject)" |
127 | 140 | Condition=" $([System.Text.RegularExpressions.Regex]::Split(`%(Identity)`, `": "`).Length) > 1 "> |
128 | 141 | <Key>$([System.Text.RegularExpressions.Regex]::Split(`%(Identity)`, `": "`)[0].Replace(`"`, ``).Replace(` `, ``))</Key> |
129 | 142 | <Value>$([System.Text.RegularExpressions.Regex]::Split(`%(Identity)`, `": "`)[1].Replace(`"`, ``).Replace(` `, ``))</Value> |
|
156 | 169 | <Exec Command='$(PaketBootStrapperCommand)' Condition=" '$(PaketBootstrapperStyle)' == 'classic' AND Exists('$(PaketBootStrapperExePath)') AND !(Exists('$(PaketExePath)'))" ContinueOnError="false" /> |
157 | 170 | <Error Text="Stop build because of PAKET_ERROR_ON_MSBUILD_EXEC and we need a full restore (hashes don't match)" Condition=" '$(PAKET_ERROR_ON_MSBUILD_EXEC)' == 'true' AND '$(PaketRestoreRequired)' == 'true' AND '$(PaketDisableGlobalRestore)' != 'true'" /> |
158 | 171 | <Exec Command='$(PaketCommand) restore' Condition=" '$(PaketRestoreRequired)' == 'true' AND '$(PaketDisableGlobalRestore)' != 'true' " ContinueOnError="false" /> |
159 | | - |
| 172 | + |
160 | 173 | <!-- Step 2 Detect project specific changes --> |
161 | 174 | <ItemGroup> |
162 | 175 | <MyTargetFrameworks Condition="'$(TargetFramework)' != '' " Include="$(TargetFramework)"></MyTargetFrameworks> |
|
0 commit comments