AcceptEnv definition causes failure when building with current nixpkgs master

[greg-hellings]

AcceptEnv for sshd configuration is now required to be a list, rather than a space separated string. This change occurred in [this commit)https://github.com/NixOS/nixpkgs/commit/f21864805a2a188b1a7339d37395298e92578de8) in nixpkgs.

[io12]

I might be doing something wrong, but this doesn't fix the issue for me. I changed the input from

proxmox-nixos.url = "github:SaumonNet/proxmox-nixos";

to

proxmox-nixos.url = "github:greg-hellings/proxmox-nixos/fix/212-AcceptEnv-redefinition";

and still get the same error

       error: A definition for option `services.openssh.settings.AcceptEnv' is not of type `null or (list of string)'. Definition values:
       - In `/nix/store/xzl5dhddgjxp2p18h5qpkhvlkp8128j1-source/flake.nix': "LANG LC_*"

[greg-hellings]

@io12 Are you sure the version of nixpkgs you're using is at least version 26.05. Maybe the offending change made it into 25.11 as well? The version check I have in the code is explicitly looking at pkgs.version, so if there's something mixing up your versions or if the change was brought in during 25.11 then that might explain the issue. I run on nixos-unstable branch for all of my systems.

[io12]

Yeah, the value of pkgs.version is 26.05pre-git for me and lib.versionOlder lib.version "26.05" is true.

[greg-hellings]

Interesting. What commit sha is your flake.lock pointing to for that input? Because the only seeming way to get the result you're seeing is to have the value of pkgs.lib.version come out to less than 26.05. I'm not seeing how it could go awry unless the version of nixpkgs is mixed up between your base system that's setting the option and the pkgs.lib version that's in the module code setting the config value.

Is it possible that in your evaluation you're still using the pinned version of pkgs.lib within the proxmox-nixos code, while your application is sitting at 26.05?

[io12]

I think the right way to do it is to compare to 26.05pre-git instead of just 26.05. That's what this does: https://github.com/NixOS/nixpkgs/blob/cad22e7d996aea55ecab064e84834289143e44a0/pkgs/by-name/ni/nixos-container/nixos-container.pl#L399

From what I can tell, the version string without the pre-git suffix only applies to channels once 26.05 is actually released.

[greg-hellings]

Hmm, looks like you might be correct:

nix-repl> lib.versionAtLeast "26.05pre-git" "26.05"
false

nix-repl> lib.versionAtLeast "26.05" "26.05pre-git"
true

nix-repl> lib.versionAtLeast "25.11" "26.05pre-git"
false

[greg-hellings]

@io12 New version that should honor 26.05pre-git is now pushed.