Fix PHP 5.6 libxml flags

Author: SbWereWolf

src/SbWereWolf/XmlNavigator/Conversion/FastXmlToArray.php

@@ -26,8 +26,12 @@ public static function convert(
         $name = Notation::NAME,
         $seq = Notation::SEQUENCE,
         $encoding = null,
-        $flags = LIBXML_BIGLINES | LIBXML_COMPACT
+        $flags = null
     ) {
+        if ($flags === null) {
+            $flags = self::defaultLibxmlFlags();
+        }
+
         /** @var \Closure(XMLReader):array<mixed, mixed> $parse */
         $parse = static function (
             XMLReader $reader
@@ -76,8 +80,12 @@ public static function prettyPrint(
         $val = Notation::VAL,
         $attr = Notation::ATTR,
         $encoding = null,
-        $flags = LIBXML_BIGLINES | LIBXML_COMPACT
+        $flags = null
     ) {
+        if ($flags === null) {
+            $flags = self::defaultLibxmlFlags();
+        }
+
         /** @var \Closure(XMLReader):array<mixed, mixed> $parse */
         $parse = static function (
             XMLReader $reader
@@ -248,6 +256,20 @@ private static function requireArrayResult(
         return $result;
     }
 
+    /**
+     * @return int
+     */
+    private static function defaultLibxmlFlags()
+    {
+        $flags = LIBXML_COMPACT;
+
+        if (defined('LIBXML_BIGLINES')) {
+            $flags |= LIBXML_BIGLINES;
+        }
+
+        return $flags;
+    }
+
     private static function formatLibxmlErrors()
     {
         $errors = libxml_get_errors();

src/SbWereWolf/XmlNavigator/Conversion/IFastXmlToArray.php

@@ -22,7 +22,7 @@ interface IFastXmlToArray
      * @param string $name index for element name
      * @param string $seq index for child elements collection
      * @param string|null $encoding The document encoding or NULL
-     * @param int $flags A bitmask of the LIBXML_* constants.
+     * @param int|null $flags A bitmask of the LIBXML_* constants.
      * @return HierarchyNode
      */
     public static function convert(
@@ -33,7 +33,7 @@ public static function convert(
         $name = Notation::NAME,
         $seq = Notation::SEQUENCE,
         $encoding = null,
-        $flags = LIBXML_BIGLINES | LIBXML_COMPACT
+        $flags = null
     );
 
     /** Convert xml document into compact array
@@ -42,7 +42,7 @@ public static function convert(
      * @param string $val index for element value
      * @param string $attr index for element attributes collection
      * @param string|null $encoding The document encoding or NULL
-     * @param int $flags A bitmask of the LIBXML_* constants.
+     * @param int|null $flags A bitmask of the LIBXML_* constants.
      * @return PrettyNode
      */
     public static function prettyPrint(
@@ -51,6 +51,6 @@ public static function prettyPrint(
         $val = Notation::VAL,
         $attr = Notation::ATTR,
         $encoding = null,
-        $flags = LIBXML_BIGLINES | LIBXML_COMPACT
+        $flags = null
     );
 }

src/SbWereWolf/XmlNavigator/Conversion/XmlConverter.php

@@ -41,22 +41,22 @@ class XmlConverter implements IXmlConverter
      * @param string $name index for the element name
      * @param string $seq Index for child elements
      * @param string|null $encoding XML document encoding or `null`
-     * @param int $flags
+     * @param int|null $flags
      */
     public function __construct(
         $val = Notation::VALUE,
         $attr = Notation::ATTRIBUTES,
         $name = Notation::NAME,
         $seq = Notation::SEQUENCE,
         $encoding = null,
-        $flags = LIBXML_BIGLINES | LIBXML_COMPACT
+        $flags = null
     ) {
         $this->name = $name;
         $this->val = $val;
         $this->attr = $attr;
         $this->seq = $seq;
         $this->encoding = $encoding;
-        $this->flags = $flags;
+        $this->flags = $flags === null ? self::defaultLibxmlFlags() : $flags;
     }
 
     /**
@@ -135,4 +135,18 @@ private function isPrevious(
         }
         return $isPrevious;
     }
+
+    /**
+     * @return int
+     */
+    private static function defaultLibxmlFlags()
+    {
+        $flags = LIBXML_COMPACT;
+
+        if (defined('LIBXML_BIGLINES')) {
+            $flags |= LIBXML_BIGLINES;
+        }
+
+        return $flags;
+    }
 }

tests/Unit/Conversion/FastXmlToArrayTest.php

@@ -273,7 +273,7 @@ public function testParseRootElementRejectsBufferedLibxmlErrorsAfterParse()
                 '<root/>',
                 '',
                 null,
-                LIBXML_BIGLINES | LIBXML_COMPACT,
+                self::defaultLibxmlFlags(),
                 static function (\XMLReader $reader){
                     $dom = new \DOMDocument();
                     @$dom->loadXML('<broken>');
@@ -304,4 +304,18 @@ static function (\XMLReader $reader){
             );
         }
     }
+
+    /**
+     * @return int
+     */
+    private static function defaultLibxmlFlags()
+    {
+        $flags = LIBXML_COMPACT;
+
+        if (defined('LIBXML_BIGLINES')) {
+            $flags |= LIBXML_BIGLINES;
+        }
+
+        return $flags;
+    }
 }