diff --git a/pyproject.toml b/pyproject.toml index 73af63da..da0632c4 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -46,7 +46,7 @@ dev = [ "qdrant-client", "graphlit-client", "python-dotenv", - "pinecone-client", + "pinecone", "langchain", "langchain-community", "langchain-openai", diff --git a/src/langtrace_python_sdk/instrumentation/langchain_core/patch.py b/src/langtrace_python_sdk/instrumentation/langchain_core/patch.py index 7b6e0821..69b302fc 100644 --- a/src/langtrace_python_sdk/instrumentation/langchain_core/patch.py +++ b/src/langtrace_python_sdk/instrumentation/langchain_core/patch.py @@ -248,8 +248,9 @@ def clean_empty(d): elif isinstance(val, object): # some langchain objects have a text attribute val = getattr(val, "text", None) - if val is not None and val.strip() != "": - result[k] = val.strip() + if val is not None and isinstance(val, str): + if val.strip() != "": + result[k] = val.strip() return result diff --git a/src/langtrace_python_sdk/instrumentation/pinecone/instrumentation.py b/src/langtrace_python_sdk/instrumentation/pinecone/instrumentation.py index c9266519..7608e901 100644 --- a/src/langtrace_python_sdk/instrumentation/pinecone/instrumentation.py +++ b/src/langtrace_python_sdk/instrumentation/pinecone/instrumentation.py @@ -33,12 +33,12 @@ class PineconeInstrumentation(BaseInstrumentor): The PineconeInstrumentation class represents the Pinecone instrumentation""" def instrumentation_dependencies(self) -> Collection[str]: - return ["pinecone-client >= 3.1.0"] + return ["pinecone >= 3.1.0"] def _instrument(self, **kwargs): tracer_provider = kwargs.get("tracer_provider") tracer = get_tracer(__name__, "", tracer_provider) - version = importlib.metadata.version("pinecone-client") + version = importlib.metadata.version("pinecone") for operation_name, details in APIS.items(): operation = details["OPERATION"] # Dynamically creating the patching call diff --git a/src/langtrace_python_sdk/instrumentation/pinecone/patch.py b/src/langtrace_python_sdk/instrumentation/pinecone/patch.py index 91c4f9d4..df8ce0e5 100644 --- a/src/langtrace_python_sdk/instrumentation/pinecone/patch.py +++ b/src/langtrace_python_sdk/instrumentation/pinecone/patch.py @@ -64,7 +64,7 @@ def traced_method(wrapped, instance, args, kwargs): ) as span: if span.is_recording(): - set_span_attribute(span, "server.address", instance._config.host) + set_span_attribute(span, "server.address", instance.config.host) if operation_name == "QUERY": set_query_input_attributes(span, kwargs) diff --git a/src/langtrace_python_sdk/langtrace.py b/src/langtrace_python_sdk/langtrace.py index 7830805f..4d3d7e32 100644 --- a/src/langtrace_python_sdk/langtrace.py +++ b/src/langtrace_python_sdk/langtrace.py @@ -301,7 +301,7 @@ def init( all_instrumentations = { "openai": OpenAIInstrumentation(), "groq": GroqInstrumentation(), - "pinecone-client": PineconeInstrumentation(), + "pinecone": PineconeInstrumentation(), "llama-index": LlamaindexInstrumentation(), "chromadb": ChromaInstrumentation(), "embedchain": EmbedchainInstrumentation(), diff --git a/src/langtrace_python_sdk/types/__init__.py b/src/langtrace_python_sdk/types/__init__.py index 0c6f7b87..ba875b9c 100644 --- a/src/langtrace_python_sdk/types/__init__.py +++ b/src/langtrace_python_sdk/types/__init__.py @@ -25,7 +25,7 @@ class InstrumentationType(Enum): MISTRALAI = "mistralai" OLLAMA = "ollama" OPENAI = "openai" - PINECONE = "pinecone-client" + PINECONE = "pinecone" QDRANT = "qdrant" SQLALCHEMY = "sqlalchemy" VERTEXAI = "vertexai" diff --git a/src/langtrace_python_sdk/version.py b/src/langtrace_python_sdk/version.py index 4f821939..6a45bf59 100644 --- a/src/langtrace_python_sdk/version.py +++ b/src/langtrace_python_sdk/version.py @@ -1 +1 @@ -__version__ = "3.6.2" +__version__ = "3.6.3" diff --git a/src/tests/pinecone/test_pinecone.py b/src/tests/pinecone/test_pinecone.py index aed86931..abc8cc17 100644 --- a/src/tests/pinecone/test_pinecone.py +++ b/src/tests/pinecone/test_pinecone.py @@ -34,7 +34,7 @@ def test_upsert(openai_client, pinecone_client, exporter): assert attributes.get("langtrace.sdk.name") == "langtrace-python-sdk" assert attributes.get("langtrace.service.name") == SERVICE_PROVIDERS["PINECONE"] assert attributes.get("langtrace.service.type") == "vectordb" - assert attributes.get("langtrace.service.version") == v("pinecone-client") + assert attributes.get("langtrace.service.version") == v("pinecone") assert attributes.get("langtrace.version") == v("langtrace-python-sdk") assert attributes.get("db.system") == "pinecone" assert attributes.get("db.operation") == APIS["UPSERT"]["OPERATION"] @@ -67,7 +67,7 @@ def test_query(openai_client, pinecone_client, exporter): assert attributes.get("langtrace.sdk.name") == "langtrace-python-sdk" assert attributes.get("langtrace.service.name") == SERVICE_PROVIDERS["PINECONE"] assert attributes.get("langtrace.service.type") == "vectordb" - assert attributes.get("langtrace.service.version") == v("pinecone-client") + assert attributes.get("langtrace.service.version") == v("pinecone") assert attributes.get("langtrace.version") == v("langtrace-python-sdk") assert attributes.get("db.system") == "pinecone" assert attributes.get("db.operation") == APIS["QUERY"]["OPERATION"]