some minor stuff

Author: Quba1

src/codes_handle/iterator.rs

@@ -32,7 +32,7 @@ impl<'ch, S: HandleGenerator> FallibleIterator for RefMessageIter<'ch, S> {
         if new_eccodes_handle.is_null() {
             Ok(None)
         } else {
-            Ok(Some(RefMessage::new_from_gen(new_eccodes_handle)))
+            Ok(Some(RefMessage::new(new_eccodes_handle)))
         }
     }
 }
@@ -60,7 +60,7 @@ impl<S: ThreadSafeHandle> FallibleIterator for ArcMessageIter<S> {
         if new_eccodes_handle.is_null() {
             Ok(None)
         } else {
-            Ok(Some(ArcMessage::new_from_gen(
+            Ok(Some(ArcMessage::new(
                 new_eccodes_handle,
                 &self.codes_handle,
             )))
@@ -76,7 +76,10 @@ mod tests {
         codes_message::DynamicKeyType,
     };
     use anyhow::{Context, Ok, Result};
-    use std::{path::Path, sync::{Arc, Barrier}};
+    use std::{
+        path::Path,
+        sync::{Arc, Barrier},
+    };
 
     #[test]
     fn iterator_lifetimes() -> Result<()> {
@@ -278,13 +281,7 @@ mod tests {
             let t = std::thread::spawn(move || {
                 for _ in 0..1000 {
                     b.wait();
-                    let _ = unsafe {
-                        crate::intermediate_bindings::codes_get_size(
-                            msg.message_handle,
-                            "shortName",
-                        )
-                        .unwrap()
-                    };
+                    let _ = msg.read_key_dynamic("shortName").unwrap();
                 }
             });
 

src/codes_handle/mod.rs

@@ -20,7 +20,7 @@ pub use iterator::{ArcMessageIter, RefMessageIter};
 mod iterator;
 
 /// This is an internal structure used to access provided file by `CodesHandle`.
-/// It also allows to differentiate between `CodesHandle` created from file and from index.
+/// It also allows to differentiate between `CodesFile` created from file and from index.
 /// It is not intended to be used directly by the user.
 #[doc(hidden)]
 #[derive(Debug)]

src/codes_message/clone.rs

@@ -18,3 +18,34 @@ impl<P: Debug> CodesMessage<P> {
         }))
     }
 }
+
+#[cfg(test)]
+mod tests {
+    use std::path::Path;
+
+    use anyhow::{Context, Result};
+    use fallible_iterator::FallibleIterator;
+
+    use crate::{CodesFile, ProductKind};
+
+    #[test]
+    fn check_clone_safety() -> Result<()> {
+        let file_path = Path::new("./data/iceland-levels.grib");
+        let product_kind = ProductKind::GRIB;
+        let mut handle = CodesFile::new_from_file(file_path, product_kind)?;
+
+        let msg1 = handle
+            .ref_message_iter()
+            .next()?
+            .context("Message not some")?;
+        let key1 = msg1.read_key_dynamic("typeOfLevel")?;
+
+        let msg_clone = msg1.try_clone()?;
+        drop(msg1);
+        drop(handle);
+        let key1_clone = msg_clone.read_key_dynamic("typeOfLevel")?;
+        assert_eq!(key1, key1_clone);
+
+        Ok(())
+    }
+}

src/codes_message/mod.rs

@@ -90,7 +90,7 @@ pub struct ArcParent<S: ThreadSafeHandle> {
 }
 
 impl RefMessage<'_> {
-    pub(crate) fn new_from_gen(handle: *mut codes_handle) -> Self {
+    pub(crate) fn new(handle: *mut codes_handle) -> Self {
         RefMessage {
             _parent: RefParent(PhantomData),
             message_handle: handle,
@@ -99,7 +99,7 @@ impl RefMessage<'_> {
 }
 
 impl<S: ThreadSafeHandle> ArcMessage<S> {
-    pub(crate) fn new_from_gen(handle: *mut codes_handle, parent: &Arc<CodesFile<S>>) -> Self {
+    pub(crate) fn new(handle: *mut codes_handle, parent: &Arc<CodesFile<S>>) -> Self {
         ArcMessage {
             _parent: ArcParent {
                 _arc_handle: parent.clone(),