Skip to content

Commit 7d191e6

Browse files
committed
fix(test) string format
1 parent 5392885 commit 7d191e6

File tree

3 files changed

+10
-15
lines changed

3 files changed

+10
-15
lines changed

apps/operations.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,12 +52,12 @@ func (w *OperationWaiter) SetPrompt(p string) {
5252
func (w *OperationWaiter) WaitOperation(ctx context.Context) (*scalingo.Operation, error) {
5353
opURL, err := url.Parse(w.url)
5454
if err != nil {
55-
return nil, errors.Notef(ctx, err, "parse url of operation")
55+
return nil, errors.Wrap(ctx, err, "parse url of operation")
5656
}
5757

5858
c, err := config.ScalingoClient(ctx)
5959
if err != nil {
60-
return nil, errors.Notef(ctx, err, "get Scalingo client")
60+
return nil, errors.Wrap(ctx, err, "get Scalingo client")
6161
}
6262

6363
var op *scalingo.Operation
@@ -70,7 +70,7 @@ func (w *OperationWaiter) WaitOperation(ctx context.Context) (*scalingo.Operatio
7070

7171
op, err = c.OperationsShow(ctx, w.app, opID)
7272
if err != nil {
73-
return nil, errors.Notef(ctx, err, "get operation %v", opID)
73+
return nil, errors.Wrapf(ctx, err, "get operation %v", opID)
7474
}
7575

7676
go func() {
@@ -89,15 +89,15 @@ func (w *OperationWaiter) WaitOperation(ctx context.Context) (*scalingo.Operatio
8989
}
9090
}()
9191

92-
fmt.Fprintf(w.output, w.prompt)
92+
fmt.Fprint(w.output, w.prompt)
9393
spinner := io.NewSpinner(os.Stderr)
9494
go spinner.Start()
9595
defer spinner.Stop()
9696

9797
for {
9898
select {
9999
case err := <-errs:
100-
return op, errors.Notef(ctx, err, "get operation %v", op.ID)
100+
return op, errors.Wrapf(ctx, err, "get operation %v", op.ID)
101101
case <-done:
102102
if op.Status == "done" {
103103
fmt.Printf("\bDone in %.3f seconds\n", op.ElapsedDuration())

git/setup.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,9 @@ import (
77
gitconfig "github.com/go-git/go-git/v5/config"
88
errgo "gopkg.in/errgo.v1"
99

10+
"github.com/pkg/errors"
11+
1012
"github.com/Scalingo/cli/io"
11-
"github.com/Scalingo/cli/utils"
1213
"github.com/Scalingo/go-scalingo/v7/debug"
1314
)
1415

@@ -63,10 +64,10 @@ func createRemoteInRepository(repository *git.Repository, remoteName string, url
6364
URLs: []string{url},
6465
})
6566
if err != nil {
66-
errWrapped := utils.WrapError(err, "fail to create the Git remote")
67+
errWrapped := errors.Wrapf(err, "create the Git remote")
6768
if err == git.ErrRemoteExists {
6869
message := "Fail to configure git repository, '" + remoteName + "' remote already exists (use --force option to override)"
69-
errWrapped = utils.WrapError(errWrapped, message)
70+
errWrapped = errors.Wrap(errWrapped, message)
7071
}
7172
return errWrapped
7273
}
@@ -76,7 +77,7 @@ func createRemoteInRepository(repository *git.Repository, remoteName string, url
7677
func deleteThenCreateRemoteInRepository(repository *git.Repository, remoteName string, url string) error {
7778
err := repository.DeleteRemote(remoteName)
7879
if err != nil {
79-
return utils.WrapError(err, "fail to delete the Git remote")
80+
return errors.Wrap(err, "delete the Git remote")
8081
}
8182
return createRemoteInRepository(repository, remoteName, url)
8283
}

utils/errors.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
package utils
22

33
import (
4-
"gopkg.in/errgo.v1"
5-
64
"github.com/Scalingo/go-scalingo/v7/http"
75
errors "github.com/Scalingo/go-utils/errors/v2"
86
)
@@ -15,7 +13,3 @@ func IsRegionDisabledError(err error) bool {
1513
httperr, ok := reqerr.APIError.(http.ForbiddenError)
1614
return ok && httperr.Code == "region_disabled"
1715
}
18-
19-
func WrapError(err error, wrappingMessage string) error {
20-
return errgo.Notef(err, wrappingMessage)
21-
}

0 commit comments

Comments
 (0)