You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please take a moment to review this document in order to make the contribution
4
-
process easy and effective for everyone involved!
5
-
Also make sure you read our [Code of Conduct](CODE_OF_CONDUCT.md) that outlines our commitment towards an open and welcoming environment.
4
+
process easy and effective for everyone involved! Also, make sure you read our
5
+
[Code of Conduct](CODE_OF_CONDUCT.md) that outlines our commitment towards an
6
+
open and welcoming environment.
6
7
7
8
## Components
8
9
9
-
There are many components that could be written and shared with the community. Only a few really core ones should be in the Scenic package itself. If you have ideas for components, I would love the see the community supply optional packages of them for developers to use.
10
+
There are many components that could be written and shared with the community.
11
+
Only a few really core ones should be in the Scenic package itself. If you have
12
+
ideas for components, I would love the see the community supply optional
13
+
packages of them for developers to use.
10
14
11
-
Each component package should have the component modles themselves, and a "Components" module that contains helper functions to make adding the new components very simple.
12
-
13
-
See the code for Scenic.Components for example helper functions.
15
+
Each component package should have the component models themselves, and a
16
+
"Components" module that contains helper functions to make adding the new
17
+
components very simple.
14
18
19
+
See the code for `Scenic.Components` for example helper functions.
15
20
16
21
## Using the issue tracker
17
22
18
23
Use the issues tracker for:
19
24
20
-
*[bug reports](#bug-reports)
21
-
*[submitting pull requests](#pull-requests)
22
-
23
-
Please **do not** use the issue tracker for personal support requests nor feature requests. Support requests should be sent to:
25
+
*[Bug Reports](#bug-reports)
26
+
*[Submitting Pull Requests](#pull-requests)
24
27
28
+
Please **do not** use the issue tracker for personal support requests nor
29
+
feature requests. Support requests should be sent to:
25
30
26
31
Still working on this bit...
27
32
28
-
For now, please play around with it. I would gladly accept help documenting it.
33
+
For now, please play around with it. I would gladly accept help documenting it.
29
34
30
-
Over the coming weeks, I'll set up discussion mailing lists and whatever. Simply haven't gotten there yet.
35
+
Over the coming weeks, I'll set up discussion mailing lists and whatever. Simply
36
+
haven't gotten there yet.
31
37
32
38
33
39
We do our best to keep the issue tracker tidy and organized, making it useful
@@ -36,9 +42,9 @@ making it easier for developers to [contribute to Scenic](#pull-requests).
36
42
37
43
## Bug reports
38
44
39
-
A bug is either a _demonstrable problem_ that is caused by the code in the repository,
40
-
or indicate missing, unclear, or misleading documentation. Good bug reports are extremely
41
-
helpful - thank you!
45
+
A bug is either a _demonstrable problem_ that is caused by the code in the
46
+
repository or indicate missing, unclear, or misleading documentation. Good bug
47
+
reports are extremely helpful - thank you!
42
48
43
49
Guidelines for bug reports:
44
50
@@ -48,45 +54,50 @@ Guidelines for bug reports:
48
54
2.**Check if the issue has been fixed**— try to reproduce it using the
49
55
`master` branch in the repository.
50
56
51
-
3.**Isolate and report the problem**— ideally create a reduced test
57
+
3.**Isolate and report the problem**— ideally, create a reduced test
52
58
case.
53
59
54
-
Please try to be as detailed as possible in your report. Include information about
55
-
your Operating System, as well as your Erlang, Elixir and Scenic versions. Please provide steps to
56
-
reproduce the issue as well as the outcome you were expecting! All these details
57
-
will help developers to fix any potential bugs.
60
+
Please try to be as detailed as possible in your report. Include information
61
+
about your Operating System, as well as your Erlang, Elixir and Scenic versions.
62
+
Please provide steps to reproduce the issue as well as the outcome you were
63
+
expecting! All these details will help developers to fix any potential bugs.
58
64
59
65
Example:
60
66
61
-
> Short and descriptive example bug report title
62
-
>
63
-
> A summary of the issue and the environment in which it occurs. If suitable,
64
-
> include the steps required to reproduce the bug.
65
-
>
66
-
> 1. This is the first step
67
-
> 2. This is the second step
68
-
> 3. Further steps, etc.
69
-
>
70
-
> `<url>` - a link to the reduced test case (e.g. a GitHub Gist)
71
-
>
72
-
> Any other information you want to share that is relevant to the issue being
73
-
> reported. This might include the lines of code that you have identified as
74
-
> causing the bug, and potential solutions (and your opinions on their
75
-
> merits).
67
+
```md
68
+
Short and descriptive example bug report title
69
+
70
+
A summary of the issue and the environment in which it occurs. If suitable,
71
+
include the steps required to reproduce the bug.
72
+
73
+
1. This is the first step
74
+
2. This is the second step
75
+
3. Further steps, etc.
76
+
77
+
`<url>` - a link to the reduced test case (e.g. a GitHub Gist)
78
+
79
+
Any other information you want to share that is relevant to the issue being
80
+
reported. This might include the lines of code that you have identified as
81
+
causing the bug, and potential solutions (and your opinions on their merits).
82
+
```
76
83
77
84
## Feature requests
78
85
79
-
Feature requests are welcome and should be discussed on [the phoenix-core mailing list](http://groups.google.com/group/phoenix-core). But take a moment to find
80
-
out whether your idea fits with the scope and aims of the project. It's up to *you*
81
-
to make a strong case to convince the community of the merits of this feature.
82
-
Please provide as much detail and context as possible.
86
+
87
+
Feature requests are welcome and should be currently be discussed as an issue
88
+
in github. This will change to either a topic in Elixir forum or a mail-list soon.
89
+
90
+
Before you make a request however, pleaes take a moment to
91
+
find out whether your idea fits with the scope and aims of the project. It's up
92
+
to *you* to make a strong case to convince the community of the merits of this
93
+
feature. Please provide as much detail and context as possible.
83
94
84
95
## Contributing Documentation
85
96
86
97
Code documentation (`@doc`, `@moduledoc`, `@typedoc`) has a special convention:
87
98
the first paragraph is considered to be a short summary.
88
99
89
-
For functions, macros and callbacks say what it will do. For example write
100
+
For functions, macros and callbacks say what it will do. For example write,
90
101
something like:
91
102
92
103
```elixir
@@ -96,19 +107,19 @@ Marks the given value as HTML safe.
96
107
defsafe({:safe, value}), do: {:safe, value}
97
108
```
98
109
99
-
For modules, protocols and types say what it is. For example write
100
-
something like:
110
+
For modules, protocols and types say what it is. For example, write something
111
+
like:
101
112
102
113
```elixir
103
-
defmodulePhoenix.HTMLdo
114
+
defmoduleMyModule.HTMLdo
104
115
@moduledoc """
105
116
Conveniences for working HTML strings and templates.
106
117
...
107
118
"""
108
119
```
109
120
110
121
Keep in mind that the first paragraph might show up in a summary somewhere, long
111
-
texts in the first paragraph create very ugly summaries. As a rule of thumb
122
+
texts in the first paragraph create very ugly summaries. As a rule of thumb,
112
123
anything longer than 80 characters is too long.
113
124
114
125
Try to keep unnecessary details out of the first paragraph, it's only there to
@@ -122,36 +133,36 @@ are often a great help in explaining what a function does.
122
133
123
134
## Pull requests
124
135
125
-
Good pull requests - patches, improvements, new features - are a fantastic
126
-
help. They should remain focused in scope and avoid containing unrelated
127
-
commits.
136
+
Good pull requests - patches, improvements, new features - are a fantastic help.
137
+
They should remain focused in scope and avoid containing unrelated commits.
128
138
129
-
**IMPORTANT**: By submitting a patch, you agree that your work will be
130
-
licensed under the license used by the project.
139
+
> **IMPORTANT**: By submitting a patch, you agree that your work will be licensed
140
+
under the license used by the project.
131
141
132
142
If you have any large pull request in mind (e.g. implementing features,
133
-
refactoring code, etc), **please ask first** otherwise you risk spending
134
-
a lot of time working on something that the project's developers might
135
-
not want to merge into the project.
143
+
refactoring code, etc), **please ask first** otherwise you risk spending a lot
144
+
of time working on something that the project's developers might not want to
145
+
merge into the project.
136
146
137
-
Please adhere to the coding conventions in the project (indentation,
138
-
accurate comments, etc.) and don't forget to add your own tests and
139
-
documentation. When working with git, we recommend the following process
140
-
in order to craft an excellent pull request:
147
+
Please adhere to the coding conventions in the project (indentation, accurate
148
+
comments, etc.) and don't forget to add your own tests and documentation. When
149
+
working with git, we recommend the following process in order to craft an
150
+
excellent pull request:
141
151
142
-
1.[Fork](https://help.github.com/articles/fork-a-repo/) the project, clone your fork,
143
-
and configure the remotes:
152
+
1.[Fork](https://help.github.com/articles/fork-a-repo/) the project, clone your
153
+
fork, and configure the remotes:
144
154
145
155
```bash
146
156
# Clone your fork of the repo into the current directory
0 commit comments