Fix the warning: Supervisor.Spec.supervisor/2 is deprecated. Use the new child specifications outlined in the Supervisor module. by giving the referenced supervisors proper child_specs

Author: boydm

lib/scenic.ex

@@ -85,7 +85,7 @@ defmodule Scenic do
   defp do_init([]) do
     [
       {Scenic.ViewPort.Tables, nil},
-      supervisor(Scenic.Cache.Support.Supervisor, []),
+      {Scenic.Cache.Support.Supervisor, [nil]},
       {DynamicSupervisor, name: @viewports, strategy: :one_for_one}
     ]
     |> Supervisor.init(strategy: :one_for_one)
@@ -96,8 +96,8 @@ defmodule Scenic do
   defp do_init(viewports) do
     [
       {Scenic.ViewPort.Tables, nil},
-      supervisor(Scenic.Cache.Support.Supervisor, []),
-      supervisor(Scenic.ViewPort.SupervisorTop, [viewports]),
+      {Scenic.Cache.Support.Supervisor, [nil]},
+      {Scenic.ViewPort.SupervisorTop, [viewports]},
       {DynamicSupervisor, name: @viewports, strategy: :one_for_one}
     ]
     |> Supervisor.init(strategy: :one_for_one)

lib/scenic/cache/support/supervisor.ex

@@ -11,10 +11,20 @@ defmodule Scenic.Cache.Support.Supervisor do
 
   #  import IEx
 
+  def child_spec() do
+    %{
+      id: __MODULE__,
+      start: {__MODULE__, :start_link, nil},
+      type: :supervisor,
+      restart: :permanent,
+      shutdown: 500
+    }
+  end
+
   # ============================================================================
   # setup the viewport supervisor
 
-  def start_link() do
+  def start_link(_) do
     Supervisor.start_link(__MODULE__, :ok)
   end
 

lib/scenic/view_port/supervisor_top.ex

@@ -17,6 +17,16 @@ defmodule Scenic.ViewPort.SupervisorTop do
   # ============================================================================
   # setup the viewport supervisor
 
+  def child_spec(viewports) do
+    %{
+      id: __MODULE__,
+      start: {__MODULE__, :start_link, viewports},
+      type: :supervisor,
+      restart: :permanent,
+      shutdown: 500
+    }
+  end
+
   def start_link(viewports) do
     Supervisor.start_link(__MODULE__, viewports)
   end

test/test_helper.exs

@@ -1,5 +1,5 @@
 Registry.start_link(keys: :duplicate, name: :viewport_registry)
 Registry.start_link(keys: :duplicate, name: :input_registry)
 Registry.start_link(keys: :duplicate, name: :driver_registry)
-Scenic.Cache.Support.Supervisor.start_link()
+Scenic.Cache.Support.Supervisor.start_link(nil)
 ExUnit.start()