type cleanup

Author: boydm

lib/scenic/cache/hash.ex

@@ -28,8 +28,8 @@ defmodule Scenic.Cache.Hash do
           | :sha512
           | :ripemd160
 
-  @type type_error :: {:error, :invalid_hash_type}
-  @type hash_error :: {:error, :hash_failure}
+  # @type type_error :: {:error, :invalid_hash_type}
+  # @type hash_error :: {:error, :hash_failure}
 
   # ===========================================================================
   defmodule Error do
@@ -67,7 +67,8 @@ defmodule Scenic.Cache.Hash do
 
   Returns the hash wrapped in a `{:ok, hash}` tuple.
   """
-  @spec binary(data :: binary, type :: hash_type) :: {:ok, bitstring()} | type_error
+  @spec binary(data :: binary, type :: hash_type) ::
+    {:ok, bitstring()} | {:error, :invalid_hash_type}
   def binary(data, type) do
     case valid_hash_type?(type) do
       true -> {:ok, type |> :crypto.hash(data) |> Base.url_encode64(padding: false)}
@@ -88,7 +89,8 @@ defmodule Scenic.Cache.Hash do
   end
 
   # --------------------------------------------------------
-  @spec file(path :: bitstring, type :: hash_type) :: {:ok, bitstring()} | type_error
+  @spec file(path :: bitstring, type :: hash_type) ::
+    {:ok, bitstring()} | {:error, :invalid_hash_type}
   def file(path, hash_type) do
     do_compute_file(
       path,
@@ -145,7 +147,8 @@ defmodule Scenic.Cache.Hash do
   If the verification passes, returns `{:ok, data}`
   If it fails, returns `{:error, :hash_failure}`
   """
-  @spec verify(data :: binary, hash :: bitstring, type :: hash_type) :: {:ok, binary} | hash_error
+  @spec verify(data :: binary, hash :: bitstring, type :: hash_type) ::
+    {:ok, binary} | {:error, :hash_failure}
   def verify(data, hash, hash_type) do
     case binary(data, hash_type) do
       {:ok, ^hash} -> {:ok, data}
@@ -176,7 +179,7 @@ defmodule Scenic.Cache.Hash do
   If it fails, returns `{:error, :hash_failure}`
   """
   @spec verify_file(path :: bitstring, hash :: bitstring, type :: hash_type) ::
-          binary | hash_error
+          {:ok, binary} | {:error, :hash_failure}
   def verify_file(path, hash, hash_type) do
     case file(path, hash_type) do
       {:ok, computed_hash} ->