Merge pull request #44 from milmazz/preserve_stacktrace

Preserve stacktrace

Author: boydm

lib/scenic/cache.ex

@@ -48,36 +48,39 @@ defmodule Scenic.Cache do
   def get(key, default \\ nil)
 
   def get(key, default) do
-    try do
-      :ets.lookup_element(@cache_table, key, 3)
-    rescue
-      ArgumentError -> default
-      other -> raise other
-    end
+    :ets.lookup_element(@cache_table, key, 3)
+  rescue
+    ArgumentError ->
+      default
+
+    other ->
+      reraise(other, __STACKTRACE__)
   end
 
   # --------------------------------------------------------
   def fetch(key)
 
   def fetch(key) do
-    try do
-      {:ok, :ets.lookup_element(@cache_table, key, 3)}
-    rescue
-      ArgumentError -> {:error, :not_found}
-      other -> raise other
-    end
+    {:ok, :ets.lookup_element(@cache_table, key, 3)}
+  rescue
+    ArgumentError ->
+      {:error, :not_found}
+
+    other ->
+      reraise(other, __STACKTRACE__)
   end
 
   # --------------------------------------------------------
   def get!(key)
 
   def get!(key) do
-    try do
-      :ets.lookup_element(@cache_table, key, 3)
-    rescue
-      ArgumentError -> raise Error, message: "Key #{inspect(key)} not found."
-      other -> raise other
-    end
+    :ets.lookup_element(@cache_table, key, 3)
+  rescue
+    ArgumentError ->
+      raise Error, message: "Key #{inspect(key)} not found."
+
+    other ->
+      reraise(other, __STACKTRACE__)
   end
 
   # --------------------------------------------------------

test/scenic/primitives_test.exs

@@ -86,7 +86,7 @@ defmodule Scenic.PrimitivesTest do
       |> Graph.get!(:group)
 
     assert p.module == Scenic.Primitive.Group
-    assert Enum.count(p.data) == 0
+    assert p.data == []
     assert p.id == :group
   end