Merge pull request #79 from boydm/boyd

Add missing tests

Author: boydm

lib/scenic/cache/term.ex

@@ -11,7 +11,7 @@ defmodule Scenic.Cache.Term do
   alias Scenic.Cache
   alias Scenic.Cache.Hash
 
-  #  import IEx
+  # import IEx
 
   # --------------------------------------------------------
   def load(path, hash, opts \\ [])

test/scenic/cache/file_test.exs

@@ -88,6 +88,15 @@ defmodule Scenic.Cache.FileReadTest do
              decompress: true
            ) == {:error, :hash_failure}
   end
+
+  test "read passes through errors" do
+    # missing term file
+    assert Cache.File.read(
+             "not/valid/path",
+             @invalid_sha256,
+             hash: :sha256
+           ) == {:error, :enoent}
+  end
 end
 
 defmodule Scenic.Cache.FileLoadTest do
@@ -187,4 +196,13 @@ defmodule Scenic.Cache.FileLoadTest do
              decompress: true
            ) == {:error, :hash_failure}
   end
+
+  test "load passes through errors" do
+    # missing term file
+    assert Cache.File.load(
+             "not/valid/path",
+             @invalid_sha256,
+             hash: :sha256
+           ) == {:error, :enoent}
+  end
 end

test/scenic/cache/term_test.exs

@@ -75,6 +75,15 @@ defmodule Scenic.Cache.TermReadTest do
              @sample_sha
            ) == {:error, :invalid_term}
   end
+
+  test "read passes through errors" do
+    # missing term file
+    assert Cache.Term.read(
+             "not/valid/path",
+             @invalid_sha256,
+             hash: :sha256
+           ) == {:error, :enoent}
+  end
 end
 
 defmodule Scenic.Cache.TermLoadTest do
@@ -98,6 +107,9 @@ defmodule Scenic.Cache.TermLoadTest do
   @sample_path "test/artifacts/sample_file"
   @sample_sha "2PGNXGkoTc4stYncIe-qCdZFuw0"
 
+  @non_term_path "test/artifacts/sample_file"
+  @non_term_sha "2PGNXGkoTc4stYncIe-qCdZFuw0"
+
   @cache_table :scenic_cache_key_table
   @scope_table :scenic_cache_scope_table
 
@@ -155,4 +167,19 @@ defmodule Scenic.Cache.TermLoadTest do
              @sample_sha
            ) == {:error, :invalid_term}
   end
+
+  test "load passes through errors" do
+    # missing term file
+    assert Cache.Term.load(
+             "not/valid/path",
+             @invalid_sha256,
+             hash: :sha256
+           ) == {:error, :enoent}
+
+    # badly formatted term file
+    assert Cache.Term.load(
+             @non_term_path,
+             @non_term_sha
+           ) == {:error, :invalid_term}
+  end
 end

test/scenic/graph_test.exs

@@ -441,6 +441,25 @@ defmodule Scenic.GraphTest do
   #   # assert Map.get(merged, :input) == [:key, :char, :cursor_down]
   # end
 
+  # ============================================================================
+  # add
+
+  test "add a pre-built primitive to a graph" do
+    p = Primitive.Line.build({{0, 0}, {2, 2}}, id: :added)
+    graph = Graph.add(@graph_find, p)
+    Graph.get!(graph, :added)
+  end
+
+  test "add a new primitive to a graph" do
+    count = Graph.count(@graph_find)
+
+    post_add_count =
+      Graph.add(@graph_find, Primitive.Line, {{0, 0}, {2, 2}})
+      |> Graph.count()
+
+    assert post_add_count > count
+  end
+
   # ============================================================================
   # def modify( graph, uid, action )
 
@@ -639,4 +658,8 @@ defmodule Scenic.GraphTest do
     assert Map.get(graph.primitives[t1], :transforms) == @transform
     assert Map.get(graph.primitives[other], :transforms) == nil
   end
+
+  test "style_stack returns an empty map for invalid uid" do
+    assert Graph.style_stack(@graph_find, 1234) == %{}
+  end
 end