Skip to content

Commit 4c45c89

Browse files
committed
feat: enhance pull request template with query builder specific sections and filter testing checklist
- Add query builder specific feature areas - Add filter testing checklist - Add query generation testing requirements - Add bookmark/sharing testing
1 parent cffcec9 commit 4c45c89

File tree

1 file changed

+94
-13
lines changed

1 file changed

+94
-13
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 94 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,101 @@
1-
<!--- PR title should follow conventional commits (https://conventionalcommits.org) -->
1+
<!--
2+
Thank you for contributing to MagicMark! 🎉
3+
Please fill out this template to help us review your PR.
4+
-->
25

3-
### Description
6+
## 📝 Description
7+
<!-- Provide a clear and concise description of your changes -->
48

5-
<!-- Describe your changes in detail -->
6-
<!-- What changes have been made -->
79

8-
### Type of change
910

10-
<!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply. -->
11+
## 🔗 Related Issue(s)
12+
<!-- Link to related issues. Use "Closes #123" or "Fixes #123" to auto-close issues -->
1113

12-
- [ ] Documentation (updates to the documentation or readme)
13-
- [ ] Bug fix (a non-breaking change that fixes an issue)
14-
- [ ] Enhancement (improving an existing functionality like performance)
15-
- [ ] New feature (a non-breaking change that adds functionality)
16-
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
14+
- Closes #
15+
- Related to #
1716

18-
### Relevant Issue(s)
17+
## 🎯 Type of Change
18+
<!-- Put an `x` in all boxes that apply -->
1919

20-
<!-- If it resolves an open issue, please link to the issue here. For example "Resolves #1337" -->
20+
- [ ] 🐛 Bug fix (non-breaking change that fixes an issue)
21+
- [ ] ✨ New feature (non-breaking change that adds functionality)
22+
- [ ] 💥 Breaking change (fix or feature that would cause existing functionality to change)
23+
- [ ] 🔧 Enhancement (improving existing functionality)
24+
- [ ] 📝 Documentation update
25+
- [ ] 🎨 UI/UX improvement
26+
- [ ] ♻️ Code refactoring
27+
- [ ] ⚡ Performance improvement
28+
29+
## 🔍 Feature Area
30+
<!-- Which part of the plugin does this affect? -->
31+
32+
- [ ] Query Builder UI
33+
- [ ] Filter Types / Operators
34+
- [ ] Bookmark/Mark Management
35+
- [ ] Sharing & Permissions
36+
- [ ] Advanced Filters
37+
- [ ] Relation Filters
38+
- [ ] Date/Time Filters
39+
- [ ] Search & Discovery
40+
- [ ] Admin UI
41+
- [ ] Content Manager Integration
42+
- [ ] API / Backend
43+
- [ ] Documentation
44+
45+
## 🧪 Testing
46+
<!-- Describe the tests you ran to verify your changes -->
47+
48+
- [ ] I have tested these changes locally
49+
- [ ] I have tested with different content types
50+
- [ ] I have tested filter creation and application
51+
- [ ] I have tested sharing/permissions (if applicable)
52+
- [ ] New and existing tests pass locally with my changes
53+
54+
### Test Environment
55+
56+
- **Plugin Version**:
57+
- **Strapi Version**:
58+
- **Node Version**:
59+
- **Database**:
60+
- **OS**:
61+
62+
### Filter Testing
63+
<!-- If applicable, describe filter scenarios you tested -->
64+
65+
- [ ] Tested with simple filters
66+
- [ ] Tested with complex/nested filters
67+
- [ ] Tested with relation filters
68+
- [ ] Tested filter preview
69+
- [ ] Tested bookmark sharing
70+
71+
## 📸 Screenshots/Videos
72+
<!-- If applicable, add screenshots of query builder or filter results -->
73+
74+
75+
76+
## 📋 Checklist
77+
<!-- Put an `x` in all boxes that apply -->
78+
79+
- [ ] My code follows the project's code style
80+
- [ ] I have performed a self-review of my own code
81+
- [ ] I have commented my code, particularly in hard-to-understand areas
82+
- [ ] I have made corresponding changes to the documentation
83+
- [ ] My changes generate no new warnings or errors
84+
- [ ] I have checked that my PR follows [Conventional Commits](https://conventionalcommits.org)
85+
- [ ] I have tested query generation and execution
86+
87+
## 🔄 Breaking Changes
88+
<!-- If this introduces breaking changes, describe the impact and migration path -->
89+
90+
91+
92+
## 📚 Additional Context
93+
<!-- Add any other context about the PR here -->
94+
95+
96+
97+
---
98+
**PR Title Format**: Please use conventional commits format:
99+
- `feat: add date range filter operator`
100+
- `fix: resolve relation filter query generation`
101+
- `docs: update advanced filter examples`

0 commit comments

Comments
 (0)