Other mods calling this mod to draw plans do not display anything.

[JiaRG]

Hi, I have a mod that uses PlanningExtended.Designators.PlanWallsDesignator to draw a cross shape at the center of the map. It does so by calling PlanWallsDesignator.DesignateMultiCell(CentralCross);. However, after updating to version 1.6 of this mod, the method no longer results in any plan being drawn on the map, and there are no error logs either. Am I calling it incorrectly?
Here's the link to my mod: Steam Mod and GitHub

[JiaRG]

Comment from the author on Steam:
I just gave it a try and my guess was right. It depends on the selected shape variant. If the "Rectangle Outline" is selected, nothing is drawn. If "Rectangle Filled" is selected, an endless number of NullReferenceExceptions are thrown.

Call PlanWallsDesignator.SelectShape(Shape.Rectangle) first. Then call PlanWallsDesignator.SelectedShape.SelectShapeVariant(ShapeVariant.RectangleFilled). After that, you should be able to draw a filled rectangle. I didn't look into the reason why this resulted in lots of thrown NullReferenceExceptions, though.

[JiaRG]

I switched to using PlanObjectsDesignator, and its default shape and variant are exactly the two you mentioned, but it still doesn't work.

[JiaRG]

Comment from the author on Steam:

Changing to the PlanObjectsDesignator will not really help, as the user can still switch the shape/shape variant. Also check the visibility and opacity of the plans.

If you don't want to call these other two methods, it might be easier to just add / remove the designations manually. If you want to continue this conversation, may I ask you to open a separate thread / discussion instead?

[JiaRG]

@Scherub visibility is true. opacity of the plans is 100%

[Scherub]

I originally thought of a thread on the Steam workshop, but this is also okay. I guess it makes things like highlighting code or linking things even easier.

As I said, you could just copy the PlanDesignation and add them manually. It's important to keep the namespace, though.

If you look at a save file with planning designations of this mod, it looks like this:

	<li Class="PlanningExtended.Designations.PlanDesignation">
		<def>PlanWalls</def>
		<target>(72, 0, 114)</target>
		<colorDef>Structure_White</colorDef>
	</li>

[Scherub]

@Scherub visibility is true. opacity of the plans is 100%

Did you also get those NullReferenceExceptions I mentioned?

[JiaRG]

Yes, I encountered that exception — it gets triggered when I use the toggle button to draw the central cross after modifying the shape using the V shortcut.

System.NullReferenceException: Object reference not set to an instance of an object
[Ref D266735D]
  at Verse.DesignationDragger.TryAddDragCell (Verse.IntVec3 c) [0x00006] in <052ffdda8ff74a858542a735289dd477>:0 
  at Verse.DesignationDragger.UpdateDragCellsIfNeeded () [0x00087] in <052ffdda8ff74a858542a735289dd477>:0 
  at Verse.DesignationDragger.get_FailureReason () [0x00000] in <052ffdda8ff74a858542a735289dd477>:0 
  at Verse.Designator.FinalizeDesignationFailed () [0x0001e] in <052ffdda8ff74a858542a735289dd477>:0 
  at Verse.Designator.Finalize (System.Boolean somethingSucceeded) [0x0000a] in <052ffdda8ff74a858542a735289dd477>:0 
  at PlanningExtended.Designators.BaseUndoRedoPlanDesignator.DesignateMultiCell (System.Collections.Generic.IEnumerable`1[T] cells) [0x00046] in <33037d7e9a4743cebc29c51990fb01a8>:0 
  at CenterMarker.CenterMarkerMapComponent.DoCenterMarker () [0x0001f] in <86ba4021d41f4e01a9228656001ba7a5>:0 
  at CenterMarker.CenterMarkerMapComponent.MapComponentUpdate () [0x00000] in <86ba4021d41f4e01a9228656001ba7a5>:0 
  at Verse.MapComponentUtility.MapComponentUpdate (Verse.Map map) [0x00013] in <052ffdda8ff74a858542a735289dd477>:0 
UnityEngine.StackTraceUtility:ExtractStackTrace ()
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Log.Error_Patch1 (string)
Verse.MapComponentUtility:MapComponentUpdate (Verse.Map)
Verse.Map:MapUpdate ()
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Game.UpdatePlay_Patch1 (Verse.Game)
Verse.Root_Play:Update ()

[JiaRG]

If you don't want to call these other two methods, it might be easier to just add / remove the designations manually.

The main issue is that I prefer not to include other mods' DLL files in my project — managing versions and maintaining the build becomes quite troublesome. I hope you understand.

My project only needs to draw at five specific coordinates on the current map, so using the abstract base class Designator is perfectly sufficient.

It mainly involves just three methods. CanDesignateCell DesignateMultiCell DesignateSingleCell

[Scherub]

I do understand that you don't want to add a direct reference to this project or its dll. That's the reason why I said, copy the PlanDesignation file to your project. You don't even need most of the stuff like rotation, etc.

Anyway, I've just debugged into this and the problem is, that there is a check, which verifies whether the passed cells match the selected shape. Unfortunately, the shape has the wrong coordinates.

I already had a similar problem with the color picker which I mentioned in the workshop comment section, where I got around by just not checking the shape when picking a color. But this isn't a solution to your problem.

RimWorld v1.6 has changed something in their code, that causes to only update the shape when the mouse is dragged. I have to take a closer look at what exactly they have changed and how I can fix the problem. But I probably won't be able to do that before the next weekend.