Skip to content

Commit b43b4aa

Browse files
authored
Log real errors and not just their messages, traces are useful (matrix-org#2464)
1 parent d3ff765 commit b43b4aa

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

src/crypto/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3284,7 +3284,7 @@ export class Crypto extends TypedEventEmitter<CryptoEvent, CryptoEventHandlerMap
32843284
event.on(MatrixEventEvent.Status, statusListener);
32853285
});
32863286
} catch (err) {
3287-
logger.error("error while waiting for the verification event to be sent: " + err.message);
3287+
logger.error("error while waiting for the verification event to be sent: ", err);
32883288
return;
32893289
} finally {
32903290
event.removeListener(MatrixEventEvent.LocalEventIdReplaced, eventIdListener);
@@ -3308,7 +3308,7 @@ export class Crypto extends TypedEventEmitter<CryptoEvent, CryptoEventHandlerMap
33083308
try {
33093309
await request.channel.handleEvent(event, request, isLiveEvent);
33103310
} catch (err) {
3311-
logger.error("error while handling verification event: " + err.message);
3311+
logger.error("error while handling verification event", err);
33123312
}
33133313
const shouldEmit = isNewRequest &&
33143314
!request.initiatedByMe &&

src/store/indexeddb-store-worker.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,8 +122,7 @@ export class IndexedDBStoreWorker {
122122
result: ret,
123123
});
124124
}, (err) => {
125-
logger.error("Error running command: " + msg.command);
126-
logger.error(err);
125+
logger.error("Error running command: " + msg.command, err);
127126
this.postMessage.call(null, {
128127
command: 'cmd_fail',
129128
seq: msg.seq,

0 commit comments

Comments
 (0)