fix time parsing

Author: JoCa96

packages/sit-onyx/src/components/OnyxDataGrid/features/renderer.ts

@@ -196,15 +196,15 @@ export const timeFormatter = <TEntry extends DataGridEntry>(
   opts?: DateCellOptions,
 ): string => {
   // using loose "==" here to catch both undefined and null
-  if (value == undefined || typeof value !== "string") return fallback(opts);
+  if (value == undefined || typeof value === "boolean") return fallback(opts);
 
   const { d } = injectI18n();
 
   const seconds = parseTimeSeconds(value);
   if (seconds) {
-    const now = new Date();
+    const base = new Date(0);
     return d.value(
-      new Date(now.getFullYear(), now.getMonth(), now.getDate(), 0, 0, seconds),
+      new Date(base.getFullYear(), base.getMonth(), base.getDate(), 0, 0, seconds),
       "time",
     );
   }

packages/sit-onyx/src/utils/time.spec.ts

@@ -33,7 +33,6 @@ describe("parseTimeSeconds", () => {
     { timeString: "12:", expected: null },
     { timeString: "12:34:", expected: null },
     { timeString: "12:foo", expected: null },
-    { timeString: "foo:12", expected: null },
     { timeString: "12:34:bar", expected: null },
     { timeString: "00:00:00", expected: 0 },
     { timeString: "00:00:01", expected: 1 },

packages/sit-onyx/src/utils/time.ts

@@ -1,3 +1,5 @@
+import type { DateValue } from "../components/OnyxDatePicker/types.js";
+
 /**
  * Calculate seconds, minutes and hours for a given number of milliseconds.
  */
@@ -57,9 +59,22 @@ export const timeToDurationString = (timeLeft: number): `PT${number}H${number}M$
 /**
  * Parses an RFC 9557 time string (`HH:mm:ss.sssssssss`) and converts it into seconds.
  */
-export const parseTimeSeconds = (timeString?: string): number | null => {
-  if (!timeString) return null;
-  const parts = timeString.split(":").map((p) => Number.parseInt(p, 10));
-  if (parts.length < 2 || parts.some(Number.isNaN)) return null;
-  return parts[0]! * 3600 + parts[1]! * 60 + (parts[2] || 0);
+export const parseTimeSeconds = (value?: unknown): number | null => {
+  if (!value) return null;
+
+  if (typeof value === "string" && /^(\d+:)*\d+(\.\d+)?$/.test(value)) {
+    const parts = value.split(":").map((p) => Number.parseInt(p, 10));
+    if (parts.length < 2 || parts.some(Number.isNaN)) return null;
+    return parts[0]! * 3600 + parts[1]! * 60 + (parts[2] || 0);
+  }
+
+  try {
+    const date = new Date(typeof value === "bigint" ? Number(value) : (value as DateValue));
+    if (!Number.isNaN(date.getTime())) {
+      return date.getTime() / 1000;
+    }
+    return null;
+  } catch {
+    return null;
+  }
 };