Skip to content

Commit 23393f0

Browse files
authored
fix: only show Edit tab if editMetadataEnabled is true (#2136)
## Description If editDatasetEnabled is true but editMetadataEnabled is false the Edit tab still shows. This PR fixes that. ## Changes: - remove [hidden] attribute - put both conditions in ngIf ## Tests included - [ ] Included for each change/fix? - [ ] Passing? (Merge will not be approved unless this is checked) ## Documentation - [ ] swagger documentation updated \[required\] - [ ] official documentation updated \[nice-to-have\] ### official documentation info If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included ## Backend version - [ ] Does it require a specific version of the backend - which version of the backend is required: ## Summary by Sourcery Bug Fixes: - Prevent the Edit tab from being shown when metadata editing is disabled in the application configuration.
2 parents 68d764a + 77e9ebe commit 23393f0

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

src/app/datasets/dataset-detail/dataset-detail/dataset-detail.component.html

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -398,8 +398,7 @@
398398
</mat-tab>
399399
<mat-tab
400400
class="editTab"
401-
*ngIf="editingAllowed"
402-
[hidden]="!appConfig.editMetadataEnabled"
401+
*ngIf="editingAllowed && appConfig.editMetadataEnabled"
403402
>
404403
<ng-template mat-tab-label>
405404
<mat-icon> edit </mat-icon> Edit

0 commit comments

Comments
 (0)