Skip to content

Commit 875e382

Browse files
authored
fix: remove duplicate logbook endpoint calls (#1983)
## Description This PR removes some duplicated logbook findByName API calls ## Motivation Background on use case, changes needed ## Fixes: Please provide a list of the fixes implemented in this PR * Items added ## Changes: Please provide a list of the changes implemented by this PR * changes made ## Tests included - [ ] Included for each change/fix? - [ ] Passing? (Merge will not be approved unless this is checked) ## Documentation - [ ] swagger documentation updated \[required\] - [ ] official documentation updated \[nice-to-have\] ### official documentation info If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included ## Backend version - [ ] Does it require a specific version of the backend - which version of the backend is required: ## Summary by Sourcery Remove redundant logbook fetch actions to prevent duplicate endpoint calls Bug Fixes: - Remove redundant fetchDatasetLogbookAction dispatch in LogbooksDashboardComponent - Remove redundant fetchCountAction dispatch in LogbookEffects
1 parent 45fe3e9 commit 875e382

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

src/app/datasets/dataset-details-dashboard/dataset-details-dashboard.component.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -249,6 +249,14 @@ export class DatasetDetailsDashboardComponent
249249
}
250250
}
251251
break;
252+
case TAB.logbook:
253+
{
254+
const { loaded } = this.fetchDataActions[TAB.logbook];
255+
if (!loaded) {
256+
this.fetchDataActions[TAB.logbook].loaded = true;
257+
}
258+
}
259+
break;
252260
default: {
253261
const { action, loaded } = this.fetchDataActions[tab];
254262
if (!loaded) {

0 commit comments

Comments
 (0)