RELEASE 01-07-2025 (#1924)

## Description
Short description of the pull request


## Motivation
Background on use case, changes needed


## Fixes:
Please provide a list of the fixes implemented in this PR

* Items added


## Changes:
Please provide a list of the changes implemented by this PR

* changes made


## Tests included
- [ ] Included for each change/fix?
- [ ] Passing? (Merge will not be approved unless this is checked) 

## Documentation
- [ ] swagger documentation updated \[required\]
- [ ] official documentation updated \[nice-to-have\]

### official documentation info
If you have updated the official documentation, please provide PR # and
URL of the pages where the updates are included

## Backend version
- [ ] Does it require a specific version of the backend
- which version of the backend is required:

## Summary by Sourcery

Unify and streamline table rendering across the application by replacing
bespoke table implementations with a shared dynamic-mat-table component,
introduce a fully integrated files dashboard with state management and
pagination, persist user table preferences, expand datafiles action
types with JSON-download support, and add configurable main-page routing
along with accompanying state, effects, and tests.

New Features:
- Replace custom dataset, samples, files, jobs, and metadata tables with
a centralized dynamic-mat-table component
- Add a files dashboard for origDatablocks with pagination, sorting, and
global search via new NgRx state slice, selectors, actions, and effects
- Enable user-configurable table settings (columns, sort, pagination)
persisted through user settings and TableConfigService
- Introduce a new 'json-download' type for datafiles actions with
templated payloads and filename substitution
- Add MainPageConfiguration and MainPageGuard to route users to
configurable default main pages

Enhancements:
- Refactor AppConfigService to support defaultMainPage and add
validation for application configuration
- Migrate job and sample handling to SciCat SDK v3 endpoints and DTOs,
updating effects, selectors, and reducers
- Consolidate HTML and SCSS across multiple components, removing
redundant markup and styles for tables and cards
- Extend MetadataViewComponent to support export rendering and paging
mode configuration
- Bump dependencies and generator scripts (openapi-generator-cli,
scicat-sdk-ts-angular, zone.js, @types/node) and add a lint:errors task

CI:
- Update SDK generation scripts to openapi-generator-cli v7.13.0
- Add lint:errors npm script

Documentation:
- Add comprehensive Datafiles Actions documentation for form and
JSON-download configurations

Tests:
- Revise and expand unit tests for dynamic-mat-table interactions,
convertSavedColumns logic, nested metadata resolution, files selectors,
and new event types

Author: Junjiequan

CI/e2e/frontend.config.e2e.json

@@ -4,6 +4,7 @@
   "archiveWorkflowEnabled": false,
   "datasetReduceEnabled": true,
   "datasetJsonScientificMetadata": true,
+  "editDatasetEnabled": true,
   "editDatasetSampleEnabled": true,
   "editMetadataEnabled": true,
   "editPublishedData": false,

cypress/e2e/datasets/datasets-datafiles.cy.js

@@ -44,7 +44,7 @@ describe("Dataset datafiles", () => {
 
       cy.isLoading();
 
-      cy.contains("mat-row", "Cypress Dataset").first().click();
+      cy.get("mat-row").contains("Cypress Dataset").first().click();
 
       cy.wait("@fetch");
 
@@ -101,7 +101,7 @@ describe("Dataset datafiles", () => {
 
       cy.isLoading();
 
-      cy.contains("mat-row", "Cypress Dataset").first().click();
+      cy.get("mat-row").contains("Cypress Dataset").first().click();
 
       cy.wait("@fetch");
 

cypress/e2e/datasets/datasets-publish.cy.js

@@ -23,7 +23,7 @@ describe("Datasets", () => {
 
       cy.isLoading();
 
-      cy.get("[data-cy=checkboxInput]").first().click();
+      cy.get(".dataset-table input[type='checkbox']").first().click();
 
       cy.get("#addToBatchButton").click();
 

cypress/e2e/datasets/datasets-share.cy.js

@@ -23,7 +23,7 @@ describe("Datasets", () => {
 
       cy.isLoading();
 
-      cy.get("[data-cy=checkboxInput]").first().click();
+      cy.get(".dataset-table input[type='checkbox']").first().click();
 
       cy.get("#addToBatchButton").click();
 

package-lock.json

@@ -9,6 +9,7 @@
     "watch": "ng build --watch --configuration default",
     "test": "ng test --watch=false --source-map=false",
     "lint": "ng lint",
+    "lint:errors": "ng lint --quiet",
     "lint:fix": "ng lint --fix",
     "betterer": "betterer",
     "cypress:open": "cypress open",
@@ -54,7 +55,7 @@
     "shortid": "^2.2.16",
     "socket.io-client": "^4.7.2",
     "tslib": "^2.4.0",
-    "zone.js": "^0.15.0"
+    "zone.js": "^0.15.1"
   },
   "devDependencies": {
     "@angular-devkit/build-angular": "^19.2.9",
@@ -76,7 +77,7 @@
     "@types/jasmine": "^5.1.0",
     "@types/lodash-es": "^4.17.12",
     "@types/luxon": "^3.3.0",
-    "@types/node": "^22.0.0",
+    "@types/node": "^24.0.3",
     "@types/shortid": "2.2.0",
     "@types/source-map-support": "^0.5.3",
     "@typescript-eslint/eslint-plugin": "^8.32.0",

package.json

@@ -1,16 +1,25 @@
 import { HttpClient } from "@angular/common/http";
 import { TestBed } from "@angular/core/testing";
-import { AppConfig, AppConfigService, HelpMessages } from "app-config.service";
+import {
+  AppConfigInterface,
+  AppConfigService,
+  HelpMessages,
+} from "app-config.service";
 import { of } from "rxjs";
 import { MockHttp } from "shared/MockStubs";
 
-const appConfig: AppConfig = {
+const appConfig: AppConfigInterface = {
+  defaultMainPage: {
+    nonAuthenticatedUser: "DATASETS",
+    authenticatedUser: "DATASETS",
+  },
   skipSciCatLoginPageEnabled: false,
   accessTokenPrefix: "",
   addDatasetEnabled: true,
   archiveWorkflowEnabled: true,
   datasetReduceEnabled: true,
   datasetJsonScientificMetadata: true,
+  editDatasetEnabled: true,
   editDatasetSampleEnabled: true,
   editMetadataEnabled: true,
   editPublishedData: true,

src/app/app-config.service.spec.ts

@@ -35,7 +35,19 @@ export class HelpMessages {
   }
 }
 
-export interface AppConfig {
+export enum MainPageOptions {
+  DATASETS = "/datasets",
+  PROPOSALS = "/proposals",
+  INSTRUMENTS = "/instruments",
+  SAMPLES = "/samples",
+}
+
+export class MainPageConfiguration {
+  nonAuthenticatedUser: keyof typeof MainPageOptions;
+  authenticatedUser: keyof typeof MainPageOptions;
+}
+
+export interface AppConfigInterface {
   skipSciCatLoginPageEnabled?: boolean;
   accessTokenPrefix: string;
   addDatasetEnabled: boolean;
@@ -45,6 +57,7 @@ export interface AppConfig {
   datasetDetailsShowMissingProposalId: boolean;
   datafilesActionsEnabled: boolean;
   datafilesActions: any[];
+  editDatasetEnabled: boolean;
   editDatasetSampleEnabled: boolean;
   editMetadataEnabled: boolean;
   editPublishedData: boolean;
@@ -106,9 +119,22 @@ export interface AppConfig {
   datasetDetailComponent?: DatasetDetailComponentConfig;
   labelsLocalization?: LabelsLocalization;
   dateFormat?: string;
+  defaultMainPage?: MainPageConfiguration;
 }
 
-@Injectable()
+function isMainPageConfiguration(obj: any): obj is MainPageConfiguration {
+  const validKeys = Object.keys(MainPageOptions);
+  return (
+    obj &&
+    typeof obj === "object" &&
+    validKeys.includes(obj.nonAuthenticatedUser) &&
+    validKeys.includes(obj.authenticatedUser)
+  );
+}
+
+@Injectable({
+  providedIn: "root",
+})
 export class AppConfigService {
   private appConfig: object = {};
 
@@ -130,13 +156,37 @@ export class AppConfigService {
         console.error("No config provided.");
       }
     }
+
+    const config: AppConfigInterface = this.appConfig as AppConfigInterface;
+    if (
+      "defaultMainPage" in config &&
+      isMainPageConfiguration(config.defaultMainPage)
+    ) {
+      config.defaultMainPage.nonAuthenticatedUser = Object.keys(
+        MainPageOptions,
+      ).includes(config.defaultMainPage.nonAuthenticatedUser)
+        ? config.defaultMainPage.nonAuthenticatedUser
+        : "DATASETS";
+      config.defaultMainPage.authenticatedUser = Object.keys(
+        MainPageOptions,
+      ).includes(config.defaultMainPage.authenticatedUser)
+        ? config.defaultMainPage.authenticatedUser
+        : "DATASETS";
+    } else {
+      config.defaultMainPage = {
+        nonAuthenticatedUser: "DATASETS",
+        authenticatedUser: "DATASETS",
+      } as MainPageConfiguration;
+    }
+
+    this.appConfig = config;
   }
 
-  getConfig(): AppConfig {
+  getConfig(): AppConfigInterface {
     if (!this.appConfig) {
       console.error("AppConfigService: Configuration not loaded!");
     }
 
-    return this.appConfig as AppConfig;
+    return this.appConfig as AppConfigInterface;
   }
 }

src/app/app-config.service.ts

@@ -5,6 +5,8 @@ import { ErrorPageComponent } from "shared/modules/error-page/error-page.compone
 import { AppLayoutComponent } from "_layout/app-layout/app-layout.component";
 import { AppMainLayoutComponent } from "_layout/app-main-layout/app-main-layout.component";
 import { ServiceGuard } from "./service.guard";
+import { MainPageGuard } from "./main-page";
+import { RedirectingComponent } from "./redirecting.component";
 
 export const routes: Routes = [
   {
@@ -13,7 +15,8 @@ export const routes: Routes = [
     children: [
       {
         path: "",
-        redirectTo: "/datasets",
+        canActivate: [MainPageGuard],
+        component: RedirectingComponent,
         pathMatch: "full",
       },
       {

src/app/app-routing/app-routing.module.ts

@@ -0,0 +1,33 @@
+import { Injectable } from "@angular/core";
+import { CanActivate, Router } from "@angular/router";
+import {
+  AppConfigService,
+  MainPageConfiguration,
+  MainPageOptions,
+} from "app-config.service";
+import { AuthService } from "shared/services/auth/auth.service";
+
+@Injectable({ providedIn: "root" })
+export class MainPageGuard implements CanActivate {
+  constructor(
+    private router: Router,
+    private appConfigService: AppConfigService,
+    private authService: AuthService,
+  ) {}
+
+  canActivate(): boolean {
+    const defaultMainPage: MainPageConfiguration =
+      this.appConfigService.getConfig().defaultMainPage;
+
+    const userLoggedIn = this.authService.isAuthenticated();
+
+    this.router.navigate([
+      MainPageOptions[
+        userLoggedIn
+          ? defaultMainPage.authenticatedUser
+          : defaultMainPage.nonAuthenticatedUser
+      ],
+    ]);
+    return false;
+  }
+}