Integration users endpoint

[totopoloco]

#2181

[totopoloco]

On behalf of @Junjiequan :

I heard from Max that you are about to work on users list.

The task might overlap with what I have already done in this PR, where I created an empty user list view component under the admin-dashboard page. However, I’m not sure if that aligns with how you plan to implement the user list feature.
I’m wondering whether this task should be done in parallel in a separate PR, or if it should wait until the admin-dashboard with the config editing UI is merged into master first. Since I imagine the user list view will be under the admin-dashboard, what do you think?

[totopoloco]

Hello Jay,

Yes, we could have separate branches for each PR and continuously merge one branch into the other.

It would be something like this in Git branches:

Marco -> 'mavila_users_endpoint_integration'

Jay -> 'jay_users_view_implementation'.

I think this would allow us to integrate both features. It would depend on your branch, so please let me know when you would like me to merge your changes into mine.

The PR needs fixing, I see:

[baseline-browser-mapping] The data in this module is over two months old. To ensure accurate Baseline data, please update: npm i baseline-browser-mapping@latest -D

• Generating browser application bundles (phase: setup)...
  ✔ Browser application bundle generation complete.

Error: src/app/state-management/effects/runtime-config.effects.ts:13:10 - error TS2305: Module '"@scicatproject/scicat-sdk-ts-angular"' has no exported member 'RuntimeConfigService'.

13 import { RuntimeConfigService } from "@scicatproject/scicat-sdk-ts-angular";
~~~~~~~~~~~~~~~~~~~~

15 01 2026 09:53:03.914:ERROR [karma-server]: Error: Found 1 load error
at Server. (/home/runner/work/frontend/frontend/node_modules/karma/lib/server.js:243:26)
at Object.onceWrapper (node:events:633:28)
at Server.emit (node:events:531:35)
at Server.emit (node:domain:489:12)
at emitListeningNT (node:net:1983:10)
at process.processTicksAndRejections (node:internal/process/task_queues:89:21)
✔ Browser application bundle generation complete.
✔ Browser application bundle generation complete.
Error: Process completed with exit code 1.

Kind Regards

~M

[Junjiequan]

The SDK error will disappear only after a new SDK version with runtimeConfigService is released, which requires a new backend release after the backend PR is merged.

If you would like to work based on this branch, you need to run: npm generate:sdk:local using this branch to generate local sdk and overwritte the one in the node_modules (the script handles overwritting process).

[totopoloco]

FRONTEND

I created a new branch based on SWAP-5087-scicat-fe-poc-render-frontend-config-with-json-fo called SWAP-5087-mavila-users-integration, and I managed to call npm generate:sdk:local so I have a working environment

$ git log --oneline --decorate --graph --all | head -20
*   83bebc30 (HEAD -> SWAP-5087-mavila-users-integration, origin/SWAP-5087-scicat-fe-poc-render-frontend-config-with-json-fo, origin/SWAP-5087-mavila-users-integration, SWAP-5087-scicat-fe-poc-render-frontend-config-with-json-fo) Merge branch 'master' into SWAP-5087-scicat-fe-poc-render-frontend-config-with-json-fo
|\  
* | bf45be09 added list settings schema
* | 5edb6007 render content only when panne is expanded to improve performance
* | f8624304 minor jsonforms schema change
* |   fd91413e Merge branch 'master' into SWAP-5087-scicat-fe-poc-render-frontend-config-with-json-fo
|\ \  
* \ \   e65aaa5a Merge branch 'master' into SWAP-5087-scicat-fe-poc-render-frontend-config-with-json-fo
|\ \ \  
* | | | 93788c6a minor css change
* | | | 0b4114d8 replace deprecated toPromise() with firstValueFrom
* | | | e27df8b8 remove additionalProperties from jsonforms schema
* | | | fd95985d show admin settings button only to admin user
* | | | 34d61fb7 update comments for temporary conversion functions
* | | | ea319ab0 fix es lint
* | | |   ef084bee Merge branch 'master' into SWAP-5087-scicat-fe-poc-render-frontend-config-with-json-fo
|\ \ \ \  
* | | | | 8b360d27 change naming of admin state to runtimeConfig state
* | | | | 504b83e2 eslint fix
* | | | | c5bd66ae include json preview & export

BACKEND
Running fine with branch SWAP-5086-scicat-be-poc-store-frontend-config-into-the-data [OK]

Where would the new endpoint to get the users be integrated?

NOTE
(Admin Settings BETA has an issue)

The TypeError: Cannot read properties of undefined (reading 'hasOwnProperty') error, particularly in the context of R3Injector.get and runtime-config.effects.ts, indicates that the Angular injector is attempting to read a property (hasOwnProperty) from an object that is undefined. This commonly happens when a dependency required by RunTimeConfigEffects (or any other service/effect) cannot be properly resolved or provided by the Angular dependency injection system, resulting in undefined being injected instead of an instance of the expected dependency. The stack trace suggests the issue occurs during the creation of RunTimeConfigEffects itself, specifically at runtime-config.effects.ts:22:34, which is where its constructor or a factory function for it tries to inject something.

[totopoloco]

Ah I fixed it, would you like to add a new menu here maybe?, please advise

[Junjiequan]

Yes. My plan was to add new tab User list next to the Configuration tab. On line 34 and 54 in the src/app/admin/admin-dashboard/admin-dashboard.component.ts I have commented the tab settings for user list and I have also created user list view component heresrc/app/admin/admin-userlist-view/admin-userlist-view.component.ts.

[Junjiequan]

Please feel free to change things as needed, it was just my initial attempt to lay the groundwork for user list view feature

[totopoloco]

Dear Jay,

I have implemented the changes in the following branch: SWAP-5087-mavila-users-integration

I opened a PR in #2197 but maybe you want to cherry pick only these two commits:

c161f68
f600ee0

The feature looks like this:

You can sort and search per column, I think this would be enough, I saw that pagination could be added, but I am not sure it is needed.

[Junjiequan]

Thank you for the nice work.

Just some comments, the column search functionality is planned to be removed soon, as it's might be a bit confusing to users that local search and server search are mixed on the same page.

It would be nice to have a pagination and the search bar(server side query) if it's easy to implement, otherwise we can do it in another PR.

[totopoloco]

Dear Jay,

In the commit 08e1364 I have removed the filtering to only allow sorting the column.

I think we could implement the search functionality in another PR to keep this one small.

The PR is still the same: #2197

Kind Regards

~M

[totopoloco]

Dear @Junjiequan and @nitrosx,
The changes have been merged into the SWAP-5087-scicat-fe-poc-render-frontend-config-with-json-fo branch. Once the SDK issues have been resolved, all these changes could be merged into the master branch.

Kind Regards

~M