Skip to content

Commit d7cf12c

Browse files
committed
Fix tests
1 parent 356b84d commit d7cf12c

File tree

4 files changed

+13
-13
lines changed

4 files changed

+13
-13
lines changed

cpp/models/ode_secir/parameters_io.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,7 @@ IOResult<void> set_population_data(Model<ScalarType>& model, const std::vector<S
306306
total);
307307
}
308308

309-
for (auto i = AgeGroup(0); i < AgeGroup(6); i++) {
309+
for (auto i = AgeGroup(0); i < num_groups; i++) {
310310
for (auto j = Index<InfectionState>(0); j < InfectionState::Count; ++j) {
311311
if (model.populations[{i, j}] < 0) {
312312
log_warning("Compartment at age group {}, infection state {}, is negative: {}", size_t(i), size_t(j),

cpp/tests/test_odesecir.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1551,7 +1551,6 @@ TEST(TestOdeSecirIO, read_input_data_county_aggregates_one_group)
15511551
models1[0].property.parameters.get<mio::osecir::CriticalPerSevere<double>>()[mio::AgeGroup(0)] = 0.25;
15521552

15531553
auto pydata_dir_Germany = mio::path_join(TEST_DATA_DIR, "Germany", "pydata");
1554-
const std::vector<int> counties{1002};
15551554
const auto date = mio::Date(2020, 12, 1);
15561555

15571556
std::vector<double> scale6(num_age_groups, 1.0);

pycode/memilio-simulation/memilio/simulation/bindings/models/osecir.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@ PYBIND11_MODULE(_simulation_osecir, m)
305305
auto node_ids = pymio::check_and_throw(mio::get_node_ids(mio::path_join(pydata_path, "county_current_population.json"), true));
306306

307307
mio::Graph<mio::osecir::Model<double>, mio::MobilityParameters<double>> params_graph(node_ids,
308-
mio::osecir::Model<double>::Populations({params.get_num_groups(), mio::osecir::InfectionState::Count}), params);
308+
mio::osecir::Model<double>::Populations({params.get_num_groups(), mio::osecir::InfectionState::Count}), params);
309309
pymio::check_and_throw(mio::osecir::read_input_data(params_graph.nodes(), start_date, scaling_factor_inf, scaling_factor_icu,
310310
mio::regions::de::EpidataFilenames::county(pydata_path)));
311311

pycode/memilio-simulation/memilio/simulation/bindings/models/osecirvvs.cpp

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -336,29 +336,30 @@ PYBIND11_MODULE(_simulation_osecirvvs, m)
336336
pymio::bind_read_graph<mio::osecirvvs::Model<double>>(m);
337337
m.def(
338338
"read_input_data_german_county",
339-
[](mio::Graph<mio::osecirvvs::Model<double>, mio::MobilityParameters<double>>& params_graph, mio::Date start_date,
340-
const std::vector<double>& scaling_factor_inf, double scaling_factor_icu, std::string& pydata_path) {
339+
[](mio::Graph<mio::osecirvvs::Model<double>, mio::MobilityParameters<double>>& params_graph,
340+
mio::Date start_date, const std::vector<double>& scaling_factor_inf, double scaling_factor_icu,
341+
int num_days, std::string& pydata_path) {
341342

342343
auto result = mio::osecirvvs::read_input_data(params_graph.nodes(), start_date, scaling_factor_inf, scaling_factor_icu,
343-
mio::regions::de::EpidataFilenames::county(pydata_path));
344+
num_days, mio::regions::de::EpidataFilenames::county(pydata_path));
344345
return pymio::check_and_throw(result);
345346
},
346347
"Reads compartments for german counties at a specified date from data files.",
347348
py::arg("params_graph"), py::arg("start_date"), py::arg("scaling_factor_inf"), py::arg("scaling_factor_icu"),
348-
py::arg("pydata_path"), py::return_value_policy::move);
349+
py::arg("num_days"), py::arg("pydata_path"), py::return_value_policy::move);
349350

350351
m.def(
351352
"create_graph_german_county",
352353
[](const mio::osecirvvs::Parameters<double>& params, mio::Date start_date, mio::Date end_date,
353-
const std::vector<double>& scaling_factor_inf, double scaling_factor_icu, std::string& pydata_path,
354-
double tnt_capacity_factor) {
354+
const std::vector<double>& scaling_factor_inf, double scaling_factor_icu, int num_days,
355+
std::string& pydata_path, double tnt_capacity_factor) {
355356

356357
auto node_ids = pymio::check_and_throw(mio::get_node_ids(mio::path_join(pydata_path, "county_current_population.json"), true));
357358

358359
mio::Graph<mio::osecirvvs::Model<double>, mio::MobilityParameters<double>> params_graph(node_ids,
359-
mio::osecirvvs::Model<double>::Populations({params.get_num_groups(), mio::osecirvvs::InfectionState::Count}), params);
360-
pymio::check_and_throw(mio::osecirvvs::read_input_data(params_graph.nodes(), start_date, scaling_factor_inf, scaling_factor_icu,
361-
mio::regions::de::EpidataFilenames::county(pydata_path)));
360+
mio::osecirvvs::Model<double>::Populations({params.get_num_groups(), mio::osecirvvs::InfectionState::Count}), params);
361+
pymio::check_and_throw(mio::osecirvvs::read_input_data(params_graph.nodes(), start_date,
362+
scaling_factor_inf, scaling_factor_icu, num_days, mio::regions::de::EpidataFilenames::county(pydata_path)));
362363

363364
mio::set_test_and_trace_capacity<mio::osecirvvs::Model<double>, mio::osecirvvs::TestAndTraceCapacity<double>>(params_graph.nodes(), tnt_capacity_factor);
364365
mio::set_german_holidays<double, mio::osecirvvs::Model<double>, mio::osecirvvs::ContactPatterns<double>>(params_graph.nodes(), start_date, end_date);
@@ -368,7 +369,7 @@ PYBIND11_MODULE(_simulation_osecirvvs, m)
368369
},
369370
"Creates graph of germany with compartments for geographic units at a specified date from data files.",
370371
py::arg("params"), py::arg("start_date"), py::arg("end_date"), py::arg("scaling_factor_inf"),
371-
py::arg("scaling_factor_icu"), py::arg("pydata_path"), py::arg("tnt_capacity_factor"),
372+
py::arg("scaling_factor_icu"), py::arg("num_days"), py::arg("pydata_path"), py::arg("tnt_capacity_factor"),
372373
py::return_value_policy::move);
373374
#endif // MEMILIO_HAS_JSONCPP
374375

0 commit comments

Comments
 (0)