Skip to content

add warning for defect control #257

@maysam-gholampour

Description

@maysam-gholampour

Is your feature request related to a problem? Please describe.

Yes, I ran my code to solve a two-poimt BVP system with different inputs using FIRK solver, and for some cases, the return code was Failure. However, when I increased the max_num_subintervals, it returned Success as the return code. I reviewed the source code and noticed that for all solvers with defect control (in my case, RadauIIa7), there is an if condition:
if 2 * (length(cache.mesh) - 1) > cache.alg.max_num_subintervals
This condition sets the return code to Failure.
MRE: #242

Describe the solution you’d like

I believe adding a warning with a recommendation would be helpful in this case. In the SciMLBase documentation, it is mentioned that if the solver is Julia-based solver, an issue can be opened. https://docs.sciml.ai/SciMLBase/stable/interfaces/Solutions/#SciMLBase.ReturnCode.Failure

Describe alternatives you’ve considered

I believe adding a warning with a recommendation would be helpful in this case. The warning should mention not only the failure condition but also indicate that the solver still returns results, which might not be reliable.

Additional context

The code line can be modified for FIRK

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions