Skip to content

Commit 12331ae

Browse files
authored
Merge pull request #1197 from SciML/misc_doc_fixes
[WIP] Minor docfixes
2 parents ff5358a + ff0f708 commit 12331ae

18 files changed

+71
-74
lines changed

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -137,9 +137,9 @@ model. Here we instead show how various Catalyst features can compose to create
137137
a much more advanced model. Our model describes how the volume of a cell ($V$)
138138
is affected by a growth factor ($G$). The growth factor only promotes growth
139139
while in its phosphorylated form ($G^P$). The phosphorylation of $G$ ($G \to G^P$)
140-
is promoted by sunlight (modeled as the cyclic sinusoid $k_a (\sin(t) + 1)$),
141-
which phosphorylates the growth factor (producing $G^P$). When the cell reaches a
142-
critical volume ($V_m$) it undergoes cell division. First, we declare our model:
140+
is promoted by sunlight, which is modeled as the cyclic sinusoid $k_a (\sin(t) + 1)$.
141+
When the cell reaches a critical volume ($V_m$) it undergoes cell division. First, we
142+
declare our model:
143143
```julia
144144
using Catalyst
145145
cell_model = @reaction_network begin

docs/src/devdocs/dev_guide.md

Lines changed: 15 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,23 @@
11
# Catalyst Developer Documentation
22

3-
## Release Process
3+
## [Release Process](@id devdocs_releaseprocess)
44
Beginning with v15, Catalyst is using a new release process to try to ensure
55
continuing stability of releases. Before making a release one should
66

7-
1. Create a new release branch, i.e. "release-15.0.0"
7+
1. Create a new release branch, i.e. "release-15.0.0".
88
2. On this branch, cap major dependencies to their latest version that works and
99
for which tests pass.
1010
- Caps need to be included in both Project.toml and docs/Project.toml.
1111
- Do not cap the master branch as this can prevent upstream libraries from
1212
properly testing against Catalyst, and hide breaking changes that impact
1313
Catalyst.
14-
3. Check docs build with the capped dependencies. Visually verify via checking
15-
the artifact in the doc build that the docs actually look ok (since sometimes
16-
issues can arise that do not lead to actual errors in the doc CI).
17-
4. Release via the [registration
14+
3. [Check docs build](@ref devdocs_advice_doc_inspection) with the capped dependencies.
15+
Visually verify via checking the artifact in the doc build that the docs actually
16+
look ok (since sometimes issues can arise that do not lead to actual errors in the doc CI).
17+
5. Release via the [registration
1818
issue](https://github.com/SciML/Catalyst.jl/issues/127) with the
19-
command:
20-
21-
```
22-
@JuliaRegistrator register branch=release-15.0.0
23-
```
24-
25-
modifying as appropriate for the version you are releasing.
19+
command: `@JuliaRegistrator register branch=release-15.0.0`, modifying as appropriate
20+
for the version you are releasing.
2621

2722
If there is subsequently a need to increment the version of a dependency, this
2823
should be done via a new release that follows the above process, and modifies
@@ -34,15 +29,17 @@ should be preferred. If the new release branch is branched from master, *it
3429
needs to ensure Project.toml caps are all ≥ to those listed in the previous
3530
Catalyst release branch*.
3631

37-
## Development advice
32+
## [Development advice](@id devdocs_advice)
3833

39-
### Checking doc builds for errors
34+
### [Checking doc builds for errors](@id devdocs_advice_doc_error_checks)
4035
When updating documentation, Catalyst will run any Julia code provided within example blocks to dynamically create figures and outputs. In addition to automatically creating these for us, it also provides an automatic check that all code in documentation is correct. Here, if any of the documentation code throws an error, the build job will fail. The documentation build job can be found at the bottom of a PRs conversation, here is an example of a failed one:
36+
4137
![Failed builddocs link](../assets/devdocs/failed_builddocs_link.png)
38+
4239
To check what errors were produced, click on the "Details" link of the job. Next, any errors can be found at the bottom of the "Build and deploy" section (which should be opened automatically).
4340

44-
### Inspecting documentation of a PR or branch
45-
When updating documentation it is typically useful to view the updated documentation in HTML format (which is the format users will see). Here, some errors are much easier to spot in html format as compared with the raw text files from which these are generated. There are two primary ways to view updated documentation, either by downloading them from the PR or by building the docs locally.
41+
### [Inspecting the built documentation of a PR or branch](@id devdocs_advice_doc_inspection)
42+
When updating documentation it is typically useful to view the updated documentation in HTML format (which is the format users will see). Here, some errors are much easier to spot in .html format as compared with the raw text files from which these are generated. There are two primary ways to view updated documentation, either by downloading them from the PR or by building the docs locally.
4643

4744
Whenever a PR to Catalyst is created, CI will create a corresponding documenter build job. If the build job passes, you can access the built documentation (which will be the new Catalyst documentation if the PR is merged) through the following steps:
4845
1. Click on "Details" in the documentation build job (at the bottom of the PR conversation tab).
@@ -54,5 +51,5 @@ To build the Catalyst documentation locally:
5451
1. Navigate to the ".julia/dev/Catalyst/docs/" folder and run the "make.jl" file using ">julia make.jl". Alternatively, open a Julia session, activate the "docs" environment, and run the file using `include("make.jl").
5552
2. Open the ".julia/dev/Catalyst/docs/build/index.html" file.
5653

57-
### Spellchecking in your code
54+
### [Spellchecking in your code](@id devdocs_advice_codespellchecker)
5855
Especially when writing documentation, but also when writing normal code, it can be useful to have a spellchecker running through your texts. While code can be copied into a spellchecker and checked there (which is still useful to check grammar), it can also be very useful to (for users of VSCode) run the [Code Spell Checker](https://marketplace.visualstudio.com/items?itemName=streetsidesoftware.code-spell-checker) extension. This will automatically provide simple spell-checking for code and documentation as you write it.

docs/src/index.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -164,9 +164,9 @@ model. Here we instead show how various Catalyst features can compose to create
164164
a much more advanced model. Our model describes how the volume of a cell ($V$)
165165
is affected by a growth factor ($G$). The growth factor only promotes growth
166166
while in its phosphorylated form ($G^P$). The phosphorylation of $G$ ($G \to G^P$)
167-
is promoted by sunlight (modeled as the cyclic sinusoid $k_a (\sin(t) + 1)$),
168-
which phosphorylates the growth factor (producing $G^P$). When the cell reaches a
169-
critical volume ($V_m$) it undergoes cell division. First, we declare our model:
167+
is promoted by sunlight, which is modeled as the cyclic sinusoid $k_a (\sin(t) + 1)$.
168+
When the cell reaches a critical volume ($V_m$) it undergoes cell division. First, we
169+
declare our model:
170170
```@example home_elaborate_example
171171
using Catalyst
172172
cell_model = @reaction_network begin

docs/src/inverse_problems/behaviour_optimisation.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# [Optimization for non-data fitting purposes](@id behaviour_optimisation)
1+
# [Optimization for Non-data Fitting Purposes](@id behaviour_optimisation)
22
In previous tutorials we have described how to use [PEtab.jl](@ref petab_parameter_fitting) and [Optimization.jl](@ref optimization_parameter_fitting) for parameter fitting. This involves solving an optimisation problem (to find the parameter set yielding the best model-to-data fit). There are, however, other situations that require solving optimisation problems. Typically, these involve the creation of a custom objective function, which minimizer can then be found using Optimization.jl. In this tutorial we will describe this process, demonstrating how parameter space can be searched to find values that achieve a desired system behaviour. Many options used here are described in more detail in [the tutorial on using Optimization.jl for parameter fitting](@ref optimization_parameter_fitting). A more throughout description of how to solve these problems is provided by [Optimization.jl's documentation](https://docs.sciml.ai/Optimization/stable/) and the literature[^1].
33

44
## [Maximising the pulse amplitude of an incoherent feed forward loop](@id behaviour_optimisation_IFFL_example)

docs/src/model_creation/chemistry_related_functionality.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# [Chemistry-related functionality](@id chemistry_functionality)
1+
# [Chemistry-related Functionality](@id chemistry_functionality)
22

33
While Catalyst has primarily been designed around the modelling of biological systems, reaction network models are also common in chemistry. This section describes two types of functionality, that while of general interest, should be especially useful in the modelling of chemical systems.
44
- The `@compound` option, which enables the user to designate that a specific species is composed of certain subspecies.

docs/src/model_creation/conservation_laws.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# [Working with conservation laws](@id conservation_laws)
1+
# [Working with Conservation Laws](@id conservation_laws)
22
Catalyst can detect, and eliminate for differential-equation based models, *conserved quantities*, i.e. linear combinations of species which are conserved via the chemistry. This functionality is both automatically utilised by Catalyst (e.g. to [remove singular Jacobians during steady state computations](@ref homotopy_continuation_conservation_laws)), but is also available for users to utilise directly (e.g. to potentially [improve simulation performance](@ref ode_simulation_performance_conservation_laws)).
33

44
To illustrate conserved quantities, let us consider the following [two-state](@ref basic_CRN_library_two_states) model:

0 commit comments

Comments
 (0)