Skip to content

Commit 1f8d805

Browse files
committed
fix unnecessary logging
1 parent 72a744e commit 1f8d805

File tree

3 files changed

+11
-10
lines changed

3 files changed

+11
-10
lines changed

Project.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ DomainSets = "5b8099bc-c8ec-5219-889f-1d9e522a28bf"
6767
Graphviz_jll = "3c863552-8265-54e4-a6dc-903eb78fde85"
6868
HomotopyContinuation = "f213a82b-91d6-5c5d-acf7-10f1c761b327"
6969
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
70+
Logging = "56ddb016-857b-54e1-b83d-db4d58db5568"
7071
NonlinearSolve = "8913a72c-1f9b-4ce2-8d82-65094dcecaec"
7172
OrdinaryDiffEq = "1dea7af3-3e70-54e6-95c3-0bf5283fa5ed"
7273
Plots = "91a5bcdd-55d7-5caf-9e0b-520d859cae80"
@@ -83,4 +84,4 @@ Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
8384
Unitful = "1986cc42-f94f-5a68-af5c-568840ba703d"
8485

8586
[targets]
86-
test = ["BifurcationKit", "DiffEqCallbacks", "DomainSets", "Graphviz_jll", "HomotopyContinuation", "NonlinearSolve", "OrdinaryDiffEq", "Plots", "Random", "SafeTestsets", "SciMLBase", "SciMLNLSolve", "StableRNGs", "Statistics", "SteadyStateDiffEq", "StochasticDiffEq", "StructuralIdentifiability", "Test", "Unitful"]
87+
test = ["BifurcationKit", "DiffEqCallbacks", "DomainSets", "Graphviz_jll", "HomotopyContinuation", "Logging", "NonlinearSolve", "OrdinaryDiffEq", "Plots", "Random", "SafeTestsets", "SciMLBase", "SciMLNLSolve", "StableRNGs", "Statistics", "SteadyStateDiffEq", "StochasticDiffEq", "StructuralIdentifiability", "Test", "Unitful"]

test/extensions/structural_identifiability.jl

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,9 @@ let
3737

3838
# Identifiability analysis for Catalyst converted to StructuralIdentifiability.jl model.
3939
si_catalyst_ode = make_si_ode(goodwind_oscillator_catalyst; measured_quantities = [:M])
40-
gi_2 = assess_identifiability(si_catalyst_ode)
41-
li_2 = assess_local_identifiability(si_catalyst_ode)
42-
ifs_2 = find_identifiable_functions(si_catalyst_ode)
40+
gi_2 = assess_identifiability(si_catalyst_ode; loglevel)
41+
li_2 = assess_local_identifiability(si_catalyst_ode; loglevel)
42+
ifs_2 = find_identifiable_functions(si_catalyst_ode; loglevel)
4343

4444
# Identifiability analysis for StructuralIdentifiability.jl model (declare this overwrites e.g. X2 variable etc.).
4545
goodwind_oscillator_si = @ODEmodel(
@@ -264,14 +264,14 @@ let
264264
k1, x1 --> x2
265265
end
266266
# Measure the source
267-
id_report = assess_identifiability(rs, measured_quantities = [:x1])
267+
id_report = assess_identifiability(rs; measured_quantities = [:x1], loglevel)
268268
@test sym_dict(id_report) == Dict(
269269
:x1 => :globally,
270270
:x2 => :nonidentifiable,
271271
:k1 => :globally
272272
)
273273
# Measure the target instead
274-
id_report = assess_identifiability(rs, measured_quantities = [:x2])
274+
id_report = assess_identifiability(rs; measured_quantities = [:x2], loglevel)
275275
@test sym_dict(id_report) == Dict(
276276
:x1 => :globally,
277277
:x2 => :globally,
@@ -303,13 +303,13 @@ let
303303
1, x1 --> x2
304304
1, x2 --> x3
305305
end
306-
id_report = assess_identifiability(rs, measured_quantities = [:x3])
306+
id_report = assess_identifiability(rs; measured_quantities = [:x3], loglevel)
307307
@test sym_dict(id_report) == Dict(
308308
:x1 => :globally,
309309
:x2 => :globally,
310310
:x3 => :globally,
311311
)
312-
@test length(find_identifiable_functions(rs, measured_quantities = [:x3])) == 1
312+
@test length(find_identifiable_functions(rs; measured_quantities = [:x3], loglevel)) == 1
313313
end
314314

315315

test/miscellaneous_tests/stability_computation.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ let
2929
:d => 0.5 + rand(rng))
3030

3131
# Computes stability using various jacobian options.
32-
sss = hc_steady_states(rn, ps; show_progress=false)
32+
sss = hc_steady_states(rn, ps; show_progress = false)
3333
stabs_1 = [steady_state_stability(ss, rn, ps) for ss in sss]
3434
stabs_2 = [steady_state_stability(ss, rn, ps; ss_jac = ss_jac) for ss in sss]
3535

@@ -71,7 +71,7 @@ let
7171
ps_3 = [rn.k1 => 8.0, rn.k2 => 2.0, rn.k3 => 1.0, rn.k4 => 1.5, rn.kD1 => 0.5, rn.kD2 => 4.0]
7272

7373
# Computes stability using various input forms, and checks that the output is correct.
74-
sss = hc_steady_states(rn, ps_1; u0 = u0_1, show_progress=false)
74+
sss = hc_steady_states(rn, ps_1; u0 = u0_1, show_progress = false)
7575
for u0 in [u0_1, u0_2, u0_3, u0_4], ps in [ps_1, ps_2, ps_3]
7676
stab_1 = [steady_state_stability(ss, rn, ps) for ss in sss]
7777
ss_jac = steady_state_jac(rn; u0 = u0)

0 commit comments

Comments
 (0)