Skip to content

Commit 2cd8c75

Browse files
authored
Merge pull request #1127 from SciML/isaacsas-uncap-bases
Uncap those bases
2 parents 8a9b4e4 + 1d106b6 commit 2cd8c75

File tree

3 files changed

+13
-6
lines changed

3 files changed

+13
-6
lines changed

Project.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ BifurcationKit = "0.4.4"
4646
CairoMakie = "0.12"
4747
Combinatorics = "1.0.2"
4848
DataStructures = "0.18"
49-
DiffEqBase = "< 6.159.0"
49+
DiffEqBase = "6.159.0"
5050
DocStringExtensions = "0.8, 0.9"
5151
DynamicPolynomials = "0.5, 0.6"
5252
DynamicQuantities = "0.13.2, 1"
@@ -62,7 +62,7 @@ Parameters = "0.12"
6262
Reexport = "0.2, 1.0"
6363
Requires = "1.0"
6464
RuntimeGeneratedFunctions = "0.5.12"
65-
SciMLBase = "< 2.57.2"
65+
SciMLBase = "2.57.2"
6666
Setfield = "1"
6767
# StructuralIdentifiability = "0.5.8"
6868
SymbolicUtils = "2.1.2, 3.3.0"

docs/Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ BifurcationKit = "0.4.4"
5050
CairoMakie = "0.12"
5151
Catalyst = "14.4"
5252
DataFrames = "1.6"
53-
DiffEqBase = "< 6.159.0"
53+
DiffEqBase = "6.159.0"
5454
DiffEqParamEstim = "2.2"
5555
Distributions = "0.25"
5656
Documenter = "1.4.1"

test/upstream/mtk_structure_indexing.jl

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -208,10 +208,17 @@ end
208208
# Currently, `save_idxs` is broken with symbolic stuff (https://github.com/SciML/ModelingToolkit.jl/issues/1761).
209209
let
210210
for (prob, solver) in zip(deepcopy([oprob, sprob, jprob]), [Tsit5(), ImplicitEM(), SSAStepper()])
211+
211212
# Save single variable
212-
@test_broken solve(prob, solver; seed, save_idxs=X)[X][1] == 4
213-
@test_broken solve(prob, solver; seed, save_idxs=model.X)[X][1] == 4
214-
@test_broken solve(prob, solver; seed, save_idxs=:X)[X][1] == 4
213+
if !(solver isa SSAStepper)
214+
@test solve(prob, solver; seed, save_idxs=X)[X][1] == 4
215+
@test solve(prob, solver; seed, save_idxs=model.X)[X][1] == 4
216+
@test solve(prob, solver; seed, save_idxs=:X)[X][1] == 4
217+
else
218+
@test_broken solve(prob, solver; seed, save_idxs=X)[X][1] == 4
219+
@test_broken solve(prob, solver; seed, save_idxs=model.X)[X][1] == 4
220+
@test_broken solve(prob, solver; seed, save_idxs=:X)[X][1] == 4
221+
end
215222

216223
# Save observable.
217224
@test_broken solve(prob, solver; seed, save_idxs=XY)[XY][1] == 9

0 commit comments

Comments
 (0)