Skip to content

Commit 2cf77fb

Browse files
committed
change broken tests
1 parent abf9b93 commit 2cf77fb

File tree

1 file changed

+6
-10
lines changed

1 file changed

+6
-10
lines changed

test/upstream/mtk_structure_indexing.jl

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,7 @@ end
6565
# Tests problem indexing and updating.
6666
let
6767
@test_broken false # A few cases fails for JumpProblem: https://github.com/SciML/ModelingToolkit.jl/issues/2838
68-
@test_broken false # A few cases fails for SteadyStateProblem: https://github.com/SciML/SciMLBase.jl/issues/660
69-
@test_broken false # Most cases broken for Ensemble problems: https://github.com/SciML/SciMLBase.jl/issues/661
70-
for prob in deepcopy([oprob, sprob, dprob, nprob])
68+
for prob in deepcopy([oprob, sprob, dprob, nprob, ssprob, eoprob, esprob, edprob, enprob, essprob])
7169
# Get u values (including observables).
7270
@test prob[X] == prob[model.X] == prob[:X] == 4
7371
@test prob[XY] == prob[model.XY] == prob[:XY] == 9
@@ -119,9 +117,7 @@ end
119117
# Test remake function.
120118
let
121119
@test_broken false # Cannot check result for JumpProblem: https://github.com/SciML/ModelingToolkit.jl/issues/2838
122-
@test_broken false # Cannot deepcopy SteadyStateProblem :https://github.com/SciML/ModelingToolkit.jl/issues/2837
123-
@test_broken false # Currently cannot be run for Ensemble problems: https://github.com/SciML/SciMLBase.jl/issues/661 (as indexing cannot be used to check values).
124-
for prob in deepcopy([oprob, sprob, dprob, nprob])
120+
for prob in deepcopy([oprob, sprob, dprob, nprob, ssprob, eoprob, esprob, edprob, enprob, essprob])
125121
# Remake for all u0s.
126122
rp = remake(prob; u0 = [X => 1, Y => 2])
127123
@test rp[[X, Y]] == [1, 2]
@@ -243,10 +239,10 @@ let
243239
@test getu(sol, (XY,Y))(sol)[1] == getu(sol, (model.XY,model.Y))(sol)[1] == getu(sol, (:XY,:Y))(sol)[1] == (9, 5)
244240

245241
# Get u values via idxs and functional call.
246-
@test osol(0.0; idxs=X) == osol(0.0; idxs=model.X) == osol(0.0; idxs=:X) == 4
247-
@test osol(0.0; idxs=XY) == osol(0.0; idxs=model.XY) == osol(0.0; idxs=:XY) == 9
248-
@test osol(0.0; idxs = [XY,Y]) == osol(0.0; idxs = [model.XY,model.Y]) == osol(0.0; idxs = [:XY,:Y]) == [9, 5]
249-
@test_broken osol(0.0; idxs = (XY,Y)) == osol(0.0; idxs = (model.XY,model.Y)) == osol(0.0; idxs = (:XY,:Y)) == (9, 5) # https://github.com/SciML/SciMLBase.jl/issues/711
242+
@test sol(0.0; idxs=X) == sol(0.0; idxs=model.X) == sol(0.0; idxs=:X) == 4
243+
@test sol(0.0; idxs=XY) == sol(0.0; idxs=model.XY) == sol(0.0; idxs=:XY) == 9
244+
@test sol(0.0; idxs = [XY,Y]) == sol(0.0; idxs = [model.XY,model.Y]) == sol(0.0; idxs = [:XY,:Y]) == [9, 5]
245+
@test_broken sol(0.0; idxs = (XY,Y)) == sol(0.0; idxs = (model.XY,model.Y)) == sol(0.0; idxs = (:XY,:Y)) == (9, 5) # https://github.com/SciML/SciMLBase.jl/issues/711
250246

251247
# Get p values.
252248
@test sol.ps[kp] == sol.ps[model.kp] == sol.ps[:kp] == 1.0

0 commit comments

Comments
 (0)