up

Author: TorkelE

test/reactionsystem_core/events.jl

@@ -158,7 +158,7 @@ let
     ]
 
     # Declares various misformatted events .
-    # Relevant MTK issue regarding misformatted events not throwing an early error https://github.com/SciML/ModelingToolkit.jl/issues/2612.
+    @test_broken false # Some missformatted tests should throw error at this stage, but does not (https://github.com/SciML/ModelingToolkit.jl/issues/2612).
     continuous_events_bad = [
         X ~ 1.0 => [X ~ 0.5],       # Scalar condition.
         [X ~ 1.0] => X ~ 0.5,       # Scalar affect.

test/reactionsystem_core/reactionsystem.jl

@@ -235,7 +235,7 @@ let
     maj = MassActionJump(symmaj.param_mapper(pars), symmaj.reactant_stoch, symmaj.net_stoch,
                          symmaj.param_mapper, scale_rates = false)
     for i in midxs
-        @test_broken abs(jumps[i].scaled_rates - maj.scaled_rates[i]) < 100 * eps()
+        @test_broken abs(jumps[i].scaled_rates - maj.scaled_rates[i]) < 100 * eps() # This (and next two) tests are broken due to the order in `maj` not being preserved.
         @test jumps[i].reactant_stoch == maj.reactant_stoch[i]
         @test jumps[i].net_stoch == maj.net_stoch[i]
     end
@@ -747,5 +747,5 @@ end
 # there are several places in the code where the `reactionsystem_uptodate` function is called, here
 # the code might need adaptation to take the updated reaction system into account.
 let
-    @test_nowarn  Catalyst.reactionsystem_uptodate_check()
+    @test_nowarn Catalyst.reactionsystem_uptodate_check()
 end

test/upstream/mtk_problem_inputs.jl

@@ -230,7 +230,6 @@ let
             if (ps == ps_valid) && (u0 == u0_valid)
                 XProblem(xsys, u0, (0.0, 1.0), ps); @test true;
             else
-                # Several of these cases do not throw errors (https://github.com/SciML/ModelingToolkit.jl/issues/2624).
                 @test_broken false
                 continue
                 @test_throws Exception XProblem(xsys, u0, (0.0, 1.0), ps)