Skip to content

Commit 6dd11e9

Browse files
committed
try upper bounding SciMLBase
1 parent 78218f1 commit 6dd11e9

File tree

4 files changed

+9
-13
lines changed

4 files changed

+9
-13
lines changed

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ Parameters = "0.12"
6262
Reexport = "0.2, 1.0"
6363
Requires = "1.0"
6464
RuntimeGeneratedFunctions = "0.5.12"
65-
SciMLBase = "2.46"
65+
SciMLBase = "<=2.57.1"
6666
Setfield = "1"
6767
# StructuralIdentifiability = "0.5.8"
6868
SymbolicUtils = "2.1.2, 3.3.0"

src/steady_state_stability.jl

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,6 @@ function steady_state_stability(u::Vector, rs::ReactionSystem, ps;
6060

6161
# Generates the Jacobian at the steady state (technically, `ss_jac` is an `ODEProblem` with dummy values for `u0` and `p`).
6262
J = zeros(length(u), length(u))
63-
@show u
64-
@show ps
65-
@show parameters(ss_jac)
6663
ss_jac = remake(ss_jac; u0 = u, p = ps)
6764
ss_jac.f.jac(J, ss_jac.u0, ss_jac.p, Inf)
6865

test/extensions/stability_computation.jl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ let
7373
# Computes stability using various input forms, and checks that the output is correct.
7474
sss = hc_steady_states(rn, ps_1; u0 = u0_1, show_progress = false)
7575
for u0 in [u0_1, u0_2, u0_3, u0_4], ps in [ps_1, ps_2, ps_3]
76-
@show eltype(first(u0)),eltype(first(ps))
7776
stab_1 = [steady_state_stability(ss, rn, ps) for ss in sss]
7877
ss_jac = steady_state_jac(rn; u0 = u0)
7978
stab_2 = [steady_state_stability(ss, rn, ps; ss_jac = ss_jac) for ss in sss]

test/upstream/mtk_problem_inputs.jl

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -64,35 +64,35 @@ begin
6464
# Vectors not providing default values.
6565
[kp => 1.0, kd => 0.1, k1 => 0.25, Z0 => 10],
6666
[model.kp => 1.0, model.kd => 0.1, model.k1 => 0.25, model.Z0 => 10],
67-
#[:kp => 1.0, :kd => 0.1, :k1 => 0.25, :Z0 => 10],
67+
[:kp => 1.0, :kd => 0.1, :k1 => 0.25, :Z0 => 10],
6868
# Vectors providing default values.
6969
[kp => 1.0, kd => 0.1, k1 => 0.25, k2 => 0.5, Z0 => 10],
7070
[model.kp => 1.0, model.kd => 0.1, model.k1 => 0.25, model.k2 => 0.5, model.Z0 => 10],
71-
#[:kp => 1.0, :kd => 0.1, :k1 => 0.25, :k2 => 0.5, :Z0 => 10],
71+
[:kp => 1.0, :kd => 0.1, :k1 => 0.25, :k2 => 0.5, :Z0 => 10],
7272
# Static vectors not providing default values.
7373
SA[kp => 1.0, kd => 0.1, k1 => 0.25, Z0 => 10],
7474
SA[model.kp => 1.0, model.kd => 0.1, model.k1 => 0.25, model.Z0 => 10],
75-
#SA[:kp => 1.0, :kd => 0.1, :k1 => 0.25, :Z0 => 10],
75+
SA[:kp => 1.0, :kd => 0.1, :k1 => 0.25, :Z0 => 10],
7676
# Static vectors providing default values.
7777
SA[kp => 1.0, kd => 0.1, k1 => 0.25, k2 => 0.5, Z0 => 10],
7878
SA[model.kp => 1.0, model.kd => 0.1, model.k1 => 0.25, model.k2 => 0.5, model.Z0 => 10],
79-
#SA[:kp => 1.0, :kd => 0.1, :k1 => 0.25, :k2 => 0.5, :Z0 => 10],
79+
SA[:kp => 1.0, :kd => 0.1, :k1 => 0.25, :k2 => 0.5, :Z0 => 10],
8080
# Dicts not providing default values.
8181
Dict([kp => 1.0, kd => 0.1, k1 => 0.25, Z0 => 10]),
8282
Dict([model.kp => 1.0, model.kd => 0.1, model.k1 => 0.25, model.Z0 => 10]),
83-
#Dict([:kp => 1.0, :kd => 0.1, :k1 => 0.25, :Z0 => 10]),
83+
Dict([:kp => 1.0, :kd => 0.1, :k1 => 0.25, :Z0 => 10]),
8484
# Dicts providing default values.
8585
Dict([kp => 1.0, kd => 0.1, k1 => 0.25, k2 => 0.5, Z0 => 10]),
8686
Dict([model.kp => 1.0, model.kd => 0.1, model.k1 => 0.25, model.k2 => 0.5, model.Z0 => 10]),
87-
#Dict([:kp => 1.0, :kd => 0.1, :k1 => 0.25, :k2 => 0.5, :Z0 => 10]),
87+
Dict([:kp => 1.0, :kd => 0.1, :k1 => 0.25, :k2 => 0.5, :Z0 => 10]),
8888
# Tuples not providing default values.
8989
(kp => 1.0, kd => 0.1, k1 => 0.25, Z0 => 10),
9090
(model.kp => 1.0, model.kd => 0.1, model.k1 => 0.25, model.Z0 => 10),
91-
#(:kp => 1.0, :kd => 0.1, :k1 => 0.25, :Z0 => 10),
91+
(:kp => 1.0, :kd => 0.1, :k1 => 0.25, :Z0 => 10),
9292
# Tuples providing default values.
9393
(kp => 1.0, kd => 0.1, k1 => 0.25, k2 => 0.5, Z0 => 10),
9494
(model.kp => 1.0, model.kd => 0.1, model.k1 => 0.25, model.k2 => 0.5, model.Z0 => 10),
95-
#(:kp => 1.0, :kd => 0.1, :k1 => 0.25, :k2 => 0.5, :Z0 => 10),
95+
(:kp => 1.0, :kd => 0.1, :k1 => 0.25, :k2 => 0.5, :Z0 => 10),
9696
]
9797
end
9898

0 commit comments

Comments
 (0)