Add tests for various erroneous declarations

Author: TorkelE

src/dsl.jl

@@ -330,7 +330,7 @@ function make_reaction_system(ex::Expr, name)
     end
     forbidden_symbol_check(union(species, parameters))
     forbidden_variable_check(variables)
-    unique_symbol_check(union(species, parameters, variables, ivs))
+    unique_symbol_check(vcat(species, parameters, variables, ivs))
 
     # Creates expressions corresponding to actual code from the internal DSL representation.
     psexpr_init = get_pexpr(parameters_extracted, options)
@@ -783,6 +783,7 @@ function read_observed_options(options, species_n_vars_declared, ivs_sorted)
                 error("A forbidden symbol ($(obs_eq.args[2])) was used as an observable name.")
             end
             if (obs_name in species_n_vars_declared) && is_escaped_expr(obs_eq.args[2])
+                println("HERE")
                 error("An interpolated observable have been used, which has also been explicitly declared within the system using either @species or @variables. This is not permitted.")
             end
             if ((obs_name in species_n_vars_declared) || is_escaped_expr(obs_eq.args[2])) &&

test/dsl/dsl_advanced_model_construction.jl

@@ -267,6 +267,24 @@ let
     @test isequal(rn1,rn2)
 end
 
+# Tests that erroneous metadata declarations yields errors.
+let
+    # Malformed metadata/value separator.
+    @test_throws Exception @eval @reaction_network begin
+        d, X --> 0, [misc=>"Metadata should use `=`, not `=>`."]
+    end
+
+    # Malformed lhs
+    @test_throws Exception @eval @reaction_network begin
+        d, X --> 0, [misc,description=>"Metadata lhs should be a single symbol."]
+    end
+
+    # Malformed metadata separator.
+    @test_throws Exception @eval @reaction_network begin
+        d, X --> 0, [misc=>:misc; description="description"]
+    end
+end
+
 ### Other Tests ###
 
 # Test floating point stoichiometry work.
@@ -344,4 +362,4 @@ let
     rx = Reaction(k[1]*a+k[2], [X[1], X[2]], [Y, C], [1, V[1]], [V[2] * W, B])
     @named arrtest = ReactionSystem([rx], t)
     arrtest == rn
-end
+end

test/dsl/dsl_basic_model_construction.jl

@@ -463,7 +463,7 @@ let
     @test rn1 == rn2
 end
 
-# Tests arrow variants in `@reaction`` macro .
+# Tests arrow variants in `@reaction`` macro.
 let
     @test isequal((@reaction k, 0 --> X), (@reaction k, X <-- 0))
     @test isequal((@reaction k, 0 --> X), (@reaction k, X ⟻ 0))
@@ -496,6 +496,41 @@ let
     @test_throws LoadError @eval @reaction nothing, 0 --> B
     @test_throws LoadError @eval @reaction k, 0 --> im
     @test_throws LoadError @eval @reaction k, 0 --> nothing
+
+    # Checks that non-supported arrow type usage yields error.
+    @test_throws Exception @eval @reaction_network begin
+        d, X ⇻ 0
+    end
 end
 
+### Error Test ###
+
+# Erroneous `@reaction` usage.
+let
+    # Bi-directional reaction using the `@reaction` macro.
+    @test_throws Exception @eval @reaction (k1,k2), X1 <--> X2
 
+    # Bundles reactions.
+    @test_throws Exception @eval @reaction k, (X1,X2) --> 0
+end
+
+# Tests that malformed reactions yields errors.
+let
+    # Checks that malformed combinations of entries yields errors.
+    @test_throws Exception @eval @reaction_network begin
+        d, X --> 0, Y --> 0
+    end
+    @test_throws Exception @eval @reaction_network begin
+        d, X --> 0, [misc="Ok metadata"], [description="Metadata in (erroneously) extra []."]
+    end
+
+    # Checks that incorrect bundling yields error.
+    @test_throws Exception @eval @reaction_network begin
+        (k1,k2,k3), (X1,X2) --> 0
+    end
+
+    # Checks that incorrect stoichiometric expression yields an error.
+    @test_throws Exception @eval @reaction_network begin
+        k, X^Y --> XY
+    end
+end

test/dsl/dsl_options.jl

@@ -414,15 +414,44 @@ let
     spcs = (A, B1, B2, C)
     @test issetequal(unknowns(rn), sts)
     @test issetequal(species(rn), spcs)
+end
 
-    @test_throws ArgumentError begin
-        rn = @reaction_network begin
-            @variables K
-            k, K*A --> B
-        end
+# Tests errors in `@variables` declarations.
+let 
+    # Variable used as species in reaction.
+    @test_throws Exception @eval rn = @reaction_network begin
+        @variables K
+        k, K*A --> B
+    end
+
+    # Tests error when disallowed name is used for variable.
+    @test_throws Exception @eval @reaction_network begin
+        @variables π(t)
+    end
+end
+
+
+# Tests that duplicate iv/parameter/species/variable names cannot be provided.
+let
+    @test_throws Exception @eval @reaction_network begin
+        @spatial_ivs X
+        @species X(t)
+    end
+    @test_throws Exception @eval @reaction_network begin
+        @parameters X
+        @species X(t)
+    end
+    @test_throws Exception @eval @reaction_network begin
+        @species X(t)
+        @variables X(t)
+    end
+    @test_throws Exception @eval @reaction_network begin
+        @parameters X
+        @variables X(t)
     end
 end
 
+
 ### Test Independent Variable Designations ###
 
 # Test ivs in DSL.
@@ -739,6 +768,14 @@ let
         @observables $X ~ X1 + X2
         (k1,k2), X1 <--> X2
     end
+
+    # Observable metadata provided twice.
+    @test_throws Exception @eval @reaction_network begin
+        @species X2 [description="Twice the amount of X"]
+        @observables (X2, [description="X times two."]) ~ 2X 
+        d, X --> 0
+    end
+
 end
 
 
@@ -916,8 +953,15 @@ let
         @equations X ~ p - S
         (P,D), 0 <--> S
     end
+
+    # Differential equation using a forbidden variable (in the DSL).
+    @test_throws Exception @eval @reaction_network begin
+        @equations D(π) ~ -1
+    end
 end
 
+### Other DSL Option Tests ###
+
 # test combinatoric_ratelaws DSL option
 let
     rn = @reaction_network begin
@@ -951,3 +995,11 @@ let
     @unpack k1, A = rn3
     @test isequal(rl, k1*A^2)
 end
+
+# Erroneous `@default_noise_scaling` declaration (other noise scaling tests are mostly in the SDE file).
+let
+    # Default noise scaling with multiple entries.
+    @test_throws Exception @eval @reaction_network begin
+        @default_noise_scaling η1 η2
+    end 
+end