a unknown -> an unknown. Remove reorder_unknown!

Author: TorkelE

docs/src/api/catalyst_api.md

@@ -196,7 +196,6 @@ ModelingToolkit.extend
 ModelingToolkit.compose
 Catalyst.flatten
 merge!(network1::ReactionSystem, network2::ReactionSystem)
-reorder_unknowns!
 ```
 
 ## Network analysis and representations

docs/src/catalyst_applications/simulation_structure_interfacing.md

@@ -127,7 +127,7 @@ oprob[k1]
 ```
 To interface with integrators and solutions we use a similar syntax.
 
-Finally, instead of using `@unpack` to access a symbolic variable or parameter, we can access it directly using `rn.X1`, and thus access a unknown of our `ODEProblem` using
+Finally, instead of using `@unpack` to access a symbolic variable or parameter, we can access it directly using `rn.X1`, and thus access an unknown of our `ODEProblem` using
 ```@example ex2
 oprob[rn.X1]
 ```

src/networkapi.jl

@@ -1440,27 +1440,6 @@ function addspecies!(network::ReactionSystem, s::Num; disablechecks = false)
     addspecies!(network, value(s), disablechecks = disablechecks)
 end
 
-"""
-    reorder_unknowns!(rn, neworder)
-
-Given a [`ReactionSystem`](@ref) and a vector `neworder`, reorders the unknowns of `rn`, i.e.
-`get_unknowns(rn)`, according to `neworder`.
-
-Notes:
-- Currently only supports `ReactionSystem`s without subsystems.
-"""
-function reorder_unknowns!(rn, neworder)
-    reset_networkproperties!(rn)
-
-    permute!(get_unknowns(rn), neworder)
-    if !issorted(get_unknowns(rn); by = !isspecies)
-        @warn "New ordering has resulted in a non-species unknown preceding a species unknown. This is not allowed so unknowns have been resorted to ensure species precede non-species."
-        sort!(get_unknowns(rn); by = !isspecies)
-    end
-    get_species(rn) .= Iterators.filter(isspecies, get_unknowns(rn))
-    nothing
-end
-
 """
     addparam!(network::ReactionSystem, p::Symbolic; disablechecks=false)
 

src/spatial_reaction_systems/lattice_reaction_systems.jl

@@ -28,12 +28,12 @@ struct LatticeReactionSystem{S,T} # <: MT.AbstractTimeDependentSystem
     parameters::Vector{BasicSymbolic{Real}}
     """
     Parameters which values are tied to vertexes (adjacencies), 
-    e.g. (possibly) have a unique value at each vertex of the system.
+    e.g. (possibly) have an unique value at each vertex of the system.
     """
     vertex_parameters::Vector{BasicSymbolic{Real}}
     """
     Parameters which values are tied to edges (adjacencies), 
-    e.g. (possibly) have a unique value at each edge of the system.
+    e.g. (possibly) have an unique value at each edge of the system.
     """
     edge_parameters::Vector{BasicSymbolic{Real}}
 

test/miscellaneous_tests/api.jl

@@ -25,10 +25,6 @@ let
     pset = Set([value(k1) => 1, value(k2) => 2])
     @test issetequal(pset, paramsmap(rs))
 
-    Catalyst.reorder_unknowns!(rs, [3, 1, 2])
-    specset = Set([value(S) => 2, value(I) => 3, value(R) => 1])
-    @test issetequal(specset, speciesmap(rs))
-
     rxs = [Reaction(k1, [S, I], [I], [1, 1], [2]),
         Reaction(k2, [I], [R])]
     @named rs = ReactionSystem(rxs, t, [S, I, R], [k1, k2])